René's URL Explorer Experiment


Title: feat(core): options object to supersede bit flags for `inject()` by alxhub · Pull Request #46649 · angular/angular · GitHub

Open Graph Title: feat(core): options object to supersede bit flags for `inject()` by alxhub · Pull Request #46649 · angular/angular

X Title: feat(core): options object to supersede bit flags for `inject()` by alxhub · Pull Request #46649 · angular/angular

Description: inject() originated as a private API and was made public to support InjectionToken factories in Ivy. For code-size and performance reasons, when we code generate inject() calls we use a bit field to indicate the various injection modes (optional, skip-self, etc). However, this doesn't make for a very nice public API. This commit introduces an alternative object-based API for options. All 4 flags are supported as boolean fields on an options object, and converted to bit flags internally. If TypeScript can prove that optional injection is not requested, it can narrow the return type and remove the null type. DEPRECATION: The bit field signature of inject() has been deprecated, in favor of the new options object. Fixes #46251

Open Graph Description: inject() originated as a private API and was made public to support InjectionToken factories in Ivy. For code-size and performance reasons, when we code generate inject() calls we use a bit field t...

X Description: inject() originated as a private API and was made public to support InjectionToken factories in Ivy. For code-size and performance reasons, when we code generate inject() calls we use a bit field t...

Opengraph URL: https://github.com/angular/angular/pull/46649

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e6ed6fa9-6700-10b1-ed45-a332ca859154
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA91C:399E4B:C07A47:100F99A:6B00F516
html-safe-noncea051642b4a54b0894a2e92914b20af7b06fdfe70f08a610aac7e18745489741f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTFDOjM5OUU0QjpDMDdBNDc6MTAwRjk5QTo2QjAwRjUxNiIsInZpc2l0b3JfaWQiOiIzMTk1NjYxNTEwNjIxODUyOTUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a4b9f0ff34e52708e7ae4f9a76e0709fa7fd514ba91184d15ac1e8160e4c2b5
hovercard-subject-tagpull_request:984225722
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46649/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altinject() originated as a private API and was made public to support InjectionToken factories in Ivy. For code-size and performance reasons, when we code generate inject() calls we use a bit field t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46649/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46649%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46649%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46649/files
Reloadhttps://github.com/angular/angular/pull/46649/files
Reloadhttps://github.com/angular/angular/pull/46649/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:mainhttps://github.com/angular/angular/tree/main
alxhub:inject-typingshttps://github.com/alxhub/angular/tree/inject-typings
Conversation 18 https://github.com/angular/angular/pull/46649
Commits 1 https://github.com/angular/angular/pull/46649/commits
Checks 0 https://github.com/angular/angular/pull/46649/checks
Files changed https://github.com/angular/angular/pull/46649/files
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
feat(core): options object to supersede bit flags for inject() https://github.com/angular/angular/pull/46649/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46649/files
df246bb feat(core): options object to supersede bit flags for `inject()` alxhub Jun 30, 2022 https://github.com/angular/angular/pull/46649/commits/df246bb2358794e3aad53870f1554d84bbe390b2
Clear filters https://github.com/angular/angular/pull/46649/files
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
index.md https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
index.ts https://github.com/angular/angular/pull/46649/files#diff-9e8b8df840edde95e7b2b3c141d80044bd02a1520aa5417f79f322ea4a70eb5b
injector_compatibility.ts https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
injector.ts https://github.com/angular/angular/pull/46649/files#diff-22482223c4af3a5d75b2b7656ce1147c4d9bd99d9b26f38d35084385ea59e21e
di_spec.ts https://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
goldens/public-api/core/index.mdhttps://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
View file https://github.com/alxhub/angular/blob/df246bb2358794e3aad53870f1554d84bbe390b2/goldens/public-api/core/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46649/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/46649/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
packages/core/src/di/index.tshttps://github.com/angular/angular/pull/46649/files#diff-9e8b8df840edde95e7b2b3c141d80044bd02a1520aa5417f79f322ea4a70eb5b
View file https://github.com/alxhub/angular/blob/df246bb2358794e3aad53870f1554d84bbe390b2/packages/core/src/di/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46649/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46649/files#diff-9e8b8df840edde95e7b2b3c141d80044bd02a1520aa5417f79f322ea4a70eb5b
https://github.com/angular/angular/pull/46649/files#diff-9e8b8df840edde95e7b2b3c141d80044bd02a1520aa5417f79f322ea4a70eb5b
packages/core/src/di/injector_compatibility.tshttps://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
View file https://github.com/alxhub/angular/blob/df246bb2358794e3aad53870f1554d84bbe390b2/packages/core/src/di/injector_compatibility.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46649/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 30, 2022https://github.com/angular/angular/pull/46649/files#r911424492
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://angular.io/api/core/InjectFlagshttps://angular.io/api/core/InjectFlags
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
alxhubhttps://github.com/alxhub
Jun 30, 2022https://github.com/angular/angular/pull/46649/files#r911499878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 30, 2022https://github.com/angular/angular/pull/46649/files#r911511287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
https://github.com/angular/angular/pull/46649/files#diff-2338593c7cf389d99b7e809d684d4162c8cff4e58b8182b8cb67af0f3f641ebd
packages/core/src/di/interface/injector.tshttps://github.com/angular/angular/pull/46649/files#diff-22482223c4af3a5d75b2b7656ce1147c4d9bd99d9b26f38d35084385ea59e21e
View file https://github.com/alxhub/angular/blob/df246bb2358794e3aad53870f1554d84bbe390b2/packages/core/src/di/interface/injector.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46649/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46649/files#diff-22482223c4af3a5d75b2b7656ce1147c4d9bd99d9b26f38d35084385ea59e21e
https://github.com/angular/angular/pull/46649/files#diff-22482223c4af3a5d75b2b7656ce1147c4d9bd99d9b26f38d35084385ea59e21e
packages/core/test/acceptance/di_spec.tshttps://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
View file https://github.com/alxhub/angular/blob/df246bb2358794e3aad53870f1554d84bbe390b2/packages/core/test/acceptance/di_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46649/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
JoostKhttps://github.com/JoostK
Jun 30, 2022https://github.com/angular/angular/pull/46649/files#r911421975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46649/files
https://github.com/angular/angular/pull/46649/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.