René's URL Explorer Experiment


Title: fix(router): allow to return `UrlTree` from `CanMatchFn` by dimakuba · Pull Request #46455 · angular/angular · GitHub

Open Graph Title: fix(router): allow to return `UrlTree` from `CanMatchFn` by dimakuba · Pull Request #46455 · angular/angular

X Title: fix(router): allow to return `UrlTree` from `CanMatchFn` by dimakuba · Pull Request #46455 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently it's not possible to return plain UrlTree from CanMatchFn, only wrapped UrlTree into Observable or Promise is allowed. These changes allow to return UrlTree from CanMatchFn.

X Description: Currently it's not possible to return plain UrlTree from CanMatchFn, only wrapped UrlTree into Observable or Promise is allowed. These changes allow to return UrlTree from CanMatchFn.

Opengraph URL: https://github.com/angular/angular/pull/46455

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5c238b6f-2ea8-5d5c-7dd0-17c40a7f9441
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA52:27D3AD:8F959B:B839C4:6B00EC1C
html-safe-nonce0ced6d4893cd30328aeff1ad2e860fe25053a1885dc77dfc97c3386a098c0aa8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTUyOjI3RDNBRDo4Rjk1OUI6QjgzOUM0OjZCMDBFQzFDIiwidmlzaXRvcl9pZCI6IjU2MDcwNDk4MjM1NTY1MjkxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd78833c71592c823ebef035ee913be4764dcbaf071f2747ef0063dbf6d2ce6b8
hovercard-subject-tagpull_request:975359010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46455/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e7482173f771319f18ec5e335e529baa242d704769a756a176f73c0689e0f22a/angular/angular/pull/46455
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e7482173f771319f18ec5e335e529baa242d704769a756a176f73c0689e0f22a/angular/angular/pull/46455
og:image:altCurrently it's not possible to return plain UrlTree from CanMatchFn, only wrapped UrlTree into Observable or Promise is allowed. These changes allow to return UrlTree from CanMatchFn.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedimakuba
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/46455#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46455
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46455
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46455
Reloadhttps://github.com/angular/angular/pull/46455
Reloadhttps://github.com/angular/angular/pull/46455
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
dimakubahttps://github.com/dimakuba
angular:mainhttps://github.com/angular/angular/tree/main
dimakuba:return-url-tree-from-can-match-fnhttps://github.com/dimakuba/angular/tree/return-url-tree-from-can-match-fn
Conversationhttps://github.com/angular/angular/pull/46455
Commits1 (1)https://github.com/angular/angular/pull/46455/commits
Checkshttps://github.com/angular/angular/pull/46455/checks
Files changedhttps://github.com/angular/angular/pull/46455/files
fix(router): allow to return UrlTree from CanMatchFnhttps://github.com/angular/angular/pull/46455#top
dimakubahttps://github.com/dimakuba
angular:mainhttps://github.com/angular/angular/tree/main
dimakuba:return-url-tree-from-can-match-fnhttps://github.com/dimakuba/angular/tree/return-url-tree-from-can-match-fn
https://github.com/dimakuba
dimakubahttps://github.com/dimakuba
Jun 22, 2022https://github.com/angular/angular/pull/46455#issue-1280428125
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/dimakuba
fix(router): allow to return UrlTree from CanMatchFnhttps://github.com/angular/angular/pull/46455/commits/f6cdf9b629155f077cc228f9ef1e4418c10290e7
f6cdf9bhttps://github.com/angular/angular/pull/46455/commits/f6cdf9b629155f077cc228f9ef1e4418c10290e7
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
June 22, 2022 15:56https://github.com/angular/angular/pull/46455#event-6857824122
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
June 22, 2022 17:31https://github.com/angular/angular/pull/46455#event-6858649599
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 22, 2022 https://github.com/angular/angular/pull/46455#pullrequestreview-1015628843
View reviewed changes https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/46455#pullrequestreview-1015628843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
alxhubhttps://github.com/alxhub
jessicajaniukhttps://github.com/jessicajaniuk
June 22, 2022 17:31https://github.com/angular/angular/pull/46455#event-6858651040
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022 https://github.com/angular/angular/pull/46455#pullrequestreview-1015630222
View reviewed changes https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/46455#pullrequestreview-1015630222
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
Jun 22, 2022 https://github.com/angular/angular/pull/46455#pullrequestreview-1015636162
View reviewed changes https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
jessicajaniukhttps://github.com/jessicajaniuk
https://github.com/angular/angular/pull/46455#pullrequestreview-1015636162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
alxhubhttps://github.com/alxhub
June 22, 2022 17:37https://github.com/angular/angular/pull/46455#event-6858690806
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6858693564
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6858693883
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6858694869
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6858774205
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6859256065
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6859723605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022https://github.com/angular/angular/pull/46455#issuecomment-1163566412
abe3759https://github.com/angular/angular/commit/abe3759e2417c0396d75e226edcef2fae99e363b
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
abe3759https://github.com/angular/angular/commit/abe3759e2417c0396d75e226edcef2fae99e363b
Jun 22, 2022https://github.com/angular/angular/pull/46455#event-6859726440
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2022https://github.com/angular/angular/pull/46455#issuecomment-1193148213
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2022https://github.com/angular/angular/pull/46455#event-7050439312
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46455
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
https://github.com/jessicajaniuk
jessicajaniuk https://github.com/jessicajaniuk
https://github.com/angular/angular/pull/46455/files/f6cdf9b629155f077cc228f9ef1e4418c10290e7
Please reload this pagehttps://github.com/angular/angular/pull/46455
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/46455
https://github.com/dimakuba
https://github.com/AndrewKushnir
https://github.com/atscott
https://github.com/jessicajaniuk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.