René's URL Explorer Experiment


Title: fix(core): make parent injector argument required in `createEnvironmentInjector` by AndrewKushnir · Pull Request #46397 · angular/angular · GitHub

Open Graph Title: fix(core): make parent injector argument required in `createEnvironmentInjector` by AndrewKushnir · Pull Request #46397 · angular/angular

X Title: fix(core): make parent injector argument required in `createEnvironmentInjector` by AndrewKushnir · Pull Request #46397 · angular/angular

Description: Previously, the createEnvironmentInjector function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detached from the DI tree, thus having limited value. This commit updates the types of the createEnvironmentInjector function to make the parent injector a required argument. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No. The createEnvironmentInjector API is in the Developer Preview phase (and it's marked as such), so this change can be included into the patch branch.

Open Graph Description: Previously, the createEnvironmentInjector function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detac...

X Description: Previously, the createEnvironmentInjector function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detac...

Opengraph URL: https://github.com/angular/angular/pull/46397

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61945027-aa0f-7074-2e2a-959b772528e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDE6:1F44:938B21:C18DAC:6B010AAA
html-safe-nonce1880635c80332fd6196dd05313dc5f9079ab322c2118f6cd95e87ed49e4090a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREU2OjFGNDQ6OTM4QjIxOkMxOERBQzo2QjAxMEFBQSIsInZpc2l0b3JfaWQiOiI2OTQ4NDUxNzE1OTMwNzIwOTM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac25a4931d6c8f012b1d534d4496a8fdab9dd6315ff3160ee33a7a12f0be6606c4
hovercard-subject-tagpull_request:969829748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46397/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altPreviously, the createEnvironmentInjector function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46397/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46397%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46397%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46397/files
Reloadhttps://github.com/angular/angular/pull/46397/files
Reloadhttps://github.com/angular/angular/pull/46397/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:env-injector-require-parenthttps://github.com/AndrewKushnir/angular/tree/env-injector-require-parent
Conversation 10 https://github.com/angular/angular/pull/46397
Commits 1 https://github.com/angular/angular/pull/46397/commits
Checks 0 https://github.com/angular/angular/pull/46397/checks
Files changed https://github.com/angular/angular/pull/46397/files
Please reload this pagehttps://github.com/angular/angular/pull/46397/files
fix(core): make parent injector argument required in createEnvironmentInjector https://github.com/angular/angular/pull/46397/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46397/files
e5ccc04 fix(core): make parent injector argument required in `createEnvironme… AndrewKushnir Jun 16, 2022 https://github.com/angular/angular/pull/46397/commits/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea
Clear filters https://github.com/angular/angular/pull/46397/files
Please reload this pagehttps://github.com/angular/angular/pull/46397/files
Please reload this pagehttps://github.com/angular/angular/pull/46397/files
index.md https://github.com/angular/angular/pull/46397/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
ng_module_ref.ts https://github.com/angular/angular/pull/46397/files#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27
di_spec.ts https://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
env_injector_standalone_spec.ts https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
environment_injector_spec.ts https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
standalone_spec.ts https://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
goldens/public-api/core/index.mdhttps://github.com/angular/angular/pull/46397/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/goldens/public-api/core/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/46397/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
packages/core/src/render3/ng_module_ref.tshttps://github.com/angular/angular/pull/46397/files#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/packages/core/src/render3/ng_module_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27
https://github.com/angular/angular/pull/46397/files#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27
packages/core/test/acceptance/di_spec.tshttps://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/packages/core/test/acceptance/di_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/46397/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
packages/core/test/acceptance/env_injector_standalone_spec.tshttps://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/packages/core/test/acceptance/env_injector_standalone_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
https://github.com/angular/angular/pull/46397/files#diff-1813cce4c8b51fa97d566c1beaedc87cc897955c3503c0b4dd9622e269bf9f14
packages/core/test/acceptance/environment_injector_spec.tshttps://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/packages/core/test/acceptance/environment_injector_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/46397/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
packages/core/test/acceptance/standalone_spec.tshttps://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
View file https://github.com/AndrewKushnir/angular/blob/e5ccc04b2c0cd9e661648fee65ee1f66d0c42dea/packages/core/test/acceptance/standalone_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46397/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
https://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
https://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
https://github.com/angular/angular/pull/46397/files#diff-a6f8369ec767cde1f1ee9502e55eb402dc91e12da548015b77bb3630be1759cc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.