René's URL Explorer Experiment


Title: CanMatch fixes by atscott · Pull Request #46394 · angular/angular · GitHub

Open Graph Title: CanMatch fixes by atscott · Pull Request #46394 · angular/angular

X Title: CanMatch fixes by atscott · Pull Request #46394 · angular/angular

Description: Commit 1 fix(router): Ensure Route injector is created before running CanMatch guards Once a Route matches via the match or path property, we need to immediately create the injector for the route (if it has providers) before running the CanMatch guards. This is necessary because the CanMatch guards might be provided in the Route providers. Fixes #46386 Commit 2 fix(router): Expose CanMatchFn as public API The CanMatchFn is already exposed in the type signature for canMatch on the Route. This function type should already be exposed as public API but was missed in the initial implementation because the older guards use the any type instead.

Open Graph Description: Commit 1 fix(router): Ensure Route injector is created before running CanMatch guards Once a Route matches via the match or path property, we need to immediately create the injector for the route (...

X Description: Commit 1 fix(router): Ensure Route injector is created before running CanMatch guards Once a Route matches via the match or path property, we need to immediately create the injector for the route (...

Opengraph URL: https://github.com/angular/angular/pull/46394

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2c431317-8607-f0b4-7537-d3d0bbc1903a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8056:E3C4F:ACCFA9:DD8891:6B00F80B
html-safe-noncefec95b4bdbee501b1c6ecf06a3336bddf83d6a2c7d1f35481b9a89c227f08212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDU2OkUzQzRGOkFDQ0ZBOTpERDg4OTE6NkIwMEY4MEIiLCJ2aXNpdG9yX2lkIjoiNTAzMDU1NDgyMzE4Mzg5MDQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7c9cae67c0a88fea5098a10c74b2d5b50fa9a42852a8a876e9b2e195d7ce1e8f
hovercard-subject-tagpull_request:969611301
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46394/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altCommit 1 fix(router): Ensure Route injector is created before running CanMatch guards Once a Route matches via the match or path property, we need to immediately create the injector for the route (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46394/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46394%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46394%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46394/files
Reloadhttps://github.com/angular/angular/pull/46394/files
Reloadhttps://github.com/angular/angular/pull/46394/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:canmatchprovidershttps://github.com/atscott/angular/tree/canmatchproviders
Conversation 6 https://github.com/angular/angular/pull/46394
Commits 2 https://github.com/angular/angular/pull/46394/commits
Checks 0 https://github.com/angular/angular/pull/46394/checks
Files changed https://github.com/angular/angular/pull/46394/files
Please reload this pagehttps://github.com/angular/angular/pull/46394/files
CanMatch fixes https://github.com/angular/angular/pull/46394/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/46394/files
82dcf54 fix(router): Ensure Route injector is created before running CanMatch… atscott Jun 16, 2022 https://github.com/angular/angular/pull/46394/commits/82dcf5466788a08f2f03ab0c18d2303f9788ef8f
af1e85a fix(router): Expose CanMatchFn as public API atscott Jun 16, 2022 https://github.com/angular/angular/pull/46394/commits/af1e85afd52c20819f45152fd941ef6b171b9965
Clear filters https://github.com/angular/angular/pull/46394/files
Please reload this pagehttps://github.com/angular/angular/pull/46394/files
Please reload this pagehttps://github.com/angular/angular/pull/46394/files
index.md https://github.com/angular/angular/pull/46394/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
apply_redirects.ts https://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
index.ts https://github.com/angular/angular/pull/46394/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
models.ts https://github.com/angular/angular/pull/46394/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
recognize.ts https://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
config_matching.ts https://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
apply_redirects.spec.ts https://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
goldens/public-api/router/index.mdhttps://github.com/angular/angular/pull/46394/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/goldens/public-api/router/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/46394/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
packages/router/src/apply_redirects.tshttps://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/src/apply_redirects.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46394/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
packages/router/src/index.tshttps://github.com/angular/angular/pull/46394/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
https://github.com/angular/angular/pull/46394/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
packages/router/src/models.tshttps://github.com/angular/angular/pull/46394/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/src/models.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
Please reload this pagehttps://github.com/angular/angular/pull/46394/files
https://github.com/angular/angular/pull/46394/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
packages/router/src/recognize.tshttps://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/src/recognize.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/46394/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
packages/router/src/utils/config_matching.tshttps://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/src/utils/config_matching.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
https://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
https://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
https://github.com/angular/angular/pull/46394/files#diff-faa5da47d510e443c2c8d83651f1da07898a355fc95f0b246f0f1553a1ecd479
packages/router/test/apply_redirects.spec.tshttps://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
View file https://github.com/atscott/angular/blob/af1e85afd52c20819f45152fd941ef6b171b9965/packages/router/test/apply_redirects.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/46394/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.