| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4688eaa6-e578-9f7a-9a4c-79c1ec7f17c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85E0:11EACE:A049E2:D77127:6B00EC22 |
| html-safe-nonce | 24b97206eb4a23af2d27a90660cac5ab1bb91366c9d2a2433b0ac343df451a4a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUUwOjExRUFDRTpBMDQ5RTI6RDc3MTI3OjZCMDBFQzIyIiwidmlzaXRvcl9pZCI6IjEzOTYyMzAwMzc5MjA4Njk0MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9333e4c272550a013595335c71f6b7ea1717fd888d3dd764c6100a76eddb95c6 |
| hovercard-subject-tag | pull_request:969611301 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46394/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dda28ad64aad7d5347afc85e4b73e301a0810a61b5803847c91e7fc9e27e6836/angular/angular/pull/46394 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dda28ad64aad7d5347afc85e4b73e301a0810a61b5803847c91e7fc9e27e6836/angular/angular/pull/46394 |
| og:image:alt | Commit 1
fix(router): Ensure Route injector is created before running CanMatch guards
Once a Route matches via the match or path property, we need to
immediately create the injector for the route (... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | atscott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/46394#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46394 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46394 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/46394 |
| Reload | https://github.com/angular/angular/pull/46394 |
| Reload | https://github.com/angular/angular/pull/46394 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| atscott | https://github.com/atscott |
| angular:main | https://github.com/angular/angular/tree/main |
| atscott:canmatchproviders | https://github.com/atscott/angular/tree/canmatchproviders |
| Conversation | https://github.com/angular/angular/pull/46394 |
| Commits2 (2) | https://github.com/angular/angular/pull/46394/commits |
| Checks | https://github.com/angular/angular/pull/46394/checks |
| Files changed | https://github.com/angular/angular/pull/46394/files |
| CanMatch fixes | https://github.com/angular/angular/pull/46394#top |
| atscott | https://github.com/atscott |
| angular:main | https://github.com/angular/angular/tree/main |
| atscott:canmatchproviders | https://github.com/atscott/angular/tree/canmatchproviders |
|
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Jun 16, 2022 | https://github.com/angular/angular/pull/46394#issue-1273885965 |
| #46386 | https://github.com/angular/angular/issues/46386 |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
|
| https://github.com/atscott |
| fix(router): Ensure Route injector is created before running CanMatch… | https://github.com/angular/angular/pull/46394/commits/82dcf5466788a08f2f03ab0c18d2303f9788ef8f |
| 82dcf54 | https://github.com/angular/angular/pull/46394/commits/82dcf5466788a08f2f03ab0c18d2303f9788ef8f |
| angular#46386 | https://github.com/angular/angular/issues/46386 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
| Jun 16, 2022 | https://github.com/angular/angular/pull/46394#event-6822942907 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Jun 16, 2022 | https://github.com/angular/angular/pull/46394#event-6822943057 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| alxhub | https://github.com/alxhub |
| jessicajaniuk | https://github.com/jessicajaniuk |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| June 16, 2022 17:39 | https://github.com/angular/angular/pull/46394#event-6822943665 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/6e3087e68d0c9ab2cf7b31e3dcd1dc8ec3e41813..f8d28a34a3beeb67cb983649e4b4e8a56e58db50 |
| 6e3087e | https://github.com/angular/angular/commit/6e3087e68d0c9ab2cf7b31e3dcd1dc8ec3e41813 |
| f8d28a3 | https://github.com/angular/angular/commit/f8d28a34a3beeb67cb983649e4b4e8a56e58db50 |
|
Compare
| https://github.com/angular/angular/compare/6e3087e68d0c9ab2cf7b31e3dcd1dc8ec3e41813..f8d28a34a3beeb67cb983649e4b4e8a56e58db50 |
| June 16, 2022 18:01 | https://github.com/angular/angular/pull/46394#event-6823067819 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 16, 2022
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009753622 |
|
View reviewed changes
| https://github.com/angular/angular/pull/46394/files |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009753622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| packages/router/src/models.ts | https://github.com/angular/angular/pull/46394/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814 |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 16, 2022
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009755142 |
|
View reviewed changes
| https://github.com/angular/angular/pull/46394/files |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009755142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/f8d28a34a3beeb67cb983649e4b4e8a56e58db50..83e4a226ab02f845f667c1103902102770fc7c86 |
| f8d28a3 | https://github.com/angular/angular/commit/f8d28a34a3beeb67cb983649e4b4e8a56e58db50 |
| 83e4a22 | https://github.com/angular/angular/commit/83e4a226ab02f845f667c1103902102770fc7c86 |
|
Compare
| https://github.com/angular/angular/compare/f8d28a34a3beeb67cb983649e4b4e8a56e58db50..83e4a226ab02f845f667c1103902102770fc7c86 |
| June 16, 2022 22:23 | https://github.com/angular/angular/pull/46394#event-6824392516 |
|
| https://github.com/atscott |
| fix(router): Expose CanMatchFn as public API | https://github.com/angular/angular/pull/46394/commits/af1e85afd52c20819f45152fd941ef6b171b9965 |
| af1e85a | https://github.com/angular/angular/pull/46394/commits/af1e85afd52c20819f45152fd941ef6b171b9965 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/83e4a226ab02f845f667c1103902102770fc7c86..af1e85afd52c20819f45152fd941ef6b171b9965 |
| 83e4a22 | https://github.com/angular/angular/commit/83e4a226ab02f845f667c1103902102770fc7c86 |
| af1e85a | https://github.com/angular/angular/commit/af1e85afd52c20819f45152fd941ef6b171b9965 |
|
Compare
| https://github.com/angular/angular/compare/83e4a226ab02f845f667c1103902102770fc7c86..af1e85afd52c20819f45152fd941ef6b171b9965 |
| June 16, 2022 23:01 | https://github.com/angular/angular/pull/46394#event-6824714407 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jun 16, 2022
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009854585 |
|
View reviewed changes
| https://github.com/angular/angular/pull/46394/files/af1e85afd52c20819f45152fd941ef6b171b9965 |
| alxhub | https://github.com/alxhub |
| https://github.com/angular/angular/pull/46394#pullrequestreview-1009854585 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jun 16, 2022 | https://github.com/angular/angular/pull/46394#event-6824968329 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| jessicajaniuk | https://github.com/jessicajaniuk |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| June 16, 2022 23:59 | https://github.com/angular/angular/pull/46394#event-6824968876 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jun 17, 2022 | https://github.com/angular/angular/pull/46394#issuecomment-1159033348 |
| f94c6f4 | https://github.com/angular/angular/commit/f94c6f433dba3924b79f137cfcc49d2dfd4d679c |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| ce20ed0 | https://github.com/angular/angular/commit/ce20ed067f12714ee6488ffe07f1a1c18bb60a15 |
| Jun 17, 2022 | https://github.com/angular/angular/pull/46394#event-6830154493 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 17, 2022
| https://github.com/angular/angular/pull/46394#ref-commit-f94c6f4 |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
| fix(router): Expose CanMatchFn as public API ( | https://github.com/angular/angular/commit/f94c6f433dba3924b79f137cfcc49d2dfd4d679c |
| #46394 | https://github.com/angular/angular/pull/46394 |
| ) | https://github.com/angular/angular/commit/f94c6f433dba3924b79f137cfcc49d2dfd4d679c |
| f94c6f4 | https://github.com/angular/angular/commit/f94c6f433dba3924b79f137cfcc49d2dfd4d679c |
| #46394 | https://github.com/angular/angular/pull/46394 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jul 18, 2022 | https://github.com/angular/angular/pull/46394#issuecomment-1187686344 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jul 18, 2022 | https://github.com/angular/angular/pull/46394#event-7013443406 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46394 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/46394/files/af1e85afd52c20819f45152fd941ef6b171b9965 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/46394/files/f8d28a34a3beeb67cb983649e4b4e8a56e58db50 |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
|
canMatch check throws NullInjectorError for a guard provided at the route level
| https://github.com/angular/angular/issues/46386 |
| Please reload this page | https://github.com/angular/angular/pull/46394 |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/alxhub |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |