René's URL Explorer Experiment


Title: feat(upgrade): more closely align `UpgradeModule#bootstrap()` with `angular.bootstrap()` by gkalpak · Pull Request #46214 · angular/angular · GitHub

Open Graph Title: feat(upgrade): more closely align `UpgradeModule#bootstrap()` with `angular.bootstrap()` by gkalpak · Pull Request #46214 · angular/angular

X Title: feat(upgrade): more closely align `UpgradeModule#bootstrap()` with `angular.bootstrap()` by gkalpak · Pull Request #46214 · angular/angular

Description: Previously, UpgradeModule#bootstrap(), while being a replacement for and accepting the same arguments as angular.bootstrap(), did not return the same value as angular.bootstrap() (i.e. the AngularJS injector in most cases). This made it less straight forward to migrate some usecases that relied on the return value of .bootstrap(). The work-around was to access the injector via UpgradeModule#$injector (after the app had been bootstrapped with UpgradeModule#bootstrap()). This commit addresses this by ensuring UpgradeModule#bootstrap() returns the same value as angular.bootstrap(), making it easier to replace the latter with the former. Fixes #46211.

Open Graph Description: Previously, UpgradeModule#bootstrap(), while being a replacement for and accepting the same arguments as angular.bootstrap(), did not return the same value as angular.bootstrap() (i.e. the AngularJ...

X Description: Previously, UpgradeModule#bootstrap(), while being a replacement for and accepting the same arguments as angular.bootstrap(), did not return the same value as angular.bootstrap() (i.e. the AngularJ...

Opengraph URL: https://github.com/angular/angular/pull/46214

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a66bbfa-27e5-faf0-3369-ee45b46bb813
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE036:6AE86:4A238:5CBD2:6B00F1A5
html-safe-nonce219c19ad576e8aac51183218dc7d9a462193d44d67b13334260079629ee01cfc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDM2OjZBRTg2OjRBMjM4OjVDQkQyOjZCMDBGMUE1IiwidmlzaXRvcl9pZCI6IjU2NzkzMDEyNDA4Nzg1OTI0MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc82e10f666d188be572a8960feba5599121568fb890fdce6b1df1ac6af6d2f4d
hovercard-subject-tagpull_request:954770090
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46214/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, UpgradeModule#bootstrap(), while being a replacement for and accepting the same arguments as angular.bootstrap(), did not return the same value as angular.bootstrap() (i.e. the AngularJ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46214/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46214%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46214%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46214/files
Reloadhttps://github.com/angular/angular/pull/46214/files
Reloadhttps://github.com/angular/angular/pull/46214/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:mainhttps://github.com/angular/angular/tree/main
gkalpak:fix-upgrade-bootstraphttps://github.com/gkalpak/angular/tree/fix-upgrade-bootstrap
Conversation 6 https://github.com/angular/angular/pull/46214
Commits 2 https://github.com/angular/angular/pull/46214/commits
Checks 0 https://github.com/angular/angular/pull/46214/checks
Files changed https://github.com/angular/angular/pull/46214/files
Please reload this pagehttps://github.com/angular/angular/pull/46214/files
feat(upgrade): more closely align UpgradeModule#bootstrap() with angular.bootstrap() https://github.com/angular/angular/pull/46214/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/46214/files
6bfb0bc test(upgrade): add some tests for `UpgradeModule` gkalpak Jun 1, 2022 https://github.com/angular/angular/pull/46214/commits/6bfb0bcd9425f6b07cbcb30e3107e8dbb4ad3696
c16a2d6 feat(upgrade): more closely align `UpgradeModule#bootstrap()` with `a… gkalpak Jun 1, 2022 https://github.com/angular/angular/pull/46214/commits/c16a2d62b2dc29ca4641c99bef9d1d92389fcfdb
Clear filters https://github.com/angular/angular/pull/46214/files
Please reload this pagehttps://github.com/angular/angular/pull/46214/files
Please reload this pagehttps://github.com/angular/angular/pull/46214/files
index.md https://github.com/angular/angular/pull/46214/files#diff-36d35fea21bed61df7ec8e3f39e3b2ffe01b8cd9ce5a64729ec9f60a31121bf0
upgrade_module.ts https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
upgrade_module_spec.ts https://github.com/angular/angular/pull/46214/files#diff-41de747e58a5166591c1d58da8e2e25a2be3baa80e14f0ea22e60957fcb90c5c
goldens/public-api/upgrade/static/index.mdhttps://github.com/angular/angular/pull/46214/files#diff-36d35fea21bed61df7ec8e3f39e3b2ffe01b8cd9ce5a64729ec9f60a31121bf0
View file https://github.com/gkalpak/angular/blob/c16a2d62b2dc29ca4641c99bef9d1d92389fcfdb/goldens/public-api/upgrade/static/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46214/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46214/files#diff-36d35fea21bed61df7ec8e3f39e3b2ffe01b8cd9ce5a64729ec9f60a31121bf0
https://github.com/angular/angular/pull/46214/files#diff-36d35fea21bed61df7ec8e3f39e3b2ffe01b8cd9ce5a64729ec9f60a31121bf0
packages/upgrade/static/src/upgrade_module.tshttps://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
View file https://github.com/gkalpak/angular/blob/c16a2d62b2dc29ca4641c99bef9d1d92389fcfdb/packages/upgrade/static/src/upgrade_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46214/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
https://github.com/angular/angular/pull/46214/files#diff-de9925ea41f2874ff3864f801af1832a5d0574646b47e687191d3d11fa210b5f
packages/upgrade/static/test/integration/upgrade_module_spec.tshttps://github.com/angular/angular/pull/46214/files#diff-41de747e58a5166591c1d58da8e2e25a2be3baa80e14f0ea22e60957fcb90c5c
View file https://github.com/gkalpak/angular/blob/c16a2d62b2dc29ca4641c99bef9d1d92389fcfdb/packages/upgrade/static/test/integration/upgrade_module_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46214/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.