René's URL Explorer Experiment


Title: feat(compiler): Add extended diagnostic to warn when text attributes … by atscott · Pull Request #46161 · angular/angular · GitHub

Open Graph Title: feat(compiler): Add extended diagnostic to warn when text attributes … by atscott · Pull Request #46161 · angular/angular

X Title: feat(compiler): Add extended diagnostic to warn when text attributes … by atscott · Pull Request #46161 · angular/angular

Description: …are intended to be bindings https://angular.io/guide/attribute-binding#attribute-class-and-style-bindings Angular supports attr., style., and class. binding prefixes to bind attributes, styles, and classes. If the key does not have the binding syntax [] or the value does not have an interpolation {{}}, the attribute will not be interpreted as a binding. This diagnostic warns the user when the attributes listed above will not be interpreted as bindings. resolves #46137

Open Graph Description: …are intended to be bindings https://angular.io/guide/attribute-binding#attribute-class-and-style-bindings Angular supports attr., style., and class. binding prefixes to bind attributes, styles, an...

X Description: …are intended to be bindings https://angular.io/guide/attribute-binding#attribute-class-and-style-bindings Angular supports attr., style., and class. binding prefixes to bind attributes, styles, an...

Opengraph URL: https://github.com/angular/angular/pull/46161

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8bd86a72-0ccd-151e-9cb3-21d58afdb424
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF96:EA09B:DAB0A2:122C7E1:6B0101D7
html-safe-nonce9fb5a9a8a4a283e67d030a5319b70603f788b96e1f0a1daac4585ab9c80f51f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjk2OkVBMDlCOkRBQjBBMjoxMjJDN0UxOjZCMDEwMUQ3IiwidmlzaXRvcl9pZCI6IjI3NDAzMDcxMDY1MDk5NDczNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac867a4de6f803064de1740dffde5bee27e01bb73bd85170c106505c978fcc3bc9
hovercard-subject-tagpull_request:948787730
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46161/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:alt…are intended to be bindings https://angular.io/guide/attribute-binding#attribute-class-and-style-bindings Angular supports attr., style., and class. binding prefixes to bind attributes, styles, an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46161/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46161%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46161%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46161/files
Reloadhttps://github.com/angular/angular/pull/46161/files
Reloadhttps://github.com/angular/angular/pull/46161/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:attributenotbindinghttps://github.com/atscott/angular/tree/attributenotbinding
Conversation 18 https://github.com/angular/angular/pull/46161
Commits 3 https://github.com/angular/angular/pull/46161/commits
Checks 0 https://github.com/angular/angular/pull/46161/checks
Files changed https://github.com/angular/angular/pull/46161/files
Please reload this pagehttps://github.com/angular/angular/pull/46161/files
feat(compiler): Add extended diagnostic to warn when text attributes … https://github.com/angular/angular/pull/46161/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/46161/files
7825bf7 feat(compiler): Add extended diagnostic to warn when text attributes … atscott May 26, 2022 https://github.com/angular/angular/pull/46161/commits/7825bf73b5fbb82bedc5cd59a810be9c21e63883
9bc2bdc fixup! feat(compiler): Add extended diagnostic to warn when text attr… atscott Jun 28, 2022 https://github.com/angular/angular/pull/46161/commits/9bc2bdc39a75f43bd6fa8d649bd756d87c0352c4
2f8da46 fixup! feat(compiler): Add extended diagnostic to warn when text attr… atscott Jun 28, 2022 https://github.com/angular/angular/pull/46161/commits/2f8da46a0f2d28a3a7c3652a0b5254e085992b46
Clear filters https://github.com/angular/angular/pull/46161/files
Please reload this pagehttps://github.com/angular/angular/pull/46161/files
Please reload this pagehttps://github.com/angular/angular/pull/46161/files
error_code.md https://github.com/angular/angular/pull/46161/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
extended_template_diagnostic_name.md https://github.com/angular/angular/pull/46161/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
error_code.ts https://github.com/angular/angular/pull/46161/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
extended_template_diagnostic_name.ts https://github.com/angular/angular/pull/46161/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
BUILD.bazel https://github.com/angular/angular/pull/46161/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
BUILD.bazel https://github.com/angular/angular/pull/46161/files#diff-7c65d47304053b8b6961be0ac67e8f36ed7744774759fbe03d9b638983bd1a4b
index.ts https://github.com/angular/angular/pull/46161/files#diff-a3176da70c82eee518ca42ed3fad9ce659f203cc94c421b039f7e6d9ffa22d13
index.ts https://github.com/angular/angular/pull/46161/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
BUILD.bazel https://github.com/angular/angular/pull/46161/files#diff-911727d42c29c4afb822028113665b6d273ffe7f87a0b77fb523138e41fc3f15
text_attribute_not_binding_spec.ts https://github.com/angular/angular/pull/46161/files#diff-9f7fdbb7c817353fa48eb3313fb8522268a69d6814d3b92f5b1b12b9855c9925
goldens/public-api/compiler-cli/error_code.mdhttps://github.com/angular/angular/pull/46161/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/goldens/public-api/compiler-cli/error_code.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
https://github.com/angular/angular/pull/46161/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
goldens/public-api/compiler-cli/extended_template_diagnostic_name.mdhttps://github.com/angular/angular/pull/46161/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/goldens/public-api/compiler-cli/extended_template_diagnostic_name.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
https://github.com/angular/angular/pull/46161/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.tshttps://github.com/angular/angular/pull/46161/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
https://github.com/angular/angular/pull/46161/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.tshttps://github.com/angular/angular/pull/46161/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazelhttps://github.com/angular/angular/pull/46161/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
...s/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding/BUILD.bazelhttps://github.com/angular/angular/pull/46161/files#diff-7c65d47304053b8b6961be0ac67e8f36ed7744774759fbe03d9b638983bd1a4b
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
...ages/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding/index.tshttps://github.com/angular/angular/pull/46161/files#diff-a3176da70c82eee518ca42ed3fad9ce659f203cc94c421b039f7e6d9ffa22d13
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/46161/files
packages/compiler-cli/src/ngtsc/typecheck/extended/index.tshttps://github.com/angular/angular/pull/46161/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46161/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
https://github.com/angular/angular/pull/46161/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
...piler-cli/src/ngtsc/typecheck/extended/test/checks/text_attribute_not_binding/BUILD.bazelhttps://github.com/angular/angular/pull/46161/files#diff-911727d42c29c4afb822028113665b6d273ffe7f87a0b77fb523138e41fc3f15
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/text_attribute_not_binding/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
...echeck/extended/test/checks/text_attribute_not_binding/text_attribute_not_binding_spec.tshttps://github.com/angular/angular/pull/46161/files#diff-9f7fdbb7c817353fa48eb3313fb8522268a69d6814d3b92f5b1b12b9855c9925
View file https://github.com/atscott/angular/blob/2f8da46a0f2d28a3a7c3652a0b5254e085992b46/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/text_attribute_not_binding/text_attribute_not_binding_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46161/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/46161/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.