René's URL Explorer Experiment


Title: feat(compiler-cli): detect missing control flow directive imports by AndrewKushnir · Pull Request #46146 · angular/angular · GitHub

Open Graph Title: feat(compiler-cli): detect missing control flow directive imports by AndrewKushnir · Pull Request #46146 · angular/angular

X Title: feat(compiler-cli): detect missing control flow directive imports by AndrewKushnir · Pull Request #46146 · angular/angular

Description: This commit adds an extended diagnostics check that verifies that all control flow directives (such as ngIf, ngFor) have matching directives. Currently there is no diagnistics produced for such cases, which makes it harder for developers to detect and find a problem. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit adds an extended diagnostics check that verifies that all control flow directives (such as ngIf, ngFor) have matching directives. Currently there is no diagnistics produced for such cas...

X Description: This commit adds an extended diagnostics check that verifies that all control flow directives (such as ngIf, ngFor) have matching directives. Currently there is no diagnistics produced for such cas...

Opengraph URL: https://github.com/angular/angular/pull/46146

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:10609799-6c00-f5dd-b907-1413555b7715
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE98:29FFA9:AD653C:DD3ABB:6B00F521
html-safe-noncedd50f9a867ec699887a944476cdb56ad8424f5e4a99368afa6bd43a5c4054e2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTk4OjI5RkZBOTpBRDY1M0M6REQzQUJCOjZCMDBGNTIxIiwidmlzaXRvcl9pZCI6IjExOTg5OTA5MTkwNTE4MzQ2NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac43d2b4d8c34dd7876fbbf084eeab5e709b5fdfc6f09feae5e63ab71af1cfaeb9
hovercard-subject-tagpull_request:947722628
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46146/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altThis commit adds an extended diagnostics check that verifies that all control flow directives (such as ngIf, ngFor) have matching directives. Currently there is no diagnistics produced for such cas...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46146/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46146%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46146%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46146/files
Reloadhttps://github.com/angular/angular/pull/46146/files
Reloadhttps://github.com/angular/angular/pull/46146/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:error-message-improvementhttps://github.com/AndrewKushnir/angular/tree/error-message-improvement
Conversation 19 https://github.com/angular/angular/pull/46146
Commits 1 https://github.com/angular/angular/pull/46146/commits
Checks 0 https://github.com/angular/angular/pull/46146/checks
Files changed https://github.com/angular/angular/pull/46146/files
Please reload this pagehttps://github.com/angular/angular/pull/46146/files
feat(compiler-cli): detect missing control flow directive imports https://github.com/angular/angular/pull/46146/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46146/files
66bdbb1 feat(compiler-cli): detect missing control flow directive imports in … AndrewKushnir May 25, 2022 https://github.com/angular/angular/pull/46146/commits/66bdbb159d28f5f8171e533d66daa28271f0c732
Clear filters https://github.com/angular/angular/pull/46146/files
Please reload this pagehttps://github.com/angular/angular/pull/46146/files
Please reload this pagehttps://github.com/angular/angular/pull/46146/files
error_code.md https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
extended_template_diagnostic_name.md https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
error_code.ts https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
extended_template_diagnostic_name.ts https://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
api.ts https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
scope.ts https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
BUILD.bazel https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
BUILD.bazel https://github.com/angular/angular/pull/46146/files#diff-6b81e941bb7d236cb766b1d5798bf1b0dd89c604bd3b083355a0a4c7560a320a
index.ts https://github.com/angular/angular/pull/46146/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
index.ts https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
BUILD.bazel https://github.com/angular/angular/pull/46146/files#diff-2f13aee397df3586668217c2db7feab247f1129b2ea541591093d60b10cb8d09
missing_control_flow_directive_spec.ts https://github.com/angular/angular/pull/46146/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
index.ts https://github.com/angular/angular/pull/46146/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
goldens/public-api/compiler-cli/error_code.mdhttps://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/goldens/public-api/compiler-cli/error_code.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
goldens/public-api/compiler-cli/extended_template_diagnostic_name.mdhttps://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/goldens/public-api/compiler-cli/extended_template_diagnostic_name.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.tshttps://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.tshttps://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
packages/compiler-cli/src/ngtsc/typecheck/api/api.tshttps://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/api/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
packages/compiler-cli/src/ngtsc/typecheck/api/scope.tshttps://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/api/scope.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazelhttps://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
...mpiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/BUILD.bazelhttps://github.com/angular/angular/pull/46146/files#diff-6b81e941bb7d236cb766b1d5798bf1b0dd89c604bd3b083355a0a4c7560a320a
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
.../compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.tshttps://github.com/angular/angular/pull/46146/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
packages/compiler-cli/src/ngtsc/typecheck/extended/index.tshttps://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
...r-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/BUILD.bazelhttps://github.com/angular/angular/pull/46146/files#diff-2f13aee397df3586668217c2db7feab247f1129b2ea541591093d60b10cb8d09
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
...xtended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.tshttps://github.com/angular/angular/pull/46146/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
View file https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46146/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/46146/files
Please reload this pagehttps://github.com/angular/angular/pull/46146/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.