| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:10609799-6c00-f5dd-b907-1413555b7715 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE98:29FFA9:AD653C:DD3ABB:6B00F521 |
| html-safe-nonce | dd50f9a867ec699887a944476cdb56ad8424f5e4a99368afa6bd43a5c4054e2c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTk4OjI5RkZBOTpBRDY1M0M6REQzQUJCOjZCMDBGNTIxIiwidmlzaXRvcl9pZCI6IjExOTg5OTA5MTkwNTE4MzQ2NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 43d2b4d8c34dd7876fbbf084eeab5e709b5fdfc6f09feae5e63ab71af1cfaeb9 |
| hovercard-subject-tag | pull_request:947722628 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/46146/files |
| twitter:image | https://avatars.githubusercontent.com/u/43554145?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/43554145?s=400&v=4 |
| og:image:alt | This commit adds an extended diagnostics check that verifies that all control flow directives (such as ngIf, ngFor) have matching directives. Currently there is no diagnistics produced for such cas... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/46146/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46146%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46146%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/46146/files |
| Reload | https://github.com/angular/angular/pull/46146/files |
| Reload | https://github.com/angular/angular/pull/46146/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| AndrewKushnir | https://github.com/AndrewKushnir |
| angular:main | https://github.com/angular/angular/tree/main |
| AndrewKushnir:error-message-improvement | https://github.com/AndrewKushnir/angular/tree/error-message-improvement |
|
Conversation
19
| https://github.com/angular/angular/pull/46146 |
|
Commits
1
| https://github.com/angular/angular/pull/46146/commits |
|
Checks
0
| https://github.com/angular/angular/pull/46146/checks |
|
Files changed
| https://github.com/angular/angular/pull/46146/files |
| Please reload this page | https://github.com/angular/angular/pull/46146/files |
|
feat(compiler-cli): detect missing control flow directive imports
| https://github.com/angular/angular/pull/46146/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/46146/files |
|
66bdbb1
feat(compiler-cli): detect missing control flow directive imports in …
AndrewKushnir May 25, 2022
| https://github.com/angular/angular/pull/46146/commits/66bdbb159d28f5f8171e533d66daa28271f0c732 |
|
Clear filters
| https://github.com/angular/angular/pull/46146/files |
| Please reload this page | https://github.com/angular/angular/pull/46146/files |
| Please reload this page | https://github.com/angular/angular/pull/46146/files |
|
error_code.md
| https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879 |
|
extended_template_diagnostic_name.md
| https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2 |
|
error_code.ts
| https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e |
|
extended_template_diagnostic_name.ts
| https://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce |
|
api.ts
| https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc |
|
scope.ts
| https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7 |
|
BUILD.bazel
| https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e |
|
BUILD.bazel
| https://github.com/angular/angular/pull/46146/files#diff-6b81e941bb7d236cb766b1d5798bf1b0dd89c604bd3b083355a0a4c7560a320a |
|
index.ts
| https://github.com/angular/angular/pull/46146/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2 |
|
index.ts
| https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6 |
|
BUILD.bazel
| https://github.com/angular/angular/pull/46146/files#diff-2f13aee397df3586668217c2db7feab247f1129b2ea541591093d60b10cb8d09 |
|
missing_control_flow_directive_spec.ts
| https://github.com/angular/angular/pull/46146/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122 |
|
index.ts
| https://github.com/angular/angular/pull/46146/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546 |
| goldens/public-api/compiler-cli/error_code.md | https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/goldens/public-api/compiler-cli/error_code.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879 |
|
| https://github.com/angular/angular/pull/46146/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879 |
| goldens/public-api/compiler-cli/extended_template_diagnostic_name.md | https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/goldens/public-api/compiler-cli/extended_template_diagnostic_name.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2 |
|
| https://github.com/angular/angular/pull/46146/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2 |
| packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts | https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e |
|
| https://github.com/angular/angular/pull/46146/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e |
| packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts | https://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce |
| packages/compiler-cli/src/ngtsc/typecheck/api/api.ts | https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/api/api.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc |
|
| https://github.com/angular/angular/pull/46146/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc |
| packages/compiler-cli/src/ngtsc/typecheck/api/scope.ts | https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/api/scope.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7 |
|
| https://github.com/angular/angular/pull/46146/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7 |
| packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel | https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e |
|
| https://github.com/angular/angular/pull/46146/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e |
| ...mpiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/BUILD.bazel | https://github.com/angular/angular/pull/46146/files#diff-6b81e941bb7d236cb766b1d5798bf1b0dd89c604bd3b083355a0a4c7560a320a |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/BUILD.bazel |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
| .../compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.ts | https://github.com/angular/angular/pull/46146/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
| packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts | https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6 |
|
| https://github.com/angular/angular/pull/46146/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6 |
| ...r-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/BUILD.bazel | https://github.com/angular/angular/pull/46146/files#diff-2f13aee397df3586668217c2db7feab247f1129b2ea541591093d60b10cb8d09 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/BUILD.bazel |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
| ...xtended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.ts | https://github.com/angular/angular/pull/46146/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122 |
|
View file
| https://github.com/AndrewKushnir/angular/blob/66bdbb159d28f5f8171e533d66daa28271f0c732/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46146/{{ revealButtonHref }} |
| Please reload this page | https://github.com/angular/angular/pull/46146/files |
| Please reload this page | https://github.com/angular/angular/pull/46146/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |