René's URL Explorer Experiment


Title: feat(http): improve error message for nullish header by markostanimirovic · Pull Request #46059 · angular/angular · GitHub

Open Graph Title: feat(http): improve error message for nullish header by markostanimirovic · Pull Request #46059 · angular/angular

X Title: feat(http): improve error message for nullish header by markostanimirovic · Pull Request #46059 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #46048 What is the new behavior? Improved error message for nullish headers. Does this PR introduce a breaking change? Yes No

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/46059

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e226b609-438f-5349-ec2a-03bee357d7ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8060:21E3E7:C73EB2:1084757:6B00F518
html-safe-noncef73fa9be963f9ee5ffbb1f924cd2b0daca3d8fa7f36e67a4a9e3ce9e274ddb7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDYwOjIxRTNFNzpDNzNFQjI6MTA4NDc1Nzo2QjAwRjUxOCIsInZpc2l0b3JfaWQiOiI4ODQwNzcyNjQxMDcwNTc2OTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd5bc5deafda4650896dccfb8157ffd31244b453093ffa766247778efc39a78d0
hovercard-subject-tagpull_request:941386563
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46059/files
twitter:imagehttps://avatars.githubusercontent.com/u/17877290?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17877290?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46059/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46059%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46059%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46059/files
Reloadhttps://github.com/angular/angular/pull/46059/files
Reloadhttps://github.com/angular/angular/pull/46059/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
markostanimirovichttps://github.com/markostanimirovic
angular:mainhttps://github.com/angular/angular/tree/main
markostanimirovic:feat/http/nullish-header-error-messagehttps://github.com/markostanimirovic/angular/tree/feat/http/nullish-header-error-message
Conversation 7 https://github.com/angular/angular/pull/46059
Commits 1 https://github.com/angular/angular/pull/46059/commits
Checks 0 https://github.com/angular/angular/pull/46059/checks
Files changed https://github.com/angular/angular/pull/46059/files
Please reload this pagehttps://github.com/angular/angular/pull/46059/files
feat(http): improve error message for nullish header https://github.com/angular/angular/pull/46059/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46059/files
c646140 feat(http): improve error message for nullish header markostanimirovic Jun 14, 2022 https://github.com/angular/angular/pull/46059/commits/c646140f905518a75366fe1f6e1e3ec69f2e3fad
Clear filters https://github.com/angular/angular/pull/46059/files
Please reload this pagehttps://github.com/angular/angular/pull/46059/files
Please reload this pagehttps://github.com/angular/angular/pull/46059/files
headers.ts https://github.com/angular/angular/pull/46059/files#diff-c3b40cec0229ca30d99c3e73358744c4340f3bf5ce9ab4a882cf2b6e563637fd
client_spec.ts https://github.com/angular/angular/pull/46059/files#diff-9bd3e0ec36dc94530c743ce6e81ad7d168043e55d4838c5a1d0a2890734ad587
headers_spec.ts https://github.com/angular/angular/pull/46059/files#diff-a3d6a8c709d4d40c03f6c7fc3f80f8593658123faef7e4595302911aa8b39a4b
packages/common/http/src/headers.tshttps://github.com/angular/angular/pull/46059/files#diff-c3b40cec0229ca30d99c3e73358744c4340f3bf5ce9ab4a882cf2b6e563637fd
View file https://github.com/markostanimirovic/angular/blob/c646140f905518a75366fe1f6e1e3ec69f2e3fad/packages/common/http/src/headers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46059/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46059/files#diff-c3b40cec0229ca30d99c3e73358744c4340f3bf5ce9ab4a882cf2b6e563637fd
https://github.com/angular/angular/pull/46059/files#diff-c3b40cec0229ca30d99c3e73358744c4340f3bf5ce9ab4a882cf2b6e563637fd
https://github.com/angular/angular/pull/46059/files#diff-c3b40cec0229ca30d99c3e73358744c4340f3bf5ce9ab4a882cf2b6e563637fd
packages/common/http/test/client_spec.tshttps://github.com/angular/angular/pull/46059/files#diff-9bd3e0ec36dc94530c743ce6e81ad7d168043e55d4838c5a1d0a2890734ad587
View file https://github.com/markostanimirovic/angular/blob/c646140f905518a75366fe1f6e1e3ec69f2e3fad/packages/common/http/test/client_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46059/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46059/files#diff-9bd3e0ec36dc94530c743ce6e81ad7d168043e55d4838c5a1d0a2890734ad587
packages/common/http/test/headers_spec.tshttps://github.com/angular/angular/pull/46059/files#diff-a3d6a8c709d4d40c03f6c7fc3f80f8593658123faef7e4595302911aa8b39a4b
View file https://github.com/markostanimirovic/angular/blob/c646140f905518a75366fe1f6e1e3ec69f2e3fad/packages/common/http/test/headers_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46059/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46059/files#diff-a3d6a8c709d4d40c03f6c7fc3f80f8593658123faef7e4595302911aa8b39a4b
Please reload this pagehttps://github.com/angular/angular/pull/46059/files
https://github.com/angular/angular/pull/46059/files#diff-a3d6a8c709d4d40c03f6c7fc3f80f8593658123faef7e4595302911aa8b39a4b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.