René's URL Explorer Experiment


Title: fix(core): set correct context for inject() for component ctors by alxhub · Pull Request #45991 · angular/angular · GitHub

Open Graph Title: fix(core): set correct context for inject() for component ctors by alxhub · Pull Request #45991 · angular/angular

X Title: fix(core): set correct context for inject() for component ctors by alxhub · Pull Request #45991 · angular/angular

Description: The inject() function was introduced with Ivy to support imperative injection in factory/constructor contexts, such as directive or service constructors as well as factory functions defined in @Injectable or InjectionToken. However, inject() in a component/directive constructor did not work due to a flaw in the logic for creating the internal factory for components/directives. The original intention of this logic was to keep ɵɵdirectiveInject tree- shakable for applications which don't use any component-level DI. However, this breaks the inject() functionality for component/directive constructors. This commit fixes that issue and adds tests for all the various cases in which inject() should function. As a result ɵɵdirectiveInject is no longer tree-shakable, but that's totally acceptable as any application that uses *ngIf or *ngFor already contains this function. It's possible to change how inject() works to restore this tree-shakability if needed.

Open Graph Description: The inject() function was introduced with Ivy to support imperative injection in factory/constructor contexts, such as directive or service constructors as well as factory functions defined in @Inj...

X Description: The inject() function was introduced with Ivy to support imperative injection in factory/constructor contexts, such as directive or service constructors as well as factory functions defined in @Inj...

Opengraph URL: https://github.com/angular/angular/pull/45991

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:535ec619-02b5-6ccb-b550-1d801c31da13
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1B0:2679E9:24FF9D8:31667C9:6B01A422
html-safe-nonce97293e917a92e4c8f0f579773610e6994ec8d644eb06991e3a977650f1875679
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUIwOjI2NzlFOToyNEZGOUQ4OjMxNjY3Qzk6NkIwMUE0MjIiLCJ2aXNpdG9yX2lkIjoiMzQ4NTcyMjQwMTgzNTE2NDcwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac354283029c6f73a9add4b6c80f375dbc994e59abd7c38e7b72e1e9467e7df6bf
hovercard-subject-tagpull_request:936165768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45991/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altThe inject() function was introduced with Ivy to support imperative injection in factory/constructor contexts, such as directive or service constructors as well as factory functions defined in @Inj...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45991/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45991%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45991%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45991/files
Reloadhttps://github.com/angular/angular/pull/45991/files
Reloadhttps://github.com/angular/angular/pull/45991/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:mainhttps://github.com/angular/angular/tree/main
alxhub:fix-injecthttps://github.com/alxhub/angular/tree/fix-inject
Conversation 10 https://github.com/angular/angular/pull/45991
Commits 1 https://github.com/angular/angular/pull/45991/commits
Checks 0 https://github.com/angular/angular/pull/45991/checks
Files changed https://github.com/angular/angular/pull/45991/files
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
fix(core): set correct context for inject() for component ctors https://github.com/angular/angular/pull/45991/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/45991/files
425c755 fix(core): set correct context for inject() for component ctors alxhub May 13, 2022 https://github.com/angular/angular/pull/45991/commits/425c75593376dc38b0cc664e35f0392460b6588b
Clear filters https://github.com/angular/angular/pull/45991/files
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
integration-payloads.json https://github.com/angular/angular/pull/45991/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
shared.ts https://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
di_spec.ts https://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
bundle.golden_symbols.json https://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
bundle.golden_symbols.json https://github.com/angular/angular/pull/45991/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/45991/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/45991/files#diff-90fb073da08eb200a8d9bd0ff862812fa7f42e4cdc450a8f3d4ab8338b762e20
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/45991/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/alxhub/angular/blob/425c75593376dc38b0cc664e35f0392460b6588b/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45991/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/45991/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/45991/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
View file https://github.com/alxhub/angular/blob/425c75593376dc38b0cc664e35f0392460b6588b/packages/core/src/render3/instructions/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/45991/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
packages/core/test/acceptance/di_spec.tshttps://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
View file https://github.com/alxhub/angular/blob/425c75593376dc38b0cc664e35f0392460b6588b/packages/core/test/acceptance/di_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
splincodehttps://github.com/splincode
May 18, 2022https://github.com/angular/angular/pull/45991/files#r875572421
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
JoostKhttps://github.com/JoostK
May 18, 2022https://github.com/angular/angular/pull/45991/files#r875712410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
splincodehttps://github.com/splincode
May 18, 2022https://github.com/angular/angular/pull/45991/files#r875733734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
JoostKhttps://github.com/JoostK
May 18, 2022https://github.com/angular/angular/pull/45991/files#r875858763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
https://github.com/angular/angular/pull/45991/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
packages/core/test/bundling/animations/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
View file https://github.com/alxhub/angular/blob/425c75593376dc38b0cc664e35f0392460b6588b/packages/core/test/bundling/animations/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/45991/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
Please reload this pagehttps://github.com/angular/angular/pull/45991/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.