René's URL Explorer Experiment


Title: refactor(router): Only create the `Route` injector when the path matches by atscott · Pull Request #45990 · angular/angular · GitHub

Open Graph Title: refactor(router): Only create the `Route` injector when the path matches by atscott · Pull Request #45990 · angular/angular

X Title: refactor(router): Only create the `Route` injector when the path matches by atscott · Pull Request #45990 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently, the Router will create the EnvironmentInjector for a Route with providers as soon as it attempts to match segments to the Route. Instead, this change updates the logic to only create the...

X Description: Currently, the Router will create the EnvironmentInjector for a Route with providers as soon as it attempts to match segments to the Route. Instead, this change updates the logic to only create the...

Opengraph URL: https://github.com/angular/angular/pull/45990

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3864782-eabe-30c6-7280-44872a64cfaa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2A2:317608:DFA570:11C7A46:6B010512
html-safe-nonce43fe8206d69637bc29d3dded32a1bd581740dcb771e7f202a8e143ef7d7068d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkEyOjMxNzYwODpERkE1NzA6MTFDN0E0Njo2QjAxMDUxMiIsInZpc2l0b3JfaWQiOiI4Mzk5MjI4NzgxNjA4MzcxNDc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac52d711e38b6b4df64f334ac9f3beeee29bee706eaf9f2b9be73d56bc59691a12
hovercard-subject-tagpull_request:936147744
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/45990/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c8340d8a4ce1136bbcf0f648aebe01db649c2a6bbaea837488e91bf6061767b3/angular/angular/pull/45990
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c8340d8a4ce1136bbcf0f648aebe01db649c2a6bbaea837488e91bf6061767b3/angular/angular/pull/45990
og:image:altCurrently, the Router will create the EnvironmentInjector for a Route with providers as soon as it attempts to match segments to the Route. Instead, this change updates the logic to only create the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/45990#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45990
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45990
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45990
Reloadhttps://github.com/angular/angular/pull/45990
Reloadhttps://github.com/angular/angular/pull/45990
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:onlyCreateRouteInjectorOnMatchhttps://github.com/atscott/angular/tree/onlyCreateRouteInjectorOnMatch
Conversationhttps://github.com/angular/angular/pull/45990
Commits1 (1)https://github.com/angular/angular/pull/45990/commits
Checkshttps://github.com/angular/angular/pull/45990/checks
Files changedhttps://github.com/angular/angular/pull/45990/files
refactor(router): Only create the Route injector when the path matcheshttps://github.com/angular/angular/pull/45990#top
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:onlyCreateRouteInjectorOnMatchhttps://github.com/atscott/angular/tree/onlyCreateRouteInjectorOnMatch
https://github.com/atscott
atscotthttps://github.com/atscott
May 13, 2022https://github.com/angular/angular/pull/45990#issue-1235493615
#45988https://github.com/angular/angular/issues/45988
Please reload this pagehttps://github.com/angular/angular/pull/45990
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
May 13, 2022https://github.com/angular/angular/pull/45990#event-6607321768
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
May 13, 2022https://github.com/angular/angular/pull/45990#event-6607321971
https://github.com/atscott
refactor(router): Only create the Route injector when the path matcheshttps://github.com/angular/angular/pull/45990/commits/3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
3b974e9https://github.com/angular/angular/pull/45990/commits/3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
angular#45988https://github.com/angular/angular/issues/45988
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/5ee17b8c82b4d2a30786cd52a3d308ad1ccff263..3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
5ee17b8https://github.com/angular/angular/commit/5ee17b8c82b4d2a30786cd52a3d308ad1ccff263
3b974e9https://github.com/angular/angular/commit/3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
Compare https://github.com/angular/angular/compare/5ee17b8c82b4d2a30786cd52a3d308ad1ccff263..3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
May 13, 2022 17:39https://github.com/angular/angular/pull/45990#event-6607431128
https://github.com/alxhub
alxhubhttps://github.com/alxhub
May 13, 2022 https://github.com/angular/angular/pull/45990#pullrequestreview-972600729
View reviewed changes https://github.com/angular/angular/pull/45990/files/3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
https://github.com/atscott
atscotthttps://github.com/atscott
May 13, 2022https://github.com/angular/angular/pull/45990#issuecomment-1126303640
presubmithttp://tap/448533151
Please reload this pagehttps://github.com/angular/angular/pull/45990
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
May 13, 2022https://github.com/angular/angular/pull/45990#event-6607860330
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
May 13, 2022https://github.com/angular/angular/pull/45990#issuecomment-1126370228
4d2e006https://github.com/angular/angular/commit/4d2e0063728286866e83cf9cea1510c2a319d005
Please reload this pagehttps://github.com/angular/angular/pull/45990
jessicajaniukhttps://github.com/jessicajaniuk
May 13, 2022 https://github.com/angular/angular/pull/45990#ref-commit-77c9508
https://github.com/atscott
https://github.com/thePunderWoman
refactor(router): Only create the Route injector when the path matc…https://github.com/angular/angular/commit/77c9508e5144e85ee2a2bda8db191a54d72cbe03
77c9508https://github.com/angular/angular/commit/77c9508e5144e85ee2a2bda8db191a54d72cbe03
#45990https://github.com/angular/angular/pull/45990
#45988https://github.com/angular/angular/issues/45988
#45990https://github.com/angular/angular/pull/45990
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
4d2e006https://github.com/angular/angular/commit/4d2e0063728286866e83cf9cea1510c2a319d005
May 13, 2022https://github.com/angular/angular/pull/45990#event-6607946861
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 13, 2022https://github.com/angular/angular/pull/45990#issuecomment-1154107807
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/45990
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 13, 2022https://github.com/angular/angular/pull/45990#event-6797425531
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45990
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/45990/files/3b974e98c95fdcd3ac1e50ddfaae15670506fe7e
Please reload this pagehttps://github.com/angular/angular/pull/45990
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Backlog https://github.com/angular/angular/milestone/82
ENVIRONMENT_INITIALIZER is eagerly loaded https://github.com/angular/angular/issues/45988
Please reload this pagehttps://github.com/angular/angular/pull/45990
https://github.com/atscott
https://github.com/jessicajaniuk
https://github.com/alxhub
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.