René's URL Explorer Experiment


Title: fix(compiler): fix emulated css functional selectors scoping by dario-piotrowicz · Pull Request #45807 · angular/angular · GitHub

Open Graph Title: fix(compiler): fix emulated css functional selectors scoping by dario-piotrowicz · Pull Request #45807 · angular/angular

X Title: fix(compiler): fix emulated css functional selectors scoping by dario-piotrowicz · Pull Request #45807 · angular/angular

Description: currently in emulated view encapsulation if a selector contains a functional pseudo-class selector (such as :is() for example) and contains different spaces and commas inside the parenthesis such characters are handle as if there where part of a normal selector thus causing various parsing issues, solve this issue by escaping/unescaping the content of such selectors Basically if a selector is: :is(.foo, .bar):not(.baz) escape it to :is_PLACEHOLDER_:not__PLACEHOLDER__, handle/scope it as normal and then revert back the placeholders to the original values resolves #45686 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: Issue Issue Number: #45686 Does this PR introduce a breaking change? Yes No

Open Graph Description: currently in emulated view encapsulation if a selector contains a functional pseudo-class selector (such as :is() for example) and contains different spaces and commas inside the parenthesis such c...

X Description: currently in emulated view encapsulation if a selector contains a functional pseudo-class selector (such as :is() for example) and contains different spaces and commas inside the parenthesis such c...

Opengraph URL: https://github.com/angular/angular/pull/45807

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d84c60a9-03d0-0506-07fb-5598b26d5849
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6C2:8196C:A5E5E5:DD6B06:6B00EA5B
html-safe-nonce2189d6c3f8db89c7b77f46f769eef6620f41fe7c8e1f737daeffc6edd6f955dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkMyOjgxOTZDOkE1RTVFNTpERDZCMDY6NkIwMEVBNUIiLCJ2aXNpdG9yX2lkIjoiODkzMzY2NzkwNDYwMDIwNTkxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1629b946753d5752008f8784218b728a6b19f0bc89404868eed35941dcd3fddf
hovercard-subject-tagpull_request:922430471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45807/files
twitter:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
og:image:altcurrently in emulated view encapsulation if a selector contains a functional pseudo-class selector (such as :is() for example) and contains different spaces and commas inside the parenthesis such c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45807/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45807%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45807%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45807/files
Reloadhttps://github.com/angular/angular/pull/45807/files
Reloadhttps://github.com/angular/angular/pull/45807/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dario-piotrowiczhttps://github.com/dario-piotrowicz
angular:mainhttps://github.com/angular/angular/tree/main
dario-piotrowicz:fix-css-functional-pseudo-classeshttps://github.com/dario-piotrowicz/angular/tree/fix-css-functional-pseudo-classes
Conversation 14 https://github.com/angular/angular/pull/45807
Commits 1 https://github.com/angular/angular/pull/45807/commits
Checks 0 https://github.com/angular/angular/pull/45807/checks
Files changed https://github.com/angular/angular/pull/45807/files
Please reload this pagehttps://github.com/angular/angular/pull/45807/files
fix(compiler): fix emulated css functional selectors scoping https://github.com/angular/angular/pull/45807/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/45807/files
0f9c0fc fix(compiler): fix emulated css functional selectors scoping dario-piotrowicz Apr 28, 2022 https://github.com/angular/angular/pull/45807/commits/0f9c0fc0d2bc6dc5a9472ef2bdebf1dd30019ab5
Clear filters https://github.com/angular/angular/pull/45807/files
Please reload this pagehttps://github.com/angular/angular/pull/45807/files
Please reload this pagehttps://github.com/angular/angular/pull/45807/files
shadow_css.ts https://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
shadow_css_spec.ts https://github.com/angular/angular/pull/45807/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
packages/compiler/src/shadow_css.tshttps://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
View file https://github.com/dario-piotrowicz/angular/blob/0f9c0fc0d2bc6dc5a9472ef2bdebf1dd30019ab5/packages/compiler/src/shadow_css.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45807/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
dario-piotrowiczhttps://github.com/dario-piotrowicz
Apr 28, 2022https://github.com/angular/angular/pull/45807/files#r861355052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/45807/files
https://github.com/angular/angular/pull/45807/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
packages/compiler/test/shadow_css/shadow_css_spec.tshttps://github.com/angular/angular/pull/45807/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
View file https://github.com/dario-piotrowicz/angular/blob/0f9c0fc0d2bc6dc5a9472ef2bdebf1dd30019ab5/packages/compiler/test/shadow_css/shadow_css_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45807/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45807/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
https://github.com/angular/angular/pull/45807/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.