René's URL Explorer Experiment


Title: refactor(router): Remove unnecessary setTimeout in UrlTree redirects by atscott · Pull Request #45735 · angular/angular · GitHub

Open Graph Title: refactor(router): Remove unnecessary setTimeout in UrlTree redirects by atscott · Pull Request #45735 · angular/angular

X Title: refactor(router): Remove unnecessary setTimeout in UrlTree redirects by atscott · Pull Request #45735 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Using setTimeout in the Router navigation pipeline creates fragile and unpredictable behavior. Additionally, it creates a new macrotask, which would trigger an unnecessary change detection in the a...

X Description: Using setTimeout in the Router navigation pipeline creates fragile and unpredictable behavior. Additionally, it creates a new macrotask, which would trigger an unnecessary change detection in the a...

Opengraph URL: https://github.com/angular/angular/pull/45735

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:17e25172-528c-2517-8813-a3198eeb0a77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EF0:24FC21:BE241D:F65257:6B00EC28
html-safe-nonceefb3cb1778a77a1e7de8e86347bcbf96c206dda9100801bab8acbc129313d0f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUYwOjI0RkMyMTpCRTI0MUQ6RjY1MjU3OjZCMDBFQzI4IiwidmlzaXRvcl9pZCI6Ijc4OTY0ODk2NTI1ODcxMjk4OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac87585791fab269a5d320fb9a62531a3f696e03a2d6591edf11a8d889073a7466
hovercard-subject-tagpull_request:917217754
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/45735/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cd70483a5fd870fbdf614b09b4ed3eaab595da2d481bece381813417d62af9ce/angular/angular/pull/45735
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cd70483a5fd870fbdf614b09b4ed3eaab595da2d481bece381813417d62af9ce/angular/angular/pull/45735
og:image:altUsing setTimeout in the Router navigation pipeline creates fragile and unpredictable behavior. Additionally, it creates a new macrotask, which would trigger an unnecessary change detection in the a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/45735#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45735
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45735
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45735
Reloadhttps://github.com/angular/angular/pull/45735
Reloadhttps://github.com/angular/angular/pull/45735
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:removeNotNeededRedirectTimeouthttps://github.com/atscott/angular/tree/removeNotNeededRedirectTimeout
Conversationhttps://github.com/angular/angular/pull/45735
Commits1 (1)https://github.com/angular/angular/pull/45735/commits
Checkshttps://github.com/angular/angular/pull/45735/checks
Files changedhttps://github.com/angular/angular/pull/45735/files
refactor(router): Remove unnecessary setTimeout in UrlTree redirectshttps://github.com/angular/angular/pull/45735#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:removeNotNeededRedirectTimeouthttps://github.com/atscott/angular/tree/removeNotNeededRedirectTimeout
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 23, 2022https://github.com/angular/angular/pull/45735#issue-1213331588
Please reload this pagehttps://github.com/angular/angular/pull/45735
15e3978https://github.com/angular/angular/commit/15e397816f98ec16839c30fd5c1ea01c7444fb84
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Apr 23, 2022https://github.com/angular/angular/pull/45735#event-6484277373
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Apr 23, 2022https://github.com/angular/angular/pull/45735#event-6484277495
https://github.com/atscott
refactor(router): Remove unnecessary setTimeout in UrlTree redirectshttps://github.com/angular/angular/pull/45735/commits/b7756cb1eea33e78956825ef90720ab3bd659999
b7756cbhttps://github.com/angular/angular/pull/45735/commits/b7756cb1eea33e78956825ef90720ab3bd659999
angular@15e3978https://github.com/angular/angular/commit/15e397816f98ec16839c30fd5c1ea01c7444fb84
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/0e06921ffbf6096f620342883785e1f57c1fb150..b7756cb1eea33e78956825ef90720ab3bd659999
0e06921https://github.com/angular/angular/commit/0e06921ffbf6096f620342883785e1f57c1fb150
b7756cbhttps://github.com/angular/angular/commit/b7756cb1eea33e78956825ef90720ab3bd659999
Compare https://github.com/angular/angular/compare/0e06921ffbf6096f620342883785e1f57c1fb150..b7756cb1eea33e78956825ef90720ab3bd659999
April 23, 2022 14:47https://github.com/angular/angular/pull/45735#event-6484283328
https://github.com/atscott
atscotthttps://github.com/atscott
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
flag: breaking change https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22flag%3A%20breaking%20change%22
Apr 23, 2022https://github.com/angular/angular/pull/45735#event-6484283518
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 23, 2022https://github.com/angular/angular/pull/45735#issuecomment-1107514950
TGPhttps://fusion2.corp.google.com/presubmit/tap/443798592/OCL:443798592:BASE:443768085:1650692727259:ed504361/targets
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
atscotthttps://github.com/atscott
Backloghttps://github.com/angular/angular/milestone/82
v14-candidateshttps://github.com/angular/angular/milestone/107
Apr 25, 2022https://github.com/angular/angular/pull/45735#event-6492576090
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
April 25, 2022 18:07https://github.com/angular/angular/pull/45735#event-6492577151
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 27, 2022 https://github.com/angular/angular/pull/45735#pullrequestreview-954168897
View reviewed changes https://github.com/angular/angular/pull/45735/files/b7756cb1eea33e78956825ef90720ab3bd659999
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/45735#pullrequestreview-954168897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 27, 2022https://github.com/angular/angular/pull/45735#event-6508208820
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Apr 27, 2022https://github.com/angular/angular/pull/45735#issuecomment-1111170625
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 27, 2022https://github.com/angular/angular/pull/45735#issuecomment-1111173033
7b367d9https://github.com/angular/angular/commit/7b367d9d908e15222645a45e2ba133b9d9da76b7
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
atscotthttps://github.com/atscott
7b367d9https://github.com/angular/angular/commit/7b367d9d908e15222645a45e2ba133b9d9da76b7
Apr 27, 2022https://github.com/angular/angular/pull/45735#event-6508231320
https://github.com/atscott
atscotthttps://github.com/atscott
May 4, 2022 https://github.com/angular/angular/pull/45735#ref-issue-951925032
Rearchitect Router so it's more modular #42953 https://github.com/angular/angular/issues/42953
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 28, 2022https://github.com/angular/angular/pull/45735#issuecomment-1140289745
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 28, 2022https://github.com/angular/angular/pull/45735#event-6697308641
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45735
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/45735/files/b7756cb1eea33e78956825ef90720ab3bd659999
Please reload this pagehttps://github.com/angular/angular/pull/45735
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
v14-candidates https://github.com/angular/angular/milestone/107
Please reload this pagehttps://github.com/angular/angular/pull/45735
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.