| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fb31df32-c94b-a1b5-2bfc-ff19db224d34 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1F2:38E318:B1D308:E00EC8:6B012F0D |
| html-safe-nonce | 2a7d870f62ee0e0b3dca9466830832fe9680dad32e3bf57a65c088ff30ea49ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUYyOjM4RTMxODpCMUQzMDg6RTAwRUM4OjZCMDEyRjBEIiwidmlzaXRvcl9pZCI6IjYwMDE0MTYzNjEwNTc0NDE0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3933df0207c21ccd8a6afca238d8e1a1e4c523bc62ecd7fe0b9867a610f27ac6 |
| hovercard-subject-tag | pull_request:915769095 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/45721/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/11b66c8a6dc1bb7fad021384e01e3ed636576fe2a75abaac1fbaf9db1dbd5eb4/angular/angular/pull/45721 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/11b66c8a6dc1bb7fad021384e01e3ed636576fe2a75abaac1fbaf9db1dbd5eb4/angular/angular/pull/45721 |
| og:image:alt | refactor the RouterLinkActive directive to set its classes and
aria-current value via the host metadata instead of using on the
renderer
PR Checklist
Please check if your PR fulfills the following ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dario-piotrowicz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/45721#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45721 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45721 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/45721 |
| Reload | https://github.com/angular/angular/pull/45721 |
| Reload | https://github.com/angular/angular/pull/45721 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| angular:main | https://github.com/angular/angular/tree/main |
| dario-piotrowicz:refactor-router-link-active-to-use-host-binding | https://github.com/dario-piotrowicz/angular/tree/refactor-router-link-active-to-use-host-binding |
| Conversation | https://github.com/angular/angular/pull/45721 |
| Commits2 (2) | https://github.com/angular/angular/pull/45721/commits |
| Checks | https://github.com/angular/angular/pull/45721/checks |
| Files changed | https://github.com/angular/angular/pull/45721/files |
| refactor(router): refactor RouterLinkActive to use host | https://github.com/angular/angular/pull/45721#top |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| angular:main | https://github.com/angular/angular/tree/main |
| dario-piotrowicz:refactor-router-link-active-to-use-host-binding | https://github.com/dario-piotrowicz/angular/tree/refactor-router-link-active-to-use-host-binding |
|
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Apr 21, 2022 | https://github.com/angular/angular/pull/45721#issue-1211528985 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| @atscott | https://github.com/atscott |
| here | https://github.com/angular/angular/pull/45167#discussion_r812873888 |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| April 21, 2022 20:39 | https://github.com/angular/angular/pull/45721#event-6473925671 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
Apr 21, 2022
| https://github.com/angular/angular/pull/45721#pullrequestreview-949192466 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45721/files |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45721/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Apr 21, 2022 | https://github.com/angular/angular/pull/45721#discussion_r855576583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| atscott | https://github.com/atscott |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#discussion_r862086476 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jelbourn | https://github.com/jelbourn |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| jelbourn | https://github.com/jelbourn |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#discussion_r862104781 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Apr 21, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1105763240 |
| https://user-images.githubusercontent.com/61631103/164552820-5c181001-e2d2-4055-8ad2-36b8469630ac.png |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| atscott | https://github.com/atscott |
| AndrewKushnir | https://github.com/AndrewKushnir |
| April 21, 2022 23:44 | https://github.com/angular/angular/pull/45721#event-6474625453 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Apr 21, 2022 | https://github.com/angular/angular/pull/45721#event-6474626008 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Apr 21, 2022 | https://github.com/angular/angular/pull/45721#event-6474626162 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/69bd9cc452d9677391dcc20eebcb1d8b940f81b4..f9beb2699bcdc741574e16d97247ea357566a5c9 |
| 69bd9cc | https://github.com/angular/angular/commit/69bd9cc452d9677391dcc20eebcb1d8b940f81b4 |
| f9beb26 | https://github.com/angular/angular/commit/f9beb2699bcdc741574e16d97247ea357566a5c9 |
|
Compare
| https://github.com/angular/angular/compare/69bd9cc452d9677391dcc20eebcb1d8b940f81b4..f9beb2699bcdc741574e16d97247ea357566a5c9 |
| April 22, 2022 17:44 | https://github.com/angular/angular/pull/45721#event-6480492499 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| April 29, 2022 12:42 | https://github.com/angular/angular/pull/45721#commits-pushed-7d7274f |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/atscott |
| refactor(router): refactor RouterLinkActive to use host | https://github.com/angular/angular/pull/45721/commits/7d7274f92cbb76d25062f1fd505f1256a6de086e |
| 7d7274f | https://github.com/angular/angular/pull/45721/commits/7d7274f92cbb76d25062f1fd505f1256a6de086e |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/atscott |
| fixup! refactor(router): refactor RouterLinkActive to use host | https://github.com/angular/angular/pull/45721/commits/91d6f8be06e8175b0e4948fd6aa2ac966fa76c6c |
| 91d6f8b | https://github.com/angular/angular/pull/45721/commits/91d6f8be06e8175b0e4948fd6aa2ac966fa76c6c |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/436efdf4f23430ea249b1e1eed4013ec8cf572f9..91d6f8be06e8175b0e4948fd6aa2ac966fa76c6c |
| 436efdf | https://github.com/angular/angular/commit/436efdf4f23430ea249b1e1eed4013ec8cf572f9 |
| 91d6f8b | https://github.com/angular/angular/commit/91d6f8be06e8175b0e4948fd6aa2ac966fa76c6c |
|
Compare
| https://github.com/angular/angular/compare/436efdf4f23430ea249b1e1eed4013ec8cf572f9..91d6f8be06e8175b0e4948fd6aa2ac966fa76c6c |
| April 29, 2022 20:30 | https://github.com/angular/angular/pull/45721#event-6526142141 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1113701864 |
| @dario-piotrowicz | https://github.com/dario-piotrowicz |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#event-6526165760 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| April 29, 2022 20:51 | https://github.com/angular/angular/pull/45721#event-6526252539 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1113721600 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1113731865 |
| @dario-piotrowicz | https://github.com/dario-piotrowicz |
| #29746 | https://github.com/angular/angular/pull/29746 |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Apr 29, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1113739739 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 30, 2022 | https://github.com/angular/angular/pull/45721#issuecomment-1141312426 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 30, 2022 | https://github.com/angular/angular/pull/45721#event-6704145363 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45721 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/jelbourn |
|
jelbourn
| https://github.com/jelbourn |
|
| https://github.com/angular/angular/pull/45721/files/1a0573af055aecf28625a3e8d46e7f3054b95dd0 |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/45721 |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/atscott |
|
| https://github.com/jelbourn |
|
| https://github.com/AndrewKushnir |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |