René's URL Explorer Experiment


Title: fix(zone.js): do not silence uncaught promise rejections when the `finally` is called by arturovt · Pull Request #45449 · angular/angular · GitHub

Open Graph Title: fix(zone.js): do not silence uncaught promise rejections when the `finally` is called by arturovt · Pull Request #45449 · angular/angular

X Title: fix(zone.js): do not silence uncaught promise rejections when the `finally` is called by arturovt · Pull Request #45449 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The native promise implementation logs unhandled promise rejections after onFinally has been called. We may rely on the scheduledByFinally argument, which is false by default, to avoid creating a b...

X Description: The native promise implementation logs unhandled promise rejections after onFinally has been called. We may rely on the scheduledByFinally argument, which is false by default, to avoid creating a b...

Opengraph URL: https://github.com/angular/angular/pull/45449

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5a11af46-2da0-64f8-1076-b4002288ea08
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B5E:363D8E:1BB046D:232FDD7:6B013CDE
html-safe-noncefd5150440e59595f4e7477b7b54fe1ae927b9b72bde3a5b3f2dcdd51cd85e624
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjVFOjM2M0Q4RToxQkIwNDZEOjIzMkZERDc6NkIwMTNDREUiLCJ2aXNpdG9yX2lkIjoiNjU2MzIyNDI5NjU4MjM2NDM4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac97e09a9415d6224d8de5cd7abf540bbaacfe437bf5df305efce5ab3bc09e3ac7
hovercard-subject-tagpull_request:890171890
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/45449/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/61f91d4992361a1ee21508970bc5238dc8603a2334bbd80056782b4f46801786/angular/angular/pull/45449
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/61f91d4992361a1ee21508970bc5238dc8603a2334bbd80056782b4f46801786/angular/angular/pull/45449
og:image:altThe native promise implementation logs unhandled promise rejections after onFinally has been called. We may rely on the scheduledByFinally argument, which is false by default, to avoid creating a b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearturovt
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/45449#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45449
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45449
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45449
Reloadhttps://github.com/angular/angular/pull/45449
Reloadhttps://github.com/angular/angular/pull/45449
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/43206-silence-finallyhttps://github.com/arturovt/angular/tree/fix/43206-silence-finally
Conversationhttps://github.com/angular/angular/pull/45449
Commits1 (1)https://github.com/angular/angular/pull/45449/commits
Checkshttps://github.com/angular/angular/pull/45449/checks
Files changedhttps://github.com/angular/angular/pull/45449/files
fix(zone.js): do not silence uncaught promise rejections when the finally is calledhttps://github.com/angular/angular/pull/45449#top
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/43206-silence-finallyhttps://github.com/arturovt/angular/tree/fix/43206-silence-finally
https://github.com/arturovt
arturovthttps://github.com/arturovt
Mar 26, 2022https://github.com/angular/angular/pull/45449#issue-1181570680
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#43206https://github.com/angular/angular/issues/43206
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JiaLiPassionhttps://github.com/JiaLiPassion
March 26, 2022 07:22https://github.com/angular/angular/pull/45449#event-6311260812
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
Mar 28, 2022https://github.com/angular/angular/pull/45449#event-6320415423
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Mar 28, 2022https://github.com/angular/angular/pull/45449#event-6320415569
https://github.com/arturovt
arturovthttps://github.com/arturovt
Jun 17, 2022https://github.com/angular/angular/pull/45449#issuecomment-1159040105
@JiaLiPassionhttps://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/arturovt
arturovthttps://github.com/arturovt
force-pushedhttps://github.com/angular/angular/compare/53bff0b0a0073f13e8988d7cca6295f7cdc272fc..bfeb553d9b33a54e7f96b0430925b49400786f9d
53bff0bhttps://github.com/angular/angular/commit/53bff0b0a0073f13e8988d7cca6295f7cdc272fc
bfeb553https://github.com/angular/angular/commit/bfeb553d9b33a54e7f96b0430925b49400786f9d
Compare https://github.com/angular/angular/compare/53bff0b0a0073f13e8988d7cca6295f7cdc272fc..bfeb553d9b33a54e7f96b0430925b49400786f9d
June 18, 2022 19:08https://github.com/angular/angular/pull/45449#event-6833802490
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Jun 19, 2022 https://github.com/angular/angular/pull/45449#pullrequestreview-1011534116
View reviewed changes https://github.com/angular/angular/pull/45449/files
packages/zone.js/test/common/Promise.spec.tshttps://github.com/angular/angular/pull/45449/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/arturovt
arturovthttps://github.com/arturovt
force-pushedhttps://github.com/angular/angular/compare/e0baa6c987d7e4a1471006c36b2c2da19a087a4b..411e235028a4d811cc3fa8b68da8e1ae39887d65
e0baa6chttps://github.com/angular/angular/commit/e0baa6c987d7e4a1471006c36b2c2da19a087a4b
411e235https://github.com/angular/angular/commit/411e235028a4d811cc3fa8b68da8e1ae39887d65
Compare https://github.com/angular/angular/compare/e0baa6c987d7e4a1471006c36b2c2da19a087a4b..411e235028a4d811cc3fa8b68da8e1ae39887d65
June 19, 2022 20:21https://github.com/angular/angular/pull/45449#event-6835154029
https://github.com/arturovt
fix(zone.js): do not silence uncaught promise rejections when the `fi…https://github.com/angular/angular/pull/45449/commits/5bd248785c2973153de489d74eaa02f3f4e1e618
5bd2487https://github.com/angular/angular/pull/45449/commits/5bd248785c2973153de489d74eaa02f3f4e1e618
angular#43206https://github.com/angular/angular/issues/43206
https://github.com/arturovt
arturovthttps://github.com/arturovt
force-pushedhttps://github.com/angular/angular/compare/411e235028a4d811cc3fa8b68da8e1ae39887d65..5bd248785c2973153de489d74eaa02f3f4e1e618
411e235https://github.com/angular/angular/commit/411e235028a4d811cc3fa8b68da8e1ae39887d65
5bd2487https://github.com/angular/angular/commit/5bd248785c2973153de489d74eaa02f3f4e1e618
Compare https://github.com/angular/angular/compare/411e235028a4d811cc3fa8b68da8e1ae39887d65..5bd248785c2973153de489d74eaa02f3f4e1e618
June 19, 2022 20:35https://github.com/angular/angular/pull/45449#event-6835165279
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Jun 19, 2022 https://github.com/angular/angular/pull/45449#pullrequestreview-1011579787
View reviewed changes https://github.com/angular/angular/pull/45449/files/5bd248785c2973153de489d74eaa02f3f4e1e618
JiaLiPassionhttps://github.com/JiaLiPassion
https://github.com/angular/angular/pull/45449#pullrequestreview-1011579787
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jun 19, 2022https://github.com/angular/angular/pull/45449#event-6835319677
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022https://github.com/angular/angular/pull/45449#issuecomment-1163564459
cb57cdbhttps://github.com/angular/angular/commit/cb57cdbbd4c09be2333876711f128d1c8c51fba7
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
cb57cdbhttps://github.com/angular/angular/commit/cb57cdbbd4c09be2333876711f128d1c8c51fba7
Jun 22, 2022https://github.com/angular/angular/pull/45449#event-6859711492
https://github.com/arturovt
arturovthttps://github.com/arturovt
June 22, 2022 20:28https://github.com/angular/angular/pull/45449#event-6859742978
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022 https://github.com/angular/angular/pull/45449#ref-commit-b2c1c42
https://github.com/AndrewKushnir
Revert "fix(zone.js): do not silence uncaught promise rejections when…https://github.com/AndrewKushnir/angular/commit/b2c1c42169258e0937f17e3ea2b06193b30d54d9
b2c1c42https://github.com/AndrewKushnir/angular/commit/b2c1c42169258e0937f17e3ea2b06193b30d54d9
angular#45449https://github.com/angular/angular/pull/45449
cb57cdbhttps://github.com/AndrewKushnir/angular/commit/cb57cdbbd4c09be2333876711f128d1c8c51fba7
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022https://github.com/angular/angular/pull/45449#issuecomment-1163728273
#46461https://github.com/angular/angular/pull/46461
@arturovthttps://github.com/arturovt
Please reload this pagehttps://github.com/angular/angular/pull/45449
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2022 https://github.com/angular/angular/pull/45449#ref-commit-2402c47
https://github.com/AndrewKushnir
Revert "fix(zone.js): do not silence uncaught promise rejections when…https://github.com/angular/angular/commit/2402c47b768c889699a5510cfea646b8a5fafb8e
2402c47https://github.com/angular/angular/commit/2402c47b768c889699a5510cfea646b8a5fafb8e
#45449https://github.com/angular/angular/pull/45449
#46461https://github.com/angular/angular/pull/46461
cb57cdbhttps://github.com/angular/angular/commit/cb57cdbbd4c09be2333876711f128d1c8c51fba7
#46461https://github.com/angular/angular/pull/46461
https://github.com/arturovt
arturovthttps://github.com/arturovt
Jun 22, 2022 https://github.com/angular/angular/pull/45449#ref-pullrequest-1281202363
fix(zone.js): do not silence uncaught promise rejections when the finally is called #46462 https://github.com/angular/angular/pull/46462
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2022https://github.com/angular/angular/pull/45449#issuecomment-1193148224
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2022https://github.com/angular/angular/pull/45449#event-7050439374
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45449
https://github.com/JiaLiPassion
JiaLiPassion https://github.com/JiaLiPassion
https://github.com/angular/angular/pull/45449/files/5bd248785c2973153de489d74eaa02f3f4e1e618
Please reload this pagehttps://github.com/angular/angular/pull/45449
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/45449
https://github.com/arturovt
https://github.com/AndrewKushnir
https://github.com/JiaLiPassion
https://github.com/dylhunn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.