René's URL Explorer Experiment


Title: fix(zone.js): do not run stack formatting when the lazy stack frames policy is used by arturovt · Pull Request #45447 · angular/angular · GitHub

Open Graph Title: fix(zone.js): do not run stack formatting when the lazy stack frames policy is used by arturovt · Pull Request #45447 · angular/angular

X Title: fix(zone.js): do not run stack formatting when the lazy stack frames policy is used by arturovt · Pull Request #45447 · angular/angular

Description: We don't have to read the stack property when the lazy stack frames policy is used. The V8 triggers the stack trace serialization only when the stack property is read for the first time within the Accessors::ErrorStackGetter. We want to avoid formatting the stack trace when the lazy policy is used, and we don't need the stack until the zoneAwareStack property is read. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) PR Type Bugfix What is the current behavior? Issue Number: #43240 Does this PR introduce a breaking change? Yes No

Open Graph Description: We don't have to read the stack property when the lazy stack frames policy is used. The V8 triggers the stack trace serialization only when the stack property is read for the first time within ...

X Description: We don't have to read the stack property when the lazy stack frames policy is used. The V8 triggers the stack trace serialization only when the stack property is read for the first time wit...

Opengraph URL: https://github.com/angular/angular/pull/45447

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9677cd1-c425-f724-946d-bbc32815b71e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5F6:33444D:18A8E82:20CB8F0:6B014B30
html-safe-nonce957e149ce1a5e172986507f7c6b34c256684b74f051bdadf9b5a0d8fbd3a53b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUY2OjMzNDQ0RDoxOEE4RTgyOjIwQ0I4RjA6NkIwMTRCMzAiLCJ2aXNpdG9yX2lkIjoiNTk1NDIwODgxMzE2MTcyODgxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50f46e3160fc41d406e6a17fa965964eb341cc5762a1b0fdab2b1cf5b6624f16
hovercard-subject-tagpull_request:889985228
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45447/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altWe don't have to read the stack property when the lazy stack frames policy is used. The V8 triggers the stack trace serialization only when the stack property is read for the first time within ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45447/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45447%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45447%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45447/files
Reloadhttps://github.com/angular/angular/pull/45447/files
Reloadhttps://github.com/angular/angular/pull/45447/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/43240https://github.com/arturovt/angular/tree/fix/43240
Conversation 6 https://github.com/angular/angular/pull/45447
Commits 1 https://github.com/angular/angular/pull/45447/commits
Checks 0 https://github.com/angular/angular/pull/45447/checks
Files changed https://github.com/angular/angular/pull/45447/files
Please reload this pagehttps://github.com/angular/angular/pull/45447/files
fix(zone.js): do not run stack formatting when the lazy stack frames policy is used https://github.com/angular/angular/pull/45447/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/45447/files
b580f7b fix(zone.js): do not run stack formatting when the lazy stack frames … arturovt Mar 25, 2022 https://github.com/angular/angular/pull/45447/commits/b580f7bb6b5061d47d761e2d9d6cd406d3dc9da9
Clear filters https://github.com/angular/angular/pull/45447/files
Please reload this pagehttps://github.com/angular/angular/pull/45447/files
Please reload this pagehttps://github.com/angular/angular/pull/45447/files
error-rewrite.ts https://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
Error.spec.ts https://github.com/angular/angular/pull/45447/files#diff-724ccfbedb3436e48c278042c1a177621e5b4bddb2b37eacd074bb3f396df55b
packages/zone.js/lib/common/error-rewrite.tshttps://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
View file https://github.com/arturovt/angular/blob/b580f7bb6b5061d47d761e2d9d6cd406d3dc9da9/packages/zone.js/lib/common/error-rewrite.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45447/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
https://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
https://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
https://github.com/angular/angular/pull/45447/files#diff-9551c6faaae817e2273a230d8bc1e03ce528003ba9fccca246c41970b50fdd32
packages/zone.js/test/common/Error.spec.tshttps://github.com/angular/angular/pull/45447/files#diff-724ccfbedb3436e48c278042c1a177621e5b4bddb2b37eacd074bb3f396df55b
View file https://github.com/arturovt/angular/blob/b580f7bb6b5061d47d761e2d9d6cd406d3dc9da9/packages/zone.js/test/common/Error.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45447/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45447/files#diff-724ccfbedb3436e48c278042c1a177621e5b4bddb2b37eacd074bb3f396df55b
https://github.com/angular/angular/pull/45447/files#diff-724ccfbedb3436e48c278042c1a177621e5b4bddb2b37eacd074bb3f396df55b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.