René's URL Explorer Experiment


Title: refactor(router): Make a few adjustments to createUrlTree for clarity by atscott · Pull Request #45306 · angular/angular · GitHub

Open Graph Title: refactor(router): Make a few adjustments to createUrlTree for clarity by atscott · Pull Request #45306 · angular/angular

X Title: refactor(router): Make a few adjustments to createUrlTree for clarity by atscott · Pull Request #45306 · angular/angular

Description: tree function now accepts the old root rather than the old UrlTree. The urlTree argument was only used to get the root. This change makes it more clear what that pararmeter is used for and what's actually being used Move the oldRoot (previously urlTree) to be the first argument of tree. This change now mirrors the argument order for replaceSegment and can be read from left to right more easily "in this root, replace this old segment group with this new segment group". Extract newRoot to a variable. This just makes it more clear what's going on at the end rather than combining a bunch of operations into one. These changes are being made so that hopefully a future refactor can be done which does not rely on the urlTree argument at all in the createUrlTree function. These refactorings will make it easier to see 1:1 functionlity in these various places.

Open Graph Description: tree function now accepts the old root rather than the old UrlTree. The urlTree argument was only used to get the root. This change makes it more clear what that pararmeter is used for and what'...

X Description: tree function now accepts the old root rather than the old UrlTree. The urlTree argument was only used to get the root. This change makes it more clear what that pararmeter is used for and what&...

Opengraph URL: https://github.com/angular/angular/pull/45306

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:184c5f44-b65d-5e25-0e81-c65aff041d3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC39E:361639:F2AA77:14428DB:6B010EC2
html-safe-nonce3420fa82e1f81168d37a16c1f9f0fe3b8568dab854cdfa266fb81b39a79764c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzlFOjM2MTYzOTpGMkFBNzc6MTQ0MjhEQjo2QjAxMEVDMiIsInZpc2l0b3JfaWQiOiI3OTI1ODg5Nzc3NDcwMDgyNzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac33d69c2df9a12f753271c5a44867628670cd17aa0204997291b1d2b199b60348
hovercard-subject-tagpull_request:875676904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45306/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:alttree function now accepts the old root rather than the old UrlTree. The urlTree argument was only used to get the root. This change makes it more clear what that pararmeter is used for and what'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45306/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45306%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45306%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45306/files
Reloadhttps://github.com/angular/angular/pull/45306/files
Reloadhttps://github.com/angular/angular/pull/45306/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:smallCreateUrlTreeRefactorhttps://github.com/atscott/angular/tree/smallCreateUrlTreeRefactor
Conversation 3 https://github.com/angular/angular/pull/45306
Commits 1 https://github.com/angular/angular/pull/45306/commits
Checks 0 https://github.com/angular/angular/pull/45306/checks
Files changed https://github.com/angular/angular/pull/45306/files
Please reload this pagehttps://github.com/angular/angular/pull/45306/files
refactor(router): Make a few adjustments to createUrlTree for clarity https://github.com/angular/angular/pull/45306/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/45306/files
a02a074 refactor(router): Make a few adjustments to createUrlTree for clarity atscott Mar 9, 2022 https://github.com/angular/angular/pull/45306/commits/a02a074da2c9e1e41d1ab96383c6cbfda8de9d1b
Clear filters https://github.com/angular/angular/pull/45306/files
Please reload this pagehttps://github.com/angular/angular/pull/45306/files
Please reload this pagehttps://github.com/angular/angular/pull/45306/files
packages/router/src/create_url_tree.tshttps://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
View file https://github.com/atscott/angular/blob/a02a074da2c9e1e41d1ab96383c6cbfda8de9d1b/packages/router/src/create_url_tree.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45306/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/45306/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.