René's URL Explorer Experiment


Title: fix(zone.js): always run microtasks in `Promise.then` to avoid drain microtasks too early. by JiaLiPassion · Pull Request #45273 · angular/angular · GitHub

Open Graph Title: fix(zone.js): always run microtasks in `Promise.then` to avoid drain microtasks too early. by JiaLiPassion · Pull Request #45273 · angular/angular

X Title: fix(zone.js): always run microtasks in `Promise.then` to avoid drain microtasks too early. by JiaLiPassion · Pull Request #45273 · angular/angular

Description: always drainMicrotaskQueue in Promise.then. Consider the following case. const listener = () => { Promise.resolve().then(() => console.log(`promise then`)); }; document.body.addEventListener('click', listener); document.body.click(); console.log('main stack'); Without zone.js patch, the output should be main stack promise then since Promise.resolve().then() should run as microtask after main stack finish. But with zone.js patch, it becomes promise then main stack The reason is currently zone.js maintain a microtask queue themselves, and after a task is invoked (in this case, the click eventTask), it will try to drainMicrotaskQueue synchronizely if the task is the top task. This PR make sure that the dranMicroTaskQueue happen inside a Browser native microTask. This new behavior is the correct behavior but it is very risky since it changes the microTask consuming timing and may impact a lot of existing apps. Close #44446, #41506

Open Graph Description: always drainMicrotaskQueue in Promise.then. Consider the following case. const listener = () => { Promise.resolve().then(() => console.log(`promise then`)); }; document.body.addEventListen...

X Description: always drainMicrotaskQueue in Promise.then. Consider the following case. const listener = () => { Promise.resolve().then(() => console.log(`promise then`)); }; document.body.addEve...

Opengraph URL: https://github.com/angular/angular/pull/45273

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:714a9dbe-4a13-07ca-2af5-74b7fb3bcf45
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC0E:14700E:1B83574:22DDDAC:6B015156
html-safe-nonceb54a1d31fc620cd9aaf62f1dc7ad76271354554750482067d223ae050b1305eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzBFOjE0NzAwRToxQjgzNTc0OjIyREREQUM6NkIwMTUxNTYiLCJ2aXNpdG9yX2lkIjoiNzEzMzU5NjI0MTI1Mzk3ODQ1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb2d10ef7d47aaec8702b16e75d0930a8ff9fffdc78cb0a20acaab89de0a46eee
hovercard-subject-tagpull_request:872126094
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45273/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altalways drainMicrotaskQueue in Promise.then. Consider the following case. const listener = () => { Promise.resolve().then(() => console.log(`promise then`)); }; document.body.addEventListen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45273/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45273%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45273%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45273/files
Reloadhttps://github.com/angular/angular/pull/45273/files
Reloadhttps://github.com/angular/angular/pull/45273/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:mainhttps://github.com/angular/angular/tree/main
JiaLiPassion:drain-microtaskhttps://github.com/JiaLiPassion/angular/tree/drain-microtask
Conversation 4 https://github.com/angular/angular/pull/45273
Commits 3 https://github.com/angular/angular/pull/45273/commits
Checks 0 https://github.com/angular/angular/pull/45273/checks
Files changed https://github.com/angular/angular/pull/45273/files
Please reload this pagehttps://github.com/angular/angular/pull/45273/files
fix(zone.js): always run microtasks in Promise.then to avoid drain microtasks too early. https://github.com/angular/angular/pull/45273/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/45273/files
a37c469 fix(zone.js): always run microtasks in Promise.then to avoid drain mi… JiaLiPassion Mar 5, 2022 https://github.com/angular/angular/pull/45273/commits/a37c469b702e2f7d4b3729b24bb67d545c312996
5bf8a2c fix(zone.js): don't schedule microtask for each jasmine test JiaLiPassion Mar 5, 2022 https://github.com/angular/angular/pull/45273/commits/5bf8a2c0f1407dc5a0bdc86ba24eb700dcb0c381
763d554 fix(zone.js): mocha should not schedule microtask for each test JiaLiPassion Mar 5, 2022 https://github.com/angular/angular/pull/45273/commits/763d5541b483d56221fdea7f67067b7793864f36
Clear filters https://github.com/angular/angular/pull/45273/files
Please reload this pagehttps://github.com/angular/angular/pull/45273/files
Please reload this pagehttps://github.com/angular/angular/pull/45273/files
jasmine.ts https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
mocha.ts https://github.com/angular/angular/pull/45273/files#diff-1fed7b5788477b7aae4e38f986c983561d756b7163cf9320975252df2ece850d
zone-impl.ts https://github.com/angular/angular/pull/45273/files#diff-8512a8929d93e9a2d780d948238f3321e93268dc97f67ddfae368c21f2722825
zone.ts https://github.com/angular/angular/pull/45273/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
element.spec.ts https://github.com/angular/angular/pull/45273/files#diff-e6cbb1c309cbcaca0b9c2a65546d4386e76c22cce81562131b331a1afd9e716c
zone.spec.ts https://github.com/angular/angular/pull/45273/files#diff-36d5935bfbc3a97ae7c085407062841f0b48ab3f80d21b918b3ee031d90a6bd8
jasmine-patch.spec.ts https://github.com/angular/angular/pull/45273/files#diff-7997006709b4cc487d982f9a8424e638f423f2e9d9457ef64f645d21db65998c
packages/zone.js/lib/jasmine/jasmine.tshttps://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
View file https://github.com/JiaLiPassion/angular/blob/763d5541b483d56221fdea7f67067b7793864f36/packages/zone.js/lib/jasmine/jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45273/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/45273/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
Please reload this pagehttps://github.com/angular/angular/pull/45273/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.