| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:f7b0499d-534c-89fe-aec1-16f9b89d4c6b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A20:D5AA4:1646B5E:1DAC419:6B0130D9 |
| html-safe-nonce | 19ab6e8d056572a162b81e75bdabe20a36217d17d0df71248bae6e33c8d76119 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTIwOkQ1QUE0OjE2NDZCNUU6MURBQzQxOTo2QjAxMzBEOSIsInZpc2l0b3JfaWQiOiI4NDY0OTE4OTcwNjY1ODczNjI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fb2d8bc04fba455308de79f3ed36c00aa97157b8dadfa337f9232769b3901ac0 |
| hovercard-subject-tag | pull_request:860893950 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/45167 |
| twitter:image | https://opengraph.githubassets.com/84c212a4e763d8fd04583da6b8ae6f829763f73936fbafcf4bbf14168d2ae37c/angular/angular/pull/45167 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/84c212a4e763d8fd04583da6b8ae6f829763f73936fbafcf4bbf14168d2ae37c/angular/angular/pull/45167 |
| og:image:alt | add the ariaCurrentWhenActive input to the RouterLinkActive directive so that
users can easily set the aria-current property to their active router
links
resolves #35051
PR Checklist
Please check i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dario-piotrowicz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/45167#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45167 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45167 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/45167 |
| Reload | https://github.com/angular/angular/pull/45167 |
| Reload | https://github.com/angular/angular/pull/45167 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| angular:master | https://github.com/angular/angular/tree/master |
| dario-piotrowicz:routerLink-active-aria-current | https://github.com/dario-piotrowicz/angular/tree/routerLink-active-aria-current |
| Conversation | https://github.com/angular/angular/pull/45167 |
| Commits1 (1) | https://github.com/angular/angular/pull/45167/commits |
| Checks | https://github.com/angular/angular/pull/45167/checks |
| Files changed | https://github.com/angular/angular/pull/45167/files |
| feat(router): add ariaCurrentWhenActive input to RouterLinkActive directive | https://github.com/angular/angular/pull/45167#top |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| angular:master | https://github.com/angular/angular/tree/master |
| dario-piotrowicz:routerLink-active-aria-current | https://github.com/dario-piotrowicz/angular/tree/routerLink-active-aria-current |
|
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Feb 22, 2022 | https://github.com/angular/angular/pull/45167#issue-1147450279 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| #35051 | https://github.com/angular/angular/issues/35051 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #35051 | https://github.com/angular/angular/issues/35051 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Feb 22, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1048289726 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
Feb 22, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-890466891 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Feb 22, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-890488439 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/0eac59f6b940aa0b9b7c500ce7cf2c30bdbfe9a2..3d805c74b82e116a49a2ad7287ce8888ada8989e |
| 0eac59f | https://github.com/angular/angular/commit/0eac59f6b940aa0b9b7c500ce7cf2c30bdbfe9a2 |
| 3d805c7 | https://github.com/angular/angular/commit/3d805c74b82e116a49a2ad7287ce8888ada8989e |
|
Compare
| https://github.com/angular/angular/compare/0eac59f6b940aa0b9b7c500ce7cf2c30bdbfe9a2..3d805c74b82e116a49a2ad7287ce8888ada8989e |
| February 23, 2022 20:59 | https://github.com/angular/angular/pull/45167#event-6127945565 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Feb 23, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1049219762 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://angular.io/guide/router-reference#active-router-links | https://angular.io/guide/router-reference#active-router-links |
| https://angular.io/guide/router-tutorial#identify-the-active-route | https://angular.io/guide/router-tutorial#identify-the-active-route |
| https://angular.io/guide/cheatsheet | https://angular.io/guide/cheatsheet |
| https://angular.io/guide/router-tutorial-toh | https://angular.io/guide/router-tutorial-toh |
| best practices accessibility guide | https://angular.io/guide/accessibility |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Feb 23, 2022 | https://github.com/angular/angular/pull/45167#event-6128027686 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/48405ebe30c1fd127988f64e35400529898f9a25..5f87e2fcb69652bc93af9af8df3139ac8dc1287c |
| 48405eb | https://github.com/angular/angular/commit/48405ebe30c1fd127988f64e35400529898f9a25 |
| 5f87e2f | https://github.com/angular/angular/commit/5f87e2fcb69652bc93af9af8df3139ac8dc1287c |
|
Compare
| https://github.com/angular/angular/compare/48405ebe30c1fd127988f64e35400529898f9a25..5f87e2fcb69652bc93af9af8df3139ac8dc1287c |
| February 23, 2022 22:46 | https://github.com/angular/angular/pull/45167#event-6128452747 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
| Feb 24, 2022 | https://github.com/angular/angular/pull/45167#event-6128854720 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Feb 24, 2022 | https://github.com/angular/angular/pull/45167#event-6128854800 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/d8bfaa092575581686d3639780d3af877144f07e..0eea38901f34452ccfb134e94456622584f03846 |
| d8bfaa0 | https://github.com/angular/angular/commit/d8bfaa092575581686d3639780d3af877144f07e |
| 0eea389 | https://github.com/angular/angular/commit/0eea38901f34452ccfb134e94456622584f03846 |
|
Compare
| https://github.com/angular/angular/compare/d8bfaa092575581686d3639780d3af877144f07e..0eea38901f34452ccfb134e94456622584f03846 |
| February 25, 2022 20:40 | https://github.com/angular/angular/pull/45167#event-6141836601 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| February 25, 2022 20:42 | https://github.com/angular/angular/pull/45167#event-6141845847 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| alxhub | https://github.com/alxhub |
| February 25, 2022 20:42 | https://github.com/angular/angular/pull/45167#event-6141846438 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/0eea38901f34452ccfb134e94456622584f03846..21d0c8846afda8d94153683eaa11907b5e94612a |
| 0eea389 | https://github.com/angular/angular/commit/0eea38901f34452ccfb134e94456622584f03846 |
| 21d0c88 | https://github.com/angular/angular/commit/21d0c8846afda8d94153683eaa11907b5e94612a |
|
Compare
| https://github.com/angular/angular/compare/0eea38901f34452ccfb134e94456622584f03846..21d0c8846afda8d94153683eaa11907b5e94612a |
| February 26, 2022 11:33 | https://github.com/angular/angular/pull/45167#event-6145046365 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| atscott | https://github.com/atscott |
| February 27, 2022 19:10 | https://github.com/angular/angular/pull/45167#event-6150781500 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Feb 28, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-895397236 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/45167#pullrequestreview-895397236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| aio/content/examples/animations/src/app/app.component.html | https://github.com/angular/angular/pull/45167/files#diff-654e43a3e03ec8c8536abaae23aace6c47c9e532023ea7c92631bbc33278906a |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| aio/content/guide/accessibility.md | https://github.com/angular/angular/pull/45167/files#diff-1cf7730766a9c1507b1c9b985ab8787ce8724e81f0b8500aee86bca020c40c99 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| aio/content/guide/router-tutorial.md | https://github.com/angular/angular/pull/45167/files#diff-72dd68c97368dce56b2367a53814a0e06bd6ea89b0345ff3b8134931de41d533 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
| Feb 28, 2022 | https://github.com/angular/angular/pull/45167#event-6156444527 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/bbe738061c860318a160d8d4858a89e3b0bacdd5..fff230da4311a77855fdab1b3fef8b47402868d5 |
| bbe7380 | https://github.com/angular/angular/commit/bbe738061c860318a160d8d4858a89e3b0bacdd5 |
| fff230d | https://github.com/angular/angular/commit/fff230da4311a77855fdab1b3fef8b47402868d5 |
|
Compare
| https://github.com/angular/angular/compare/bbe738061c860318a160d8d4858a89e3b0bacdd5..fff230da4311a77855fdab1b3fef8b47402868d5 |
| February 28, 2022 18:34 | https://github.com/angular/angular/pull/45167#event-6156736551 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Feb 28, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1054548268 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
Feb 28, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-895464520 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| jessicajaniuk | https://github.com/jessicajaniuk |
| https://github.com/angular/angular/pull/45167#pullrequestreview-895464520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
| alxhub | https://github.com/alxhub |
| February 28, 2022 18:44 | https://github.com/angular/angular/pull/45167#event-6156795347 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| atscott | https://github.com/atscott |
| dylhunn | https://github.com/dylhunn |
| jelbourn | https://github.com/jelbourn |
| March 2, 2022 00:28 | https://github.com/angular/angular/pull/45167#event-6165877493 |
| https://github.com/dylhunn |
| dylhunn | https://github.com/dylhunn |
|
Mar 2, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-896972608 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| dylhunn | https://github.com/dylhunn |
| https://github.com/angular/angular/pull/45167#pullrequestreview-896972608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Mar 2, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-896972638 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/45167#pullrequestreview-896972638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| March 2, 2022 01:31 | https://github.com/angular/angular/pull/45167#event-6166158144 |
| https://github.com/jelbourn |
| jelbourn | https://github.com/jelbourn |
|
Mar 2, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-898051985 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: discuss
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20discuss%22 |
| Mar 3, 2022 | https://github.com/angular/angular/pull/45167#event-6180395228 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| force-pushed | https://github.com/angular/angular/compare/ec4367880781fa014531d18d3997e88e383d8d1d..f5523000b2ea43293b576f477637af34b0d499a9 |
| ec43678 | https://github.com/angular/angular/commit/ec4367880781fa014531d18d3997e88e383d8d1d |
| f552300 | https://github.com/angular/angular/commit/f5523000b2ea43293b576f477637af34b0d499a9 |
|
Compare
| https://github.com/angular/angular/compare/ec4367880781fa014531d18d3997e88e383d8d1d..f5523000b2ea43293b576f477637af34b0d499a9 |
| April 9, 2022 13:11 | https://github.com/angular/angular/pull/45167#event-6401428208 |
| https://github.com/jelbourn |
| jelbourn | https://github.com/jelbourn |
|
Apr 15, 2022
| https://github.com/angular/angular/pull/45167#pullrequestreview-943591400 |
|
View reviewed changes
| https://github.com/angular/angular/pull/45167/files |
| aio/content/guide/accessibility.md | https://github.com/angular/angular/pull/45167/files#diff-1cf7730766a9c1507b1c9b985ab8787ce8724e81f0b8500aee86bca020c40c99 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| packages/router/src/directives/router_link_active.ts | https://github.com/angular/angular/pull/45167/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/dylhunn |
| dylhunn | https://github.com/dylhunn |
| Apr 15, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1100319265 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/f5523000b2ea43293b576f477637af34b0d499a9..7e9017e47d679d6c5c886a8854329d9c23672f90 |
| f552300 | https://github.com/angular/angular/commit/f5523000b2ea43293b576f477637af34b0d499a9 |
| 7e9017e | https://github.com/angular/angular/commit/7e9017e47d679d6c5c886a8854329d9c23672f90 |
|
Compare
| https://github.com/angular/angular/compare/f5523000b2ea43293b576f477637af34b0d499a9..7e9017e47d679d6c5c886a8854329d9c23672f90 |
| April 15, 2022 20:01 | https://github.com/angular/angular/pull/45167#event-6442079281 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: discuss
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20discuss%22 |
| Apr 15, 2022 | https://github.com/angular/angular/pull/45167#event-6442087186 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Apr 15, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1100357824 |
| presubmit | http://tap/431807695 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Apr 15, 2022 | https://github.com/angular/angular/pull/45167#event-6442091291 |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/atscott |
| feat(router): add ariaCurrentWhenActive input to RouterLinkActive dir… | https://github.com/angular/angular/pull/45167/commits/d8ab42d6894c5fd77df16b176ff19c83ad44734c |
| d8ab42d | https://github.com/angular/angular/pull/45167/commits/d8ab42d6894c5fd77df16b176ff19c83ad44734c |
| angular#35051 | https://github.com/angular/angular/issues/35051 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Apr 20, 2022 | https://github.com/angular/angular/pull/45167#event-6466134014 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/7e9017e47d679d6c5c886a8854329d9c23672f90..d8ab42d6894c5fd77df16b176ff19c83ad44734c |
| 7e9017e | https://github.com/angular/angular/commit/7e9017e47d679d6c5c886a8854329d9c23672f90 |
| d8ab42d | https://github.com/angular/angular/commit/d8ab42d6894c5fd77df16b176ff19c83ad44734c |
|
Compare
| https://github.com/angular/angular/compare/7e9017e47d679d6c5c886a8854329d9c23672f90..d8ab42d6894c5fd77df16b176ff19c83ad44734c |
| April 20, 2022 20:41 | https://github.com/angular/angular/pull/45167#event-6466134074 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Apr 20, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1104511291 |
| dea8c86 | https://github.com/angular/angular/commit/dea8c86cd57f8e1720634928805f9ea0ba8f0baa |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| dea8c86 | https://github.com/angular/angular/commit/dea8c86cd57f8e1720634928805f9ea0ba8f0baa |
| Apr 20, 2022 | https://github.com/angular/angular/pull/45167#event-6466608573 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| April 20, 2022 22:20 | https://github.com/angular/angular/pull/45167#event-6466643655 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
Apr 21, 2022
| https://github.com/angular/angular/pull/45167#ref-pullrequest-1211528985 |
|
refactor(router): refactor RouterLinkActive to use host
#45721
| https://github.com/angular/angular/pull/45721 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 21, 2022 | https://github.com/angular/angular/pull/45167#issuecomment-1133661616 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 21, 2022 | https://github.com/angular/angular/pull/45167#event-6655103671 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45167 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/45167/files/5416601cdddd2c0622efed5d3756ef15a7870e7f |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/45167/files/5416601cdddd2c0622efed5d3756ef15a7870e7f |
|
| https://github.com/jelbourn |
|
jelbourn
| https://github.com/jelbourn |
|
| https://github.com/angular/angular/pull/45167/files/f5523000b2ea43293b576f477637af34b0d499a9 |
|
| https://github.com/dylhunn |
|
dylhunn
| https://github.com/dylhunn |
|
| https://github.com/angular/angular/pull/45167/files/5416601cdddd2c0622efed5d3756ef15a7870e7f |
|
| https://github.com/jessicajaniuk |
|
jessicajaniuk
| https://github.com/jessicajaniuk |
|
| https://github.com/angular/angular/pull/45167/files/fff230da4311a77855fdab1b3fef8b47402868d5 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
|
[a11y] - Document best practice for use of aria-current with RouterLink / RouterLinkActive
| https://github.com/angular/angular/issues/35051 |
| Please reload this page | https://github.com/angular/angular/pull/45167 |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/dylhunn |
|
| https://github.com/atscott |
|
| https://github.com/jelbourn |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/jessicajaniuk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |