René's URL Explorer Experiment


Title: fix(zone.js): correct defineProperties for symbol props. by varomodt · Pull Request #45060 · angular/angular · GitHub

Open Graph Title: fix(zone.js): correct defineProperties for symbol props. by varomodt · Pull Request #45060 · angular/angular

X Title: fix(zone.js): correct defineProperties for symbol props. by varomodt · Pull Request #45060 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently, this defineProperties patch does not work for symbol properties which will not be enumerated by Object.keys. This CL adds a second case for symbols, with a small feature guard for IE. PR...

X Description: Currently, this defineProperties patch does not work for symbol properties which will not be enumerated by Object.keys. This CL adds a second case for symbols, with a small feature guard for IE. PR...

Opengraph URL: https://github.com/angular/angular/pull/45060

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:03a8e5dc-efb6-d9b0-e6d2-5ce9d52abba3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB264:F7C4C:C9DD0D:10FA60D:6B00FF69
html-safe-noncec1cf8625796e38ddaafa1065414755ce8c68f7aecce40d3e1b920b5c13318140
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjY0OkY3QzRDOkM5REQwRDoxMEZBNjBEOjZCMDBGRjY5IiwidmlzaXRvcl9pZCI6IjUxNDczOTAyMDg2NTE2MjQyOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac269643bf7b51a43df32a239e72b17c6f75ad3ad1cdde4aca79a53325ff80feb3
hovercard-subject-tagpull_request:848386559
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/45060/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/46f8fd041c276f3a39f46df1a156694e103e1c10235da55748fe92f446224c72/angular/angular/pull/45060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46f8fd041c276f3a39f46df1a156694e103e1c10235da55748fe92f446224c72/angular/angular/pull/45060
og:image:altCurrently, this defineProperties patch does not work for symbol properties which will not be enumerated by Object.keys. This CL adds a second case for symbols, with a small feature guard for IE. PR...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevaromodt
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/45060#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45060
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45060
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45060
Reloadhttps://github.com/angular/angular/pull/45060
Reloadhttps://github.com/angular/angular/pull/45060
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
varomodthttps://github.com/varomodt
angular:masterhttps://github.com/angular/angular/tree/master
varomodt:patch-1https://github.com/varomodt/angular/tree/patch-1
Conversationhttps://github.com/angular/angular/pull/45060
Commits14 (14)https://github.com/angular/angular/pull/45060/commits
Checkshttps://github.com/angular/angular/pull/45060/checks
Files changedhttps://github.com/angular/angular/pull/45060/files
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060#top
varomodthttps://github.com/varomodt
angular:masterhttps://github.com/angular/angular/tree/master
varomodt:patch-1https://github.com/varomodt/angular/tree/patch-1
https://github.com/varomodt
varomodthttps://github.com/varomodt
Feb 12, 2022https://github.com/angular/angular/pull/45060#issue-1133424649
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/varomodt
Fix defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/99e93bdb50c5422f105d23620605f191dddaa94a
99e93bdhttps://github.com/angular/angular/pull/45060/commits/99e93bdb50c5422f105d23620605f191dddaa94a
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JiaLiPassionhttps://github.com/JiaLiPassion
February 12, 2022 00:59https://github.com/angular/angular/pull/45060#event-6055235527
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
hotlist: google https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20google%22
Feb 12, 2022https://github.com/angular/angular/pull/45060#event-6055246743
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Feb 12, 2022https://github.com/angular/angular/pull/45060#event-6055246871
varomodthttps://github.com/varomodt
February 11, 2022 17:53https://github.com/angular/angular/pull/45060#commits-pushed-eb89be8
https://github.com/varomodt
Update define-property.tshttps://github.com/angular/angular/pull/45060/commits/eb89be899b6c5f17f218400bce2244e869fda44c
eb89be8https://github.com/angular/angular/pull/45060/commits/eb89be899b6c5f17f218400bce2244e869fda44c
https://github.com/varomodt
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/0701dc3fcdbfd5c941c5d523b9c5bc8d28663395
0701dc3https://github.com/angular/angular/pull/45060/commits/0701dc3fcdbfd5c941c5d523b9c5bc8d28663395
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
https://github.com/varomodt
Update define-property.tshttps://github.com/angular/angular/pull/45060/commits/c09d4d1f880d2a0dfa0e721c996c3e2f131b40cd
c09d4d1https://github.com/angular/angular/pull/45060/commits/c09d4d1f880d2a0dfa0e721c996c3e2f131b40cd
https://github.com/varomodt
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/791942fef25085c4401006a715321554faf3cbb0
791942fhttps://github.com/angular/angular/pull/45060/commits/791942fef25085c4401006a715321554faf3cbb0
https://github.com/varomodt
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/1788f3390e637bed92a1f092b2e9654233c5f21f
1788f33https://github.com/angular/angular/pull/45060/commits/1788f3390e637bed92a1f092b2e9654233c5f21f
https://github.com/JiaLiPassion
fix(zone.js): update type definition of definePropertieshttps://github.com/angular/angular/pull/45060/commits/9af215186bf742ee123c50dcbddac84483c5d97d
9af2151https://github.com/angular/angular/pull/45060/commits/9af215186bf742ee123c50dcbddac84483c5d97d
https://github.com/JiaLiPassion
test(zone.js): add test cases of Object.defineProperties()https://github.com/angular/angular/pull/45060/commits/c490725bc585b816ec65fee1d43a06115340d19b
c490725https://github.com/angular/angular/pull/45060/commits/c490725bc585b816ec65fee1d43a06115340d19b
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 12, 2022https://github.com/angular/angular/pull/45060#issuecomment-1037061071
@varomodthttps://github.com/varomodt
#44095https://github.com/angular/angular/issues/44095
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 12, 2022 https://github.com/angular/angular/pull/45060#pullrequestreview-880835467
View reviewed changes https://github.com/angular/angular/pull/45060/files/c490725bc585b816ec65fee1d43a06115340d19b
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 12, 2022https://github.com/angular/angular/pull/45060#event-6056105715
varomodthttps://github.com/varomodt
February 14, 2022 12:23https://github.com/angular/angular/pull/45060#commits-pushed-b299f94
https://github.com/varomodt
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/b299f94c39545ff93a484707d605b854a523ed7c
b299f94https://github.com/angular/angular/pull/45060/commits/b299f94c39545ff93a484707d605b854a523ed7c
https://github.com/JiaLiPassion
https://github.com/varomodt
fix(zone.js): update type definition of definePropertieshttps://github.com/angular/angular/pull/45060/commits/359352344451d84a2fb574f6f684493aed26276f
3593523https://github.com/angular/angular/pull/45060/commits/359352344451d84a2fb574f6f684493aed26276f
https://github.com/JiaLiPassion
https://github.com/varomodt
test(zone.js): add test cases of Object.defineProperties()https://github.com/angular/angular/pull/45060/commits/7728ef33db6b69bf2b477d6749eb6539e4e821fb
7728ef3https://github.com/angular/angular/pull/45060/commits/7728ef33db6b69bf2b477d6749eb6539e4e821fb
https://github.com/varomodt
fix(zone.js): merge fix of defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/543fea2d1da1731012652591f24432a7958771bd
543fea2https://github.com/angular/angular/pull/45060/commits/543fea2d1da1731012652591f24432a7958771bd
https://github.com/varomodt
fix(zone.js): merge defineProperty fixeshttps://github.com/angular/angular/pull/45060/commits/981aff1200a56d77b39710902e7df2c7687b164f
981aff1https://github.com/angular/angular/pull/45060/commits/981aff1200a56d77b39710902e7df2c7687b164f
https://github.com/varomodt
fix(zone.js): correct defineProperties for symbol props.https://github.com/angular/angular/pull/45060/commits/14fe2378935763c1ee0c9a41507fa90648a1b842
14fe237https://github.com/angular/angular/pull/45060/commits/14fe2378935763c1ee0c9a41507fa90648a1b842
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 14, 2022 https://github.com/angular/angular/pull/45060#pullrequestreview-882262833
View reviewed changes https://github.com/angular/angular/pull/45060/files/14fe2378935763c1ee0c9a41507fa90648a1b842
JiaLiPassionhttps://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/angular/angular/pull/45060#pullrequestreview-882262833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@varomodthttps://github.com/varomodt
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 16, 2022https://github.com/angular/angular/pull/45060#issuecomment-1040941927
@varomodthttps://github.com/varomodt
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 16, 2022 https://github.com/angular/angular/pull/45060#ref-pullrequest-1139419304
fix(zone.js): defineProperties should also set symbol props #45098 https://github.com/angular/angular/pull/45098
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 16, 2022https://github.com/angular/angular/pull/45060#event-6085605775
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 19, 2022https://github.com/angular/angular/pull/45060#issuecomment-1073035865
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 19, 2022https://github.com/angular/angular/pull/45060#event-6270081072
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45060
https://github.com/JiaLiPassion
JiaLiPassion https://github.com/JiaLiPassion
https://github.com/angular/angular/pull/45060/files/14fe2378935763c1ee0c9a41507fa90648a1b842
Please reload this pagehttps://github.com/angular/angular/pull/45060
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
hotlist: google https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20google%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/45060
https://github.com/varomodt
https://github.com/JiaLiPassion
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.