René's URL Explorer Experiment


Title: fix(zone.js): patch global instead of Mocha object by JiaLiPassion · Pull Request #45047 · angular/angular · GitHub

Open Graph Title: fix(zone.js): patch global instead of Mocha object by JiaLiPassion · Pull Request #45047 · angular/angular

X Title: fix(zone.js): patch global instead of Mocha object by JiaLiPassion · Pull Request #45047 · angular/angular

Description: Close #42834 In the new version fo Mocha, all global test functions are from global object instead of Mocha object. Adn the current zone.js Mocha patch's logic looks like this. global.describe = Mocha.describe = function() { return originalMochaDescribe.apply(this, arguments); } and originalMochaDescribe is the unpathced Mocha implementation looks like this function describe() { return context.describe(...); } And the context will finally delegate to global.describe(), so the current zone.js patch causes infinite loop. This commit will not patch function of Mocha object any longer.

Open Graph Description: Close #42834 In the new version fo Mocha, all global test functions are from global object instead of Mocha object. Adn the current zone.js Mocha patch's logic looks like this. global.describe ...

X Description: Close #42834 In the new version fo Mocha, all global test functions are from global object instead of Mocha object. Adn the current zone.js Mocha patch's logic looks like this. global.descr...

Opengraph URL: https://github.com/angular/angular/pull/45047

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9d981bd3-64d7-89bf-9848-0f9601be15bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFAA:10531B:263EEB:30D248:6B01004D
html-safe-nonce507d96d15ab0588ac451533a7f2caad17e984985b59c27a39fe46dff5d946fd6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkFBOjEwNTMxQjoyNjNFRUI6MzBEMjQ4OjZCMDEwMDREIiwidmlzaXRvcl9pZCI6IjY1OTI5MzUyNzQwMTgzMDgxNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca5485f8de7e9c30a5b6795805121213d9eb47e1eaaf530d5e0d6d58b6dca9e79
hovercard-subject-tagpull_request:846800549
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45047/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #42834 In the new version fo Mocha, all global test functions are from global object instead of Mocha object. Adn the current zone.js Mocha patch's logic looks like this. global.describe ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45047/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45047%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45047%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45047/files
Reloadhttps://github.com/angular/angular/pull/45047/files
Reloadhttps://github.com/angular/angular/pull/45047/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:mocha-8https://github.com/JiaLiPassion/angular/tree/mocha-8
Conversation 6 https://github.com/angular/angular/pull/45047
Commits 2 https://github.com/angular/angular/pull/45047/commits
Checks 0 https://github.com/angular/angular/pull/45047/checks
Files changed https://github.com/angular/angular/pull/45047/files
Please reload this pagehttps://github.com/angular/angular/pull/45047/files
fix(zone.js): patch global instead of Mocha object https://github.com/angular/angular/pull/45047/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/45047/files
09103a9 fix(zone.js): patch global instead of Mocha object JiaLiPassion Feb 11, 2022 https://github.com/angular/angular/pull/45047/commits/09103a9e8cce8f265dc15a559ae45b191adee192
9069560 test(zone.js): add integration test for zone.js Mocha patch JiaLiPassion Feb 11, 2022 https://github.com/angular/angular/pull/45047/commits/90695607ea141a0ed74b3e058cec67bf3909de54
Clear filters https://github.com/angular/angular/pull/45047/files
Please reload this pagehttps://github.com/angular/angular/pull/45047/files
Please reload this pagehttps://github.com/angular/angular/pull/45047/files
.browserslistrc https://github.com/angular/angular/pull/45047/files#diff-5c44c896ea48dc38828079dba9815f6bcc714733c87fd489aca8ba5e2bff5f21
.editorconfig https://github.com/angular/angular/pull/45047/files#diff-35bffa239a5ddc883e39e51d26a0f5f3a173dd7ba08ba4860c14cdb8454d4bc7
.gitignore https://github.com/angular/angular/pull/45047/files#diff-7cd61404a0505f7431fdd7aa53819ecf880adfc388e8e39dd777e528ada07e0e
BUILD.bazel https://github.com/angular/angular/pull/45047/files#diff-dfbc04c84a932736f3b909a37f067ab352ae48c7abc7320d0e498c9cb1db3882
README.md https://github.com/angular/angular/pull/45047/files#diff-b5c4eacf5381b9ef9178a7cef5e4477eb4f4ef4eca5db638250661f8c7088678
angular.json https://github.com/angular/angular/pull/45047/files#diff-a93f8b0660d5ae75162e1e32aaaf39e9c423898a77295f37b311dbbcf48e31d8
protractor.conf.js https://github.com/angular/angular/pull/45047/files#diff-040daa082853d6bc1f7dab8d3010bad95202c469de687b15176e0e5f65b830dc
app.e2e-spec.ts https://github.com/angular/angular/pull/45047/files#diff-6a664e5f7d9bc0fbe4c238a6c3e53697e9230554376e9b1a91752ff1bbf6a065
app.po.ts https://github.com/angular/angular/pull/45047/files#diff-d0947d7155e5389cfa3594096e0acda31f17ddfe6693a980d57595bbe83bfd33
tsconfig.json https://github.com/angular/angular/pull/45047/files#diff-267fbb86955edf7e7ba79e17c61cac3a30cf241629bff107b92f9bcca2096823
karma.conf.js https://github.com/angular/angular/pull/45047/files#diff-3583d4cb1b3d2c736a4a16d1024c5595e6928e39d64ef578496c13f5fe3eaa74
package.json https://github.com/angular/angular/pull/45047/files#diff-c2c0cd67e8e5aabbdd0c2502a3822b98c0dd4f84d46e26b456318d33fbac3c31
app.component.css https://github.com/angular/angular/pull/45047/files#diff-483b8758bfa6d8ef035931fc4781bb12d0ffc1328e34dd6d4ef1136ef5ed1d9b
app.component.html https://github.com/angular/angular/pull/45047/files#diff-8c684cce3c91162cfbd696bfe78817d86af7407d6f5c0d3f3c00f9432417178f
app.component.spec.ts https://github.com/angular/angular/pull/45047/files#diff-21e8708307183787010f03981f6ee2f898d71d96619416a6d3a5a04b03449e19
app.component.ts https://github.com/angular/angular/pull/45047/files#diff-7bf5e4c203b703a39b43df675a2dcbe643f15c0e3ff6ac39c2c3186fbe92ebac
app.module.ts https://github.com/angular/angular/pull/45047/files#diff-fdbccc8ad751c5f679c631b00c35c945c99695f37cd3dd6c604bbac2f2f37566
.gitkeep https://github.com/angular/angular/pull/45047/files#diff-aa8793a214dbca7aa9705cdac1d0c1d95e3794c788afdcaab0c79a06f84b0120
environment.prod.ts https://github.com/angular/angular/pull/45047/files#diff-2cd22def46d485bb2b99014c6a7d30ad209435840c035a50facd9109b9745d6d
environment.ts https://github.com/angular/angular/pull/45047/files#diff-db31dfc715a347bcce9760e8250d2b6e327e6a3a60bdafda09953aa0c36e74a7
favicon.ico https://github.com/angular/angular/pull/45047/files#diff-9dd57f7f48122239c12fe77898632715dac79c8f5d2a8ffcc5b11711b12e4c21
index.html https://github.com/angular/angular/pull/45047/files#diff-5bb44ffe77fbe1ed16309458ba3ada82015c0f96692a3370bce3c573ad9a63ac
main.ts https://github.com/angular/angular/pull/45047/files#diff-13bd5eb2f8bcb7ddbadc4e57e30817ca801db2157bbd36e661c73696cad70c2f
polyfills.ts https://github.com/angular/angular/pull/45047/files#diff-3b251faeb39d376ef83ed08a6bc56a9190a8a225738aabaae3a570af694131ba
styles.css https://github.com/angular/angular/pull/45047/files#diff-7453725659f8b63992399db08beb0049bd6075ebf673da77945b18bae81db0f3
test.ts https://github.com/angular/angular/pull/45047/files#diff-8dfc4cbd3dbd73ae6a63960a3d9a1d242d1a6a54fcf0fb0dbaecd732da09626d
tsconfig.app.json https://github.com/angular/angular/pull/45047/files#diff-38889b11731b0577d0a90a35c3051e2e9ced39689bb325f13c862cc1f73bd6f5
tsconfig.json https://github.com/angular/angular/pull/45047/files#diff-d7c82646329a3e372468312cbd3e00633ccd470662d3e33f1126d4e65977c281
tsconfig.spec.json https://github.com/angular/angular/pull/45047/files#diff-c19ee0e2711020bf5a232124c9af0618366b47d6a01ae2c62d84426170d1c3a0
tslint.json https://github.com/angular/angular/pull/45047/files#diff-6bdeb17fa31ec9f3b7e694f03905347c8a144107d810704d6e2c45f6b27e154a
yarn.lock https://github.com/angular/angular/pull/45047/files#diff-6e5d76cff9f6f16c6f8d909100d3e80a33ea5fc7f4adac4e03da9489d5044a55
mocha.ts https://github.com/angular/angular/pull/45047/files#diff-1fed7b5788477b7aae4e38f986c983561d756b7163cf9320975252df2ece850d
integration/cli-hello-world-mocha/.browserslistrchttps://github.com/angular/angular/pull/45047/files#diff-5c44c896ea48dc38828079dba9815f6bcc714733c87fd489aca8ba5e2bff5f21
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/.browserslistrc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/.editorconfighttps://github.com/angular/angular/pull/45047/files#diff-35bffa239a5ddc883e39e51d26a0f5f3a173dd7ba08ba4860c14cdb8454d4bc7
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/.editorconfig
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/.gitignorehttps://github.com/angular/angular/pull/45047/files#diff-7cd61404a0505f7431fdd7aa53819ecf880adfc388e8e39dd777e528ada07e0e
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/BUILD.bazelhttps://github.com/angular/angular/pull/45047/files#diff-dfbc04c84a932736f3b909a37f067ab352ae48c7abc7320d0e498c9cb1db3882
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/README.mdhttps://github.com/angular/angular/pull/45047/files#diff-b5c4eacf5381b9ef9178a7cef5e4477eb4f4ef4eca5db638250661f8c7088678
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/angular.jsonhttps://github.com/angular/angular/pull/45047/files#diff-a93f8b0660d5ae75162e1e32aaaf39e9c423898a77295f37b311dbbcf48e31d8
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/angular.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/e2e/protractor.conf.jshttps://github.com/angular/angular/pull/45047/files#diff-040daa082853d6bc1f7dab8d3010bad95202c469de687b15176e0e5f65b830dc
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/e2e/protractor.conf.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/e2e/src/app.e2e-spec.tshttps://github.com/angular/angular/pull/45047/files#diff-6a664e5f7d9bc0fbe4c238a6c3e53697e9230554376e9b1a91752ff1bbf6a065
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/e2e/src/app.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/e2e/src/app.po.tshttps://github.com/angular/angular/pull/45047/files#diff-d0947d7155e5389cfa3594096e0acda31f17ddfe6693a980d57595bbe83bfd33
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/e2e/src/app.po.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/e2e/tsconfig.jsonhttps://github.com/angular/angular/pull/45047/files#diff-267fbb86955edf7e7ba79e17c61cac3a30cf241629bff107b92f9bcca2096823
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/e2e/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
integration/cli-hello-world-mocha/karma.conf.jshttps://github.com/angular/angular/pull/45047/files#diff-3583d4cb1b3d2c736a4a16d1024c5595e6928e39d64ef578496c13f5fe3eaa74
View file https://github.com/JiaLiPassion/angular/blob/90695607ea141a0ed74b3e058cec67bf3909de54/integration/cli-hello-world-mocha/karma.conf.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45047/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/45047/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.