René's URL Explorer Experiment


Title: fix(zone.js): async-test should only call done once by JiaLiPassion · Pull Request #45025 · angular/angular · GitHub

Open Graph Title: fix(zone.js): async-test should only call done once by JiaLiPassion · Pull Request #45025 · angular/angular

X Title: fix(zone.js): async-test should only call done once by JiaLiPassion · Pull Request #45025 · angular/angular

Description: AsyncTestZoneSpec triggers jasmine done() function multiple times and causes warning An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll, beforeEach, afterAll, or afterEach function in question. This will be treated as an error in a future version. See for more information The reproduce case will be running some Zone.run() inside waitForAsync(). it('multiple done', waitForAsync(() => { Zone.current.run(() => {}); Zone.current.run(() => {}); })); The reason the done() is called in the onInvoke() hook is to handle the case that the testBody is totally sync, but we should only do this check for the entry function not for all Zone.run() scenario. Another issue is if we have nested zone inside waitForAsync(), the onHasTask() hook will be triggered multiple times and cause the done() callback to be triggered multiple times, so we should only trigger it when the zone is AsyncTestZone. This fix will also fix a lot of flaky errors caused by done() is being invoked too earlier. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: related to this PR #44923

Open Graph Description: AsyncTestZoneSpec triggers jasmine done() function multiple times and causes warning An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll...

X Description: AsyncTestZoneSpec triggers jasmine done() function multiple times and causes warning An asynchronous function called its 'done' callback more than once. This is a bug in the spec, b...

Opengraph URL: https://github.com/angular/angular/pull/45025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:144b70c1-86b7-c33e-f8d6-d55e153ec9be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8346:38E318:292380:33A534:6B01006F
html-safe-nonce1fcedfc54876a193a1a5baafe1221c31a2994c2e6e5d1a56d657660bec8dcc7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzQ2OjM4RTMxODoyOTIzODA6MzNBNTM0OjZCMDEwMDZGIiwidmlzaXRvcl9pZCI6IjQxNDc2OTg5NzIzNjM5MTUzNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac666fbb1769ae359c3dfad709a17897b7738e482e7214aa101b3c940bcbc50455
hovercard-subject-tagpull_request:843538100
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/45025/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altAsyncTestZoneSpec triggers jasmine done() function multiple times and causes warning An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/45025/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45025%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F45025%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/45025/files
Reloadhttps://github.com/angular/angular/pull/45025/files
Reloadhttps://github.com/angular/angular/pull/45025/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:async-test-multiple-donehttps://github.com/JiaLiPassion/angular/tree/async-test-multiple-done
Conversation 8 https://github.com/angular/angular/pull/45025
Commits 2 https://github.com/angular/angular/pull/45025/commits
Checks 0 https://github.com/angular/angular/pull/45025/checks
Files changed https://github.com/angular/angular/pull/45025/files
Please reload this pagehttps://github.com/angular/angular/pull/45025/files
fix(zone.js): async-test should only call done once https://github.com/angular/angular/pull/45025/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/45025/files
d29b95f fix(zone.js): async-test should only call done once JiaLiPassion Feb 9, 2022 https://github.com/angular/angular/pull/45025/commits/d29b95fb358fca6bfda576ba01b5ab6d72072e37
4d6674c fix(zone.js): fix several test cases which trigger `done()` multiple … JiaLiPassion Feb 9, 2022 https://github.com/angular/angular/pull/45025/commits/4d6674c8842d9f60c6a47cfae436c3ab2061cfde
Clear filters https://github.com/angular/angular/pull/45025/files
Please reload this pagehttps://github.com/angular/angular/pull/45025/files
Please reload this pagehttps://github.com/angular/angular/pull/45025/files
async-test.ts https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
XMLHttpRequest.spec.ts https://github.com/angular/angular/pull/45025/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
browser.spec.ts https://github.com/angular/angular/pull/45025/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
cordova.spec.ts https://github.com/angular/angular/pull/45025/files#diff-5b1ddf00ed248bcf83f62defae22c57c428d8fffbc6d1c820cd1a3f1f647ccd2
async-test.spec.ts https://github.com/angular/angular/pull/45025/files#diff-32c2a29cdea59e133c6018be7e3a9a8a2dc901f295568f9efe2271560eeff6f9
packages/zone.js/lib/zone-spec/async-test.tshttps://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
View file https://github.com/JiaLiPassion/angular/blob/4d6674c8842d9f60c6a47cfae436c3ab2061cfde/packages/zone.js/lib/zone-spec/async-test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
Please reload this pagehttps://github.com/angular/angular/pull/45025/files
https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
https://github.com/angular/angular/pull/45025/files#diff-ebd96474361ea6417e75912c5dd760740cf9da9da7ee25c0de04c07ef307e50e
packages/zone.js/test/browser/XMLHttpRequest.spec.tshttps://github.com/angular/angular/pull/45025/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
View file https://github.com/JiaLiPassion/angular/blob/4d6674c8842d9f60c6a47cfae436c3ab2061cfde/packages/zone.js/test/browser/XMLHttpRequest.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45025/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
https://github.com/angular/angular/pull/45025/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
packages/zone.js/test/browser/browser.spec.tshttps://github.com/angular/angular/pull/45025/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
View file https://github.com/JiaLiPassion/angular/blob/4d6674c8842d9f60c6a47cfae436c3ab2061cfde/packages/zone.js/test/browser/browser.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45025/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
https://github.com/angular/angular/pull/45025/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
packages/zone.js/test/extra/cordova.spec.tshttps://github.com/angular/angular/pull/45025/files#diff-5b1ddf00ed248bcf83f62defae22c57c428d8fffbc6d1c820cd1a3f1f647ccd2
View file https://github.com/JiaLiPassion/angular/blob/4d6674c8842d9f60c6a47cfae436c3ab2061cfde/packages/zone.js/test/extra/cordova.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45025/files#diff-5b1ddf00ed248bcf83f62defae22c57c428d8fffbc6d1c820cd1a3f1f647ccd2
https://github.com/angular/angular/pull/45025/files#diff-5b1ddf00ed248bcf83f62defae22c57c428d8fffbc6d1c820cd1a3f1f647ccd2
packages/zone.js/test/zone-spec/async-test.spec.tshttps://github.com/angular/angular/pull/45025/files#diff-32c2a29cdea59e133c6018be7e3a9a8a2dc901f295568f9efe2271560eeff6f9
View file https://github.com/JiaLiPassion/angular/blob/4d6674c8842d9f60c6a47cfae436c3ab2061cfde/packages/zone.js/test/zone-spec/async-test.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/45025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/45025/files#diff-32c2a29cdea59e133c6018be7e3a9a8a2dc901f295568f9efe2271560eeff6f9
https://github.com/angular/angular/pull/45025/files#diff-32c2a29cdea59e133c6018be7e3a9a8a2dc901f295568f9efe2271560eeff6f9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.