René's URL Explorer Experiment


Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular · GitHub

Open Graph Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular

X Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular

Description: Currently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll, beforeEach, afterAll, or afterEach function in question. This will be treated as an error in a future version. See for more information These changes add a wrapper around the done function so it only gets called once, otherwise we risk triggering errors in future versions of Jasmine. Note: I couldn't figure out a good way to add a test for this since it would be checking something that's part of the testing infrastructure.

Open Graph Description: Currently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...

X Description: Currently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...

Opengraph URL: https://github.com/angular/angular/pull/44923

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:70f99137-5609-2627-1f8c-593c9e8b51d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0CA:369D8B:15EE8E:1CD7D5:6B01629C
html-safe-nonce356cc7d4ea41cea17d9825a5367f7d34b8ce0012aae509a2deaddc087d4228c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMENBOjM2OUQ4QjoxNUVFOEU6MUNEN0Q1OjZCMDE2MjlDIiwidmlzaXRvcl9pZCI6Ijc3MTg4NjQzNDY5NjEyNzEzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac667f599ea785fd042bba835a5ed81b88c9f5e334b832c3ab96001304a98d91c4
hovercard-subject-tagpull_request:837009143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/44923/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altCurrently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/44923/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44923%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44923%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/44923/files
Reloadhttps://github.com/angular/angular/pull/44923/files
Reloadhttps://github.com/angular/angular/pull/44923/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:zone-done-warninghttps://github.com/crisbeto/angular/tree/zone-done-warning
Conversation 7 https://github.com/angular/angular/pull/44923
Commits 1 https://github.com/angular/angular/pull/44923/commits
Checks 0 https://github.com/angular/angular/pull/44923/checks
Files changed https://github.com/angular/angular/pull/44923/files
Please reload this pagehttps://github.com/angular/angular/pull/44923/files
fix(zone.js): only call jasmine test done function once https://github.com/angular/angular/pull/44923/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/44923/files
2cf5c40 fix(zone.js): only call jasmine test done function once crisbeto Feb 1, 2022 https://github.com/angular/angular/pull/44923/commits/2cf5c4020339501537b1be8fbbffeae08453cfbc
Clear filters https://github.com/angular/angular/pull/44923/files
Please reload this pagehttps://github.com/angular/angular/pull/44923/files
Please reload this pagehttps://github.com/angular/angular/pull/44923/files
packages/zone.js/lib/jasmine/jasmine.tshttps://github.com/angular/angular/pull/44923/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
View file https://github.com/crisbeto/angular/blob/2cf5c4020339501537b1be8fbbffeae08453cfbc/packages/zone.js/lib/jasmine/jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44923/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44923/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/44923/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/44923/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com/angular/angular/pull/44923/files#diff-041a9e7698635365d463d048731ed0f817a67aeb1faf54136e24ad5640ebfa2d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.