René's URL Explorer Experiment


Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular · GitHub

Open Graph Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular

X Title: fix(zone.js): only call jasmine test done function once by crisbeto · Pull Request #44923 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...

X Description: Currently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...

Opengraph URL: https://github.com/angular/angular/pull/44923

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c73ea7d6-073b-48a3-7ebf-f71e1d19b792
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id989E:2E124E:BEDBEB:F495E2:6B00FF5C
html-safe-nonced8926c754d443f843c3d262c945bf690b53a50459d76b872521dc10484de2346
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODlFOjJFMTI0RTpCRURCRUI6RjQ5NUUyOjZCMDBGRjVDIiwidmlzaXRvcl9pZCI6IjYyNjk5MjA1MDc0OTIxMDYwNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac343b71a74b8fe23c9893c90d60a942a4c2863bfc58dec3ad4fa66d474fa1f042
hovercard-subject-tagpull_request:837009143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/44923/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1416b99bc8d3698f9242cc9041cad20333c93e35a1e4e7290ace73f44160f45/angular/angular/pull/44923
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1416b99bc8d3698f9242cc9041cad20333c93e35a1e4e7290ace73f44160f45/angular/angular/pull/44923
og:image:altCurrently zone.js may end up attempting to call the done function of async tests more than once. This used to be a noop, but Jasmine now logs the following warning: DEPRECATION: An asynchronous fun...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecrisbeto
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/44923#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44923
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44923
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/44923
Reloadhttps://github.com/angular/angular/pull/44923
Reloadhttps://github.com/angular/angular/pull/44923
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:zone-done-warninghttps://github.com/crisbeto/angular/tree/zone-done-warning
Conversationhttps://github.com/angular/angular/pull/44923
Commits1 (1)https://github.com/angular/angular/pull/44923/commits
Checkshttps://github.com/angular/angular/pull/44923/checks
Files changedhttps://github.com/angular/angular/pull/44923/files
fix(zone.js): only call jasmine test done function oncehttps://github.com/angular/angular/pull/44923#top
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:zone-done-warninghttps://github.com/crisbeto/angular/tree/zone-done-warning
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Feb 1, 2022https://github.com/angular/angular/pull/44923#issue-1120434230
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/04245065e22ca04be8304706d74f66d6697404b8..56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6
0424506https://github.com/angular/angular/commit/04245065e22ca04be8304706d74f66d6697404b8
56cb25fhttps://github.com/angular/angular/commit/56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6
Compare https://github.com/angular/angular/compare/04245065e22ca04be8304706d74f66d6697404b8..56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6
February 1, 2022 09:46https://github.com/angular/angular/pull/44923#event-5986837867
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
February 1, 2022 11:22https://github.com/angular/angular/pull/44923#event-5987457082
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JiaLiPassionhttps://github.com/JiaLiPassion
February 1, 2022 11:22https://github.com/angular/angular/pull/44923#event-5987457687
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Feb 1, 2022https://github.com/angular/angular/pull/44923#event-5987458313
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Feb 1, 2022https://github.com/angular/angular/pull/44923#event-5987458461
https://github.com/crisbeto
fix(zone.js): only call jasmine test done function oncehttps://github.com/angular/angular/pull/44923/commits/2cf5c4020339501537b1be8fbbffeae08453cfbc
2cf5c40https://github.com/angular/angular/pull/44923/commits/2cf5c4020339501537b1be8fbbffeae08453cfbc
https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-timeshttps://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6..2cf5c4020339501537b1be8fbbffeae08453cfbc
56cb25fhttps://github.com/angular/angular/commit/56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6
2cf5c40https://github.com/angular/angular/commit/2cf5c4020339501537b1be8fbbffeae08453cfbc
Compare https://github.com/angular/angular/compare/56cb25f5219a62f8a8c24eb77e9557d66ac1b8a6..2cf5c4020339501537b1be8fbbffeae08453cfbc
February 2, 2022 08:30https://github.com/angular/angular/pull/44923#event-5994036698
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 7, 2022https://github.com/angular/angular/pull/44923#issuecomment-1031377291
@crisbetohttps://github.com/crisbeto
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Feb 7, 2022https://github.com/angular/angular/pull/44923#issuecomment-1031398080
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 9, 2022https://github.com/angular/angular/pull/44923#issuecomment-1033294314
@crisbetohttps://github.com/crisbeto
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Feb 9, 2022https://github.com/angular/angular/pull/44923#issuecomment-1033400579
https://github.com/angular/angular/blob/master/packages/zone.js/lib/zone-spec/async-test.ts#L226https://github.com/angular/angular/blob/master/packages/zone.js/lib/zone-spec/async-test.ts#L226
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 9, 2022 https://github.com/angular/angular/pull/44923#ref-pullrequest-1128112964
fix(zone.js): async-test should only call done once #45025 https://github.com/angular/angular/pull/45025
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Feb 9, 2022https://github.com/angular/angular/pull/44923#issuecomment-1033403208
@crisbetohttps://github.com/crisbeto
#45025https://github.com/angular/angular/pull/45025
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Feb 9, 2022https://github.com/angular/angular/pull/44923#issuecomment-1033404521
#45025https://github.com/angular/angular/pull/45025
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Feb 9, 2022https://github.com/angular/angular/pull/44923#event-6031903980
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 12, 2022https://github.com/angular/angular/pull/44923#issuecomment-1065909480
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 12, 2022https://github.com/angular/angular/pull/44923#event-6229919305
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44923
https://github.com/JiaLiPassion
JiaLiPassion https://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/44923
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/44923
https://github.com/crisbeto
https://github.com/JiaLiPassion
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.