René's URL Explorer Experiment


Title: fix(animations): allow animations with unsupported CSS properties by dario-piotrowicz · Pull Request #44729 · angular/angular · GitHub

Open Graph Title: fix(animations): allow animations with unsupported CSS properties by dario-piotrowicz · Pull Request #44729 · angular/angular

X Title: fix(animations): allow animations with unsupported CSS properties by dario-piotrowicz · Pull Request #44729 · angular/angular

Description: currently animations with unsupported CSS properties cause a hard error and the crash of the animation itself, instead of this behaviour just ignore such properties and provide a warning for the developer in the console (only in dev mode) resolves #23195 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: Issue Issue Number: #23195 Does this PR introduce a breaking change? Yes No I don't think it's a breaking change, unless someone was actually in some circumstances relying on the animations crushing when finding unsupported CSS properties 🤔 Other information You can notice that the warnings I've added are strings which is inconsistent with the errors being anys, I believe the errors should actually also be strings and I've already opened #44726 to update their type 🙂

Open Graph Description: currently animations with unsupported CSS properties cause a hard error and the crash of the animation itself, instead of this behaviour just ignore such properties and provide a warning for the de...

X Description: currently animations with unsupported CSS properties cause a hard error and the crash of the animation itself, instead of this behaviour just ignore such properties and provide a warning for the de...

Opengraph URL: https://github.com/angular/angular/pull/44729

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e6db1e9f-55ad-74a7-102d-58f546d97cc6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8832:1D8AA1:EB139A:136B648:6B00FC9E
html-safe-nonce33432a81157038106053a2fde2dae63c9014ecfd2840b959071a8ae49ef4f28c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODMyOjFEOEFBMTpFQjEzOUE6MTM2QjY0ODo2QjAwRkM5RSIsInZpc2l0b3JfaWQiOiIyOTM1NDgzOTMyNDA3Mjk5MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1cf4ef7a8bd8462ee70048d44a14ab94eb25d1af47c49959f3ba688a7f57e0c9
hovercard-subject-tagpull_request:823888889
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/44729/files
twitter:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
og:image:altcurrently animations with unsupported CSS properties cause a hard error and the crash of the animation itself, instead of this behaviour just ignore such properties and provide a warning for the de...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/44729/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44729%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F44729%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/44729/files
Reloadhttps://github.com/angular/angular/pull/44729/files
Reloadhttps://github.com/angular/angular/pull/44729/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dario-piotrowiczhttps://github.com/dario-piotrowicz
angular:masterhttps://github.com/angular/angular/tree/master
dario-piotrowicz:animations-skip-unsupported-css-propertieshttps://github.com/dario-piotrowicz/angular/tree/animations-skip-unsupported-css-properties
Conversation 36 https://github.com/angular/angular/pull/44729
Commits 1 https://github.com/angular/angular/pull/44729/commits
Checks 0 https://github.com/angular/angular/pull/44729/checks
Files changed https://github.com/angular/angular/pull/44729/files
Please reload this pagehttps://github.com/angular/angular/pull/44729/files
fix(animations): allow animations with unsupported CSS properties https://github.com/angular/angular/pull/44729/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/44729/files
8cface7 fix(animations): allow animations with unsupported CSS properties dario-piotrowicz Feb 12, 2022 https://github.com/angular/angular/pull/44729/commits/8cface754263e1545b0307407ea07f793cb3e7a6
Clear filters https://github.com/angular/angular/pull/44729/files
Please reload this pagehttps://github.com/angular/angular/pull/44729/files
Please reload this pagehttps://github.com/angular/angular/pull/44729/files
animation.ts https://github.com/angular/angular/pull/44729/files#diff-ab4e796fcd8594f59bb7a0b292784cfad4b25df190c7de38fd18c93d97a338e4
animation_ast_builder.ts https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
animation_engine_next.ts https://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
timeline_animation_engine.ts https://github.com/angular/angular/pull/44729/files#diff-288f3b266c7d9a7878a8256b76eed0b978aa8758b36ed15b9e470a7164850481
warning_helpers.ts https://github.com/angular/angular/pull/44729/files#diff-16e21b505fb0e8fba49d02afd41b653eef528218fb1aed76037d210f70e15884
animation_spec.ts https://github.com/angular/angular/pull/44729/files#diff-bda5120134707b0db8511b638548c61d93c1898b970eaeea306a85263be97ed9
transition_animation_engine_spec.ts https://github.com/angular/angular/pull/44729/files#diff-0b1b32e50484dba50a740360ada2248e6a45221b6944568e17c098c21f8bbbe1
shared.ts https://github.com/angular/angular/pull/44729/files#diff-c530725efbd999019ff9cf9da2c6a25a7a667ba04887058a2f61fda470eb1576
packages/animations/browser/src/dsl/animation.tshttps://github.com/angular/angular/pull/44729/files#diff-ab4e796fcd8594f59bb7a0b292784cfad4b25df190c7de38fd18c93d97a338e4
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/src/dsl/animation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-ab4e796fcd8594f59bb7a0b292784cfad4b25df190c7de38fd18c93d97a338e4
https://github.com/angular/angular/pull/44729/files#diff-ab4e796fcd8594f59bb7a0b292784cfad4b25df190c7de38fd18c93d97a338e4
https://github.com/angular/angular/pull/44729/files#diff-ab4e796fcd8594f59bb7a0b292784cfad4b25df190c7de38fd18c93d97a338e4
packages/animations/browser/src/dsl/animation_ast_builder.tshttps://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/src/dsl/animation_ast_builder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/44729/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
packages/animations/browser/src/render/animation_engine_next.tshttps://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/src/render/animation_engine_next.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
https://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
https://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
https://github.com/angular/angular/pull/44729/files#diff-6dc7fc64ee048c86f0f592ac2c8a4cdbb7de68419cd89335c72d9ff4952337c2
packages/animations/browser/src/render/timeline_animation_engine.tshttps://github.com/angular/angular/pull/44729/files#diff-288f3b266c7d9a7878a8256b76eed0b978aa8758b36ed15b9e470a7164850481
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/src/render/timeline_animation_engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-288f3b266c7d9a7878a8256b76eed0b978aa8758b36ed15b9e470a7164850481
https://github.com/angular/angular/pull/44729/files#diff-288f3b266c7d9a7878a8256b76eed0b978aa8758b36ed15b9e470a7164850481
https://github.com/angular/angular/pull/44729/files#diff-288f3b266c7d9a7878a8256b76eed0b978aa8758b36ed15b9e470a7164850481
packages/animations/browser/src/warning_helpers.tshttps://github.com/angular/angular/pull/44729/files#diff-16e21b505fb0e8fba49d02afd41b653eef528218fb1aed76037d210f70e15884
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/src/warning_helpers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
packages/animations/browser/test/dsl/animation_spec.tshttps://github.com/angular/angular/pull/44729/files#diff-bda5120134707b0db8511b638548c61d93c1898b970eaeea306a85263be97ed9
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/test/dsl/animation_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-bda5120134707b0db8511b638548c61d93c1898b970eaeea306a85263be97ed9
https://github.com/angular/angular/pull/44729/files#diff-bda5120134707b0db8511b638548c61d93c1898b970eaeea306a85263be97ed9
https://github.com/angular/angular/pull/44729/files#diff-bda5120134707b0db8511b638548c61d93c1898b970eaeea306a85263be97ed9
packages/animations/browser/test/render/transition_animation_engine_spec.tshttps://github.com/angular/angular/pull/44729/files#diff-0b1b32e50484dba50a740360ada2248e6a45221b6944568e17c098c21f8bbbe1
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/test/render/transition_animation_engine_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-0b1b32e50484dba50a740360ada2248e6a45221b6944568e17c098c21f8bbbe1
https://github.com/angular/angular/pull/44729/files#diff-0b1b32e50484dba50a740360ada2248e6a45221b6944568e17c098c21f8bbbe1
packages/animations/browser/test/shared.tshttps://github.com/angular/angular/pull/44729/files#diff-c530725efbd999019ff9cf9da2c6a25a7a667ba04887058a2f61fda470eb1576
View file https://github.com/dario-piotrowicz/angular/blob/8cface754263e1545b0307407ea07f793cb3e7a6/packages/animations/browser/test/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/44729/{{ revealButtonHref }}
https://github.com/angular/angular/pull/44729/files#diff-c530725efbd999019ff9cf9da2c6a25a7a667ba04887058a2f61fda470eb1576
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.