René's URL Explorer Experiment


Title: refactor(service-worker): avoid unnecessary writes to cache when version fails by gkalpak · Pull Request #43680 · angular/angular · GitHub

Open Graph Title: refactor(service-worker): avoid unnecessary writes to cache when version fails by gkalpak · Pull Request #43680 · angular/angular

X Title: refactor(service-worker): avoid unnecessary writes to cache when version fails by gkalpak · Pull Request #43680 · angular/angular

Description: When an app version is detected as broken, the SW calls the Driver#versionFailed() method. Previously, this method would in turn call the Driver#sync() method, which writes some metadata about the SW's state to the ngsw:/:db:contol cache. More specifically, Driver#sync() persists info about all known app versions, which one is the latest and also what version each client is assigned to. However, no relevant info is changed inside Driver#versionFailed(), so the call to Driver#sync() is redundant (since there are no changes that need to be synced with the cache). This is a left-over from before #43518, when Driver#versionFailed() used to update version assignments and thus did require synchronization with the cache. This commit removes the redundant Driver#sync() call to avoid an unnecessary write to the cache.

Open Graph Description: When an app version is detected as broken, the SW calls the Driver#versionFailed() method. Previously, this method would in turn call the Driver#sync() method, which writes some metadata about the ...

X Description: When an app version is detected as broken, the SW calls the Driver#versionFailed() method. Previously, this method would in turn call the Driver#sync() method, which writes some metadata about the ...

Opengraph URL: https://github.com/angular/angular/pull/43680

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8530d03-0ea4-80c3-749f-c2fb5ff0497a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD342:27E5CD:2448C36:2E6DB7E:6B017A19
html-safe-nonce45f113f71fb49064082d08cb7be26472f19cca0053dbc9ebf90aa7cf084698fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzQyOjI3RTVDRDoyNDQ4QzM2OjJFNkRCN0U6NkIwMTdBMTkiLCJ2aXNpdG9yX2lkIjoiNjYxOTYyNjMxMzkxOTU5Mjk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4048d804b699cd28e35e6172a3b6c16385ea5cf408aeba5f65d7d131bba9ea51
hovercard-subject-tagpull_request:748145740
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43680/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altWhen an app version is detected as broken, the SW calls the Driver#versionFailed() method. Previously, this method would in turn call the Driver#sync() method, which writes some metadata about the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/43680/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43680%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43680%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43680/files
Reloadhttps://github.com/angular/angular/pull/43680/files
Reloadhttps://github.com/angular/angular/pull/43680/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:refactor-sw-unnecessary-synchttps://github.com/gkalpak/angular/tree/refactor-sw-unnecessary-sync
Conversation 5 https://github.com/angular/angular/pull/43680
Commits 1 https://github.com/angular/angular/pull/43680/commits
Checks 0 https://github.com/angular/angular/pull/43680/checks
Files changed https://github.com/angular/angular/pull/43680/files
Please reload this pagehttps://github.com/angular/angular/pull/43680/files
refactor(service-worker): avoid unnecessary writes to cache when version fails https://github.com/angular/angular/pull/43680/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/43680/files
c3a9ce3 refactor(service-worker): avoid unnecessary writes to cache when vers… gkalpak Oct 5, 2021 https://github.com/angular/angular/pull/43680/commits/c3a9ce34e718dc5981c6a97a4007f3779561ca44
Clear filters https://github.com/angular/angular/pull/43680/files
Please reload this pagehttps://github.com/angular/angular/pull/43680/files
Please reload this pagehttps://github.com/angular/angular/pull/43680/files
packages/service-worker/worker/src/driver.tshttps://github.com/angular/angular/pull/43680/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
View file https://github.com/gkalpak/angular/blob/c3a9ce34e718dc5981c6a97a4007f3779561ca44/packages/service-worker/worker/src/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43680/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43680/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/43680/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.