René's URL Explorer Experiment


Title: fix(service-worker): make `ngsw.json` generation deterministic and correct by gkalpak · Pull Request #43679 · angular/angular · GitHub

Open Graph Title: fix(service-worker): make `ngsw.json` generation deterministic and correct by gkalpak · Pull Request #43679 · angular/angular

X Title: fix(service-worker): make `ngsw.json` generation deterministic and correct by gkalpak · Pull Request #43679 · angular/angular

Description: Previously, all asset-groups from ngsw-config.json were processed in parallel. For each asset-group, we retrieved all files for the current build, filtered out files that were already matched by other asset-groups, determined which of the remaining files belonged to the current asset-group and generated entries for the ngsw.json manifest. This process was susceptible to race conditions when there were files that would be matched by multiple asset-groups. This made the generation of the ngsw.json manifest non-deterministic and violated the rule that each file would belong to the first asset-group that matched it (based on the asset-groups' order of appearance in ngsw-config.json), thus leading to broken ServiceWorker behavior. This commit fixes it by ensuring that the generation process is deterministic and that asset-groups are processed in the proper order. NOTE 1: The generation process has been broken since the beginning, but we have only noticed this recently. This is possibly related to the CLI's switching from a virtual file system host (which has more consistent timing characteristics) to the Node.js built-in fs.promises in angular/angular-cli@d3bc530. NOTE 2: This commit also ensures that files in the ngsw.json hash-table are in alphabetic order. Previously, the files were added to the hash-table in blocks corresponding to each asset-group. This change is not necessary (i.e. the order of keys in the hash-table makes no difference in behavior), but it makes it easier to scan for a file (for example, for debugging purposes). NOTE: Once AIO is updated to a version that includes this fix, remove this work-around.

Open Graph Description: Previously, all asset-groups from ngsw-config.json were processed in parallel. For each asset-group, we retrieved all files for the current build, filtered out files that were already matched by ot...

X Description: Previously, all asset-groups from ngsw-config.json were processed in parallel. For each asset-group, we retrieved all files for the current build, filtered out files that were already matched by ot...

Opengraph URL: https://github.com/angular/angular/pull/43679

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3d40d8bf-c7e2-3da7-758b-150d3e5cf39c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD05E:1C6C3E:1C56753:254EDC7:6B01550E
html-safe-noncedccc7b09f2e10700867a945bb3f3041f1b5ca1e9c1c4e4409554c572815c193a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDVFOjFDNkMzRToxQzU2NzUzOjI1NEVEQzc6NkIwMTU1MEUiLCJ2aXNpdG9yX2lkIjoiMjc1NjYyNDE4OTc3ODY0NjI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3ee0ee3f0802d06b43296f68d44b83863592c0be65b59cf3374ed51a3ce0abe5
hovercard-subject-tagpull_request:748097037
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43679/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, all asset-groups from ngsw-config.json were processed in parallel. For each asset-group, we retrieved all files for the current build, filtered out files that were already matched by ot...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/43679/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43679%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43679%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43679/files
Reloadhttps://github.com/angular/angular/pull/43679/files
Reloadhttps://github.com/angular/angular/pull/43679/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-config-asset-racehttps://github.com/gkalpak/angular/tree/fix-sw-config-asset-race
Conversation 19 https://github.com/angular/angular/pull/43679
Commits 2 https://github.com/angular/angular/pull/43679/commits
Checks 0 https://github.com/angular/angular/pull/43679/checks
Files changed https://github.com/angular/angular/pull/43679/files
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
fix(service-worker): make ngsw.json generation deterministic and correct https://github.com/angular/angular/pull/43679/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/43679/files
ae296b5 fix(service-worker): make `ngsw.json` generation deterministic and co… gkalpak Oct 5, 2021 https://github.com/angular/angular/pull/43679/commits/ae296b5066f85fc88c652de838f7a7d25839578e
be62c33 fixup! fix(service-worker): make `ngsw.json` generation deterministic… gkalpak Oct 5, 2021 https://github.com/angular/angular/pull/43679/commits/be62c332ad6df2f54a634693b5cd0cfc898d85fe
Clear filters https://github.com/angular/angular/pull/43679/files
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
generator.ts https://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
generator_spec.ts https://github.com/angular/angular/pull/43679/files#diff-85abc9d25a07b6853113b010046e6669d5deafb3084d3630679f67cf5aaae329
packages/service-worker/config/src/generator.tshttps://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
View file https://github.com/gkalpak/angular/blob/be62c332ad6df2f54a634693b5cd0cfc898d85fe/packages/service-worker/config/src/generator.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43679/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
https://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
https://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
https://github.com/angular/angular/pull/43679/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
packages/service-worker/config/test/generator_spec.tshttps://github.com/angular/angular/pull/43679/files#diff-85abc9d25a07b6853113b010046e6669d5deafb3084d3630679f67cf5aaae329
View file https://github.com/gkalpak/angular/blob/be62c332ad6df2f54a634693b5cd0cfc898d85fe/packages/service-worker/config/test/generator_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43679/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43679/files#diff-85abc9d25a07b6853113b010046e6669d5deafb3084d3630679f67cf5aaae329
petebacondarwinhttps://github.com/petebacondarwin
Oct 5, 2021https://github.com/angular/angular/pull/43679/files#r722224154
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
petebacondarwinhttps://github.com/petebacondarwin
Oct 5, 2021https://github.com/angular/angular/pull/43679/files#r722229471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
gkalpakhttps://github.com/gkalpak
Oct 5, 2021https://github.com/angular/angular/pull/43679/files#r722348070
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43679/files
https://github.com/angular/angular/pull/43679/files#diff-85abc9d25a07b6853113b010046e6669d5deafb3084d3630679f67cf5aaae329
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.