| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d8c2f490-9428-fcab-1970-13671aac8b84 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4A0:31B4CC:FAA3E7:14ACD68:6B0104F5 |
| html-safe-nonce | 337efd827ec97c45634d678035982208b9ad85bcbb2860e2649cd7152ae001bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEEwOjMxQjRDQzpGQUEzRTc6MTRBQ0Q2ODo2QjAxMDRGNSIsInZpc2l0b3JfaWQiOiIzMzc0NzU2NDcxNDI5NDY1MzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2b9a45025cd15c921277c98abab9348094a152c8aaa236eebf4cd99fb0e4414e |
| hovercard-subject-tag | pull_request:742750044 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/43591/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ff3ddad90102414cdb5c78443869f95d4d2a44ee84149aa4f4dfba0b16a5f84f/angular/angular/pull/43591 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ff3ddad90102414cdb5c78443869f95d4d2a44ee84149aa4f4dfba0b16a5f84f/angular/angular/pull/43591 |
| og:image:alt | This commit removes the ability to configure lazy routes using a string
for loadChildren, together with the supporting classes to load an
NgModuleFactory at runtime.
BREAKING CHANGE:
It is no longe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoostK |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/43591#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/43591 |
| Reload | https://github.com/angular/angular/pull/43591 |
| Reload | https://github.com/angular/angular/pull/43591 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:remove-loadchildren-string-all-in | https://github.com/JoostK/angular/tree/remove-loadchildren-string-all-in |
| Conversation | https://github.com/angular/angular/pull/43591 |
| Commits6 (6) | https://github.com/angular/angular/pull/43591/commits |
| Checks | https://github.com/angular/angular/pull/43591/checks |
| Files changed | https://github.com/angular/angular/pull/43591/files |
| refactor(router): remove support for loadChildren string syntax | https://github.com/angular/angular/pull/43591#top |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:remove-loadchildren-string-all-in | https://github.com/JoostK/angular/tree/remove-loadchildren-string-all-in |
|
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issue-1007182734 |
| #43575 | https://github.com/angular/angular/pull/43575 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360181443 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-927175725 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360181540 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360181578 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360181700 |
| https://github.com/apps/angular-robot |
| angular-robot | https://github.com/apps/angular-robot |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360181702 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/d484e311426c2cdb5aa787fc74cb6293e9c7e56c..29ea2692594f1c568162afd75608ca0d0c8c2679 |
| d484e31 | https://github.com/angular/angular/commit/d484e311426c2cdb5aa787fc74cb6293e9c7e56c |
| 29ea269 | https://github.com/angular/angular/commit/29ea2692594f1c568162afd75608ca0d0c8c2679 |
|
Compare
| https://github.com/angular/angular/compare/d484e311426c2cdb5aa787fc74cb6293e9c7e56c..29ea2692594f1c568162afd75608ca0d0c8c2679 |
| September 25, 2021 20:01 | https://github.com/angular/angular/pull/43591#event-5360184033 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-927176012 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/29ea2692594f1c568162afd75608ca0d0c8c2679..7c44826b39e36f07bfe0f1bcf84520a6047a7e82 |
| 29ea269 | https://github.com/angular/angular/commit/29ea2692594f1c568162afd75608ca0d0c8c2679 |
| 7c44826 | https://github.com/angular/angular/commit/7c44826b39e36f07bfe0f1bcf84520a6047a7e82 |
|
Compare
| https://github.com/angular/angular/compare/29ea2692594f1c568162afd75608ca0d0c8c2679..7c44826b39e36f07bfe0f1bcf84520a6047a7e82 |
| September 25, 2021 21:00 | https://github.com/angular/angular/pull/43591#event-5360244022 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-927182222 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/7c44826b39e36f07bfe0f1bcf84520a6047a7e82..ddbe652811def57093bddfa8b3fbe60496fee149 |
| 7c44826 | https://github.com/angular/angular/commit/7c44826b39e36f07bfe0f1bcf84520a6047a7e82 |
| ddbe652 | https://github.com/angular/angular/commit/ddbe652811def57093bddfa8b3fbe60496fee149 |
|
Compare
| https://github.com/angular/angular/compare/7c44826b39e36f07bfe0f1bcf84520a6047a7e82..ddbe652811def57093bddfa8b3fbe60496fee149 |
| September 25, 2021 21:38 | https://github.com/angular/angular/pull/43591#event-5360282193 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-927186081 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/ddbe652811def57093bddfa8b3fbe60496fee149..e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9 |
| ddbe652 | https://github.com/angular/angular/commit/ddbe652811def57093bddfa8b3fbe60496fee149 |
| e2c84c2 | https://github.com/angular/angular/commit/e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9 |
|
Compare
| https://github.com/angular/angular/compare/ddbe652811def57093bddfa8b3fbe60496fee149..e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9 |
| September 25, 2021 21:58 | https://github.com/angular/angular/pull/43591#event-5360299913 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-927187983 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| September 25, 2021 22:30 | https://github.com/angular/angular/pull/43591#event-5360330748 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| IgorMinar | https://github.com/IgorMinar |
| atscott | https://github.com/atscott |
| September 25, 2021 22:31 | https://github.com/angular/angular/pull/43591#event-5360330874 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Sep 25, 2021 | https://github.com/angular/angular/pull/43591#event-5360330944 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Sep 26, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-763701140 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files |
| packages/compiler-cli/test/ngc_spec.ts | https://github.com/angular/angular/pull/43591/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4 |
| JoostK | https://github.com/JoostK |
| Sep 26, 2021 | https://github.com/angular/angular/pull/43591#discussion_r716210430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| goldens/public-api/router/testing/testing.md | https://github.com/angular/angular/pull/43591/files#diff-77043dfb33df517a20e319fee2e4ff1d22d35ad2a7c003ada0092a1dcbf33923 |
| JoostK | https://github.com/JoostK |
| Sep 26, 2021 | https://github.com/angular/angular/pull/43591#discussion_r716210629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| atscott | https://github.com/atscott |
| Sep 29, 2021 | https://github.com/angular/angular/pull/43591#discussion_r718717383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| packages/compiler-cli/integrationtest/ngtools_src/feature2/feature2.module.ts | https://github.com/angular/angular/pull/43591/files#diff-147d83e7818d86ada1cd9091c28557dbe3945abc54a7ab47217e90aa562dd183 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
Sep 26, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-763715482 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files |
| aio/content/guide/deprecations.md | https://github.com/angular/angular/pull/43591/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| packages/core/src/linker/ng_module_factory_loader.ts | https://github.com/angular/angular/pull/43591/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 27, 2021
| https://github.com/angular/angular/pull/43591#ref-pullrequest-1006844817 |
|
test(router): refactor tests to not use deprecated loadChildren
#43578
| https://github.com/angular/angular/pull/43578 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9..ca967e46994971fc8417db2660cb0e2885497432 |
| e2c84c2 | https://github.com/angular/angular/commit/e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9 |
| ca967e4 | https://github.com/angular/angular/commit/ca967e46994971fc8417db2660cb0e2885497432 |
|
Compare
| https://github.com/angular/angular/compare/e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9..ca967e46994971fc8417db2660cb0e2885497432 |
| September 27, 2021 20:05 | https://github.com/angular/angular/pull/43591#event-5368024496 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Sep 27, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-928227758 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| jelbourn | https://github.com/jelbourn |
| jessicajaniuk | https://github.com/jessicajaniuk |
| petebacondarwin | https://github.com/petebacondarwin |
| zarend | https://github.com/zarend |
| September 29, 2021 19:55 | https://github.com/angular/angular/pull/43591#event-5383185667 |
| JoostK | https://github.com/JoostK |
| September 29, 2021 13:53 | https://github.com/angular/angular/pull/43591#commits-pushed-6320c00 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| docs: refactor example apps to use dynamic imports for loadChildren | https://github.com/angular/angular/pull/43591/commits/6320c0028e1267683d18543161b5e48b79b562f6 |
| 6320c00 | https://github.com/angular/angular/pull/43591/commits/6320c0028e1267683d18543161b5e48b79b562f6 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| refactor(router): remove support for loadChildren string syntax | https://github.com/angular/angular/pull/43591/commits/fb1d1c75ebdfe1bfa60f6a334976e2c07c2598b0 |
| fb1d1c7 | https://github.com/angular/angular/pull/43591/commits/fb1d1c75ebdfe1bfa60f6a334976e2c07c2598b0 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| fixup! refactor(router): remove support for loadChildren string syntax | https://github.com/angular/angular/pull/43591/commits/1a9c0e40107c0b9b83cf2b8b3f6b09b0913d5090 |
| 1a9c0e4 | https://github.com/angular/angular/pull/43591/commits/1a9c0e40107c0b9b83cf2b8b3f6b09b0913d5090 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| fixup! refactor(router): remove support for loadChildren string syntax | https://github.com/angular/angular/pull/43591/commits/2d16f74317dee0597129ad211c123006eda2cdf1 |
| 2d16f74 | https://github.com/angular/angular/pull/43591/commits/2d16f74317dee0597129ad211c123006eda2cdf1 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| fixup! refactor(router): remove support for loadChildren string syntax | https://github.com/angular/angular/pull/43591/commits/eafaa789c44db71d850ee08e5761640d6b38cd50 |
| eafaa78 | https://github.com/angular/angular/pull/43591/commits/eafaa789c44db71d850ee08e5761640d6b38cd50 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
| refactor(compiler-cli): remove listLazyRoutes operation | https://github.com/angular/angular/pull/43591/commits/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| 04fb369 | https://github.com/angular/angular/pull/43591/commits/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| force-pushed | https://github.com/angular/angular/compare/4e54706819f32306a5e0365cdbc4a8f1ae356388..04fb36924f6c181a1161dfeb69f0c88046303c04 |
| 4e54706 | https://github.com/angular/angular/commit/4e54706819f32306a5e0365cdbc4a8f1ae356388 |
| 04fb369 | https://github.com/angular/angular/commit/04fb36924f6c181a1161dfeb69f0c88046303c04 |
|
Compare
| https://github.com/angular/angular/compare/4e54706819f32306a5e0365cdbc4a8f1ae356388..04fb36924f6c181a1161dfeb69f0c88046303c04 |
| September 29, 2021 20:55 | https://github.com/angular/angular/pull/43591#event-5383472401 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Sep 29, 2021 | https://github.com/angular/angular/pull/43591#event-5383599926 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-767202853 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| alxhub | https://github.com/alxhub |
| https://github.com/angular/angular/pull/43591#pullrequestreview-767202853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-767208973 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/43591#pullrequestreview-767208973 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-767215151 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| jessicajaniuk | https://github.com/jessicajaniuk |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/angular/angular/pull/43591#pullrequestreview-767215151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| alxhub | https://github.com/alxhub |
| September 29, 2021 21:41 | https://github.com/angular/angular/pull/43591#event-5383672506 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| jelbourn | https://github.com/jelbourn |
| petebacondarwin | https://github.com/petebacondarwin |
| zarend | https://github.com/zarend |
| September 29, 2021 21:42 | https://github.com/angular/angular/pull/43591#event-5383675024 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#pullrequestreview-767216086 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Sep 29, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-930567715 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Sep 29, 2021 | https://github.com/angular/angular/pull/43591#event-5383684129 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 05c08ca | https://github.com/angular/angular/commit/05c08cac9a63a4acab34e5ed8eeed2716790307c |
| Sep 29, 2021 | https://github.com/angular/angular/pull/43591#event-5383687867 |
| alxhub | https://github.com/alxhub |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#ref-commit-361273f |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| refactor(router): remove support for | https://github.com/angular/angular/commit/361273fad5030c900c83d333a779f6edbe20c688 |
| loadChildren | https://github.com/angular/angular/commit/361273fad5030c900c83d333a779f6edbe20c688 |
| string syntax ( | https://github.com/angular/angular/commit/361273fad5030c900c83d333a779f6edbe20c688 |
| #4… | https://github.com/angular/angular/pull/43591 |
| 361273f | https://github.com/angular/angular/commit/361273fad5030c900c83d333a779f6edbe20c688 |
| …3591 | https://github.com/angular/angular/pull/43591 |
| #43591 | https://github.com/angular/angular/pull/43591 |
| alxhub | https://github.com/alxhub |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43591#ref-commit-94c6dee |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| refactor(compiler-cli): remove | https://github.com/angular/angular/commit/94c6dee708c7952487d6d7c9ba97c760e1285437 |
| listLazyRoutes | https://github.com/angular/angular/commit/94c6dee708c7952487d6d7c9ba97c760e1285437 |
| operation ( | https://github.com/angular/angular/commit/94c6dee708c7952487d6d7c9ba97c760e1285437 |
| #43591 | https://github.com/angular/angular/pull/43591 |
| ) | https://github.com/angular/angular/commit/94c6dee708c7952487d6d7c9ba97c760e1285437 |
| 94c6dee | https://github.com/angular/angular/commit/94c6dee708c7952487d6d7c9ba97c760e1285437 |
| #43591 | https://github.com/angular/angular/pull/43591 |
|
Remove System.import() usage in favor of import()
#21560
| https://github.com/angular/angular/issues/21560 |
|
Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error
#22700
| https://github.com/angular/angular/issues/22700 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 30, 2021 | https://github.com/angular/angular/pull/43591#issuecomment-955393998 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 30, 2021 | https://github.com/angular/angular/pull/43591#event-5544073567 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43591 |
|
| https://github.com/alan-agius4 |
|
alan-agius4
| https://github.com/alan-agius4 |
|
| https://github.com/angular/angular/pull/43591/files/b06937d7b9f1427bfaa34f9c3d15af8c647d214a |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
|
| https://github.com/dario-piotrowicz |
|
dario-piotrowicz
| https://github.com/dario-piotrowicz |
|
| https://github.com/angular/angular/pull/43591/files/e2c84c2e5f2fcc0fb473cb37cccd00b5737d90f9 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/43591/files/4e54706819f32306a5e0365cdbc4a8f1ae356388 |
|
| https://github.com/jessicajaniuk |
|
jessicajaniuk
| https://github.com/jessicajaniuk |
|
| https://github.com/angular/angular/pull/43591/files/04fb36924f6c181a1161dfeb69f0c88046303c04 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/43591 |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
|
| https://github.com/alxhub |
|
| https://github.com/IgorMinar |
|
| https://github.com/alan-agius4 |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com/jessicajaniuk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |