René's URL Explorer Experiment


Title: test(router): refactor tests to not use deprecated loadChildren by atscott · Pull Request #43578 · angular/angular · GitHub

Open Graph Title: test(router): refactor tests to not use deprecated loadChildren by atscott · Pull Request #43578 · angular/angular

X Title: test(router): refactor tests to not use deprecated loadChildren by atscott · Pull Request #43578 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Many of the tests in the router code use the deprecated loadChildren as a string. This has been deprecated for years and can easily be changed to just a function that returns the module.

X Description: Many of the tests in the router code use the deprecated loadChildren as a string. This has been deprecated for years and can easily be changed to just a function that returns the module.

Opengraph URL: https://github.com/angular/angular/pull/43578

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:da4301e9-1775-dd16-0d09-9769b4b1e5d5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB13E:358871:10EE88B:165B510:6B010E2B
html-safe-noncef1439aa03a6587bf8871e05a4f55221661e7d5cfeeaf8b8208a2d2151a561142
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTNFOjM1ODg3MToxMEVFODhCOjE2NUI1MTA6NkIwMTBFMkIiLCJ2aXNpdG9yX2lkIjoiNTc0OTEwNzczNDE1OTcyMzk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8b5dfea51738b2ca5215b8fd3c3e7a79b795122fae8f4b8245592efc12c72afc
hovercard-subject-tagpull_request:742522983
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/43578/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98cecbd1859dfb9ed286c30e732e2e26b8d32957a38c7b0054f0e44925ff4423/angular/angular/pull/43578
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98cecbd1859dfb9ed286c30e732e2e26b8d32957a38c7b0054f0e44925ff4423/angular/angular/pull/43578
og:image:altMany of the tests in the router code use the deprecated loadChildren as a string. This has been deprecated for years and can easily be changed to just a function that returns the module.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/43578#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43578
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43578
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43578
Reloadhttps://github.com/angular/angular/pull/43578
Reloadhttps://github.com/angular/angular/pull/43578
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:deprecatedloadchildrenhttps://github.com/atscott/angular/tree/deprecatedloadchildren
Conversationhttps://github.com/angular/angular/pull/43578
Commits2 (2)https://github.com/angular/angular/pull/43578/commits
Checkshttps://github.com/angular/angular/pull/43578/checks
Files changedhttps://github.com/angular/angular/pull/43578/files
test(router): refactor tests to not use deprecated loadChildrenhttps://github.com/angular/angular/pull/43578#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:deprecatedloadchildrenhttps://github.com/atscott/angular/tree/deprecatedloadchildren
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 24, 2021https://github.com/angular/angular/pull/43578#issue-1006844817
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/atscott
atscotthttps://github.com/atscott
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Sep 24, 2021https://github.com/angular/angular/pull/43578#event-5358491813
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 24, 2021https://github.com/angular/angular/pull/43578#event-5358492063
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
Sep 24, 2021 https://github.com/angular/angular/pull/43578#pullrequestreview-763494908
View reviewed changes https://github.com/angular/angular/pull/43578/files
packages/router/test/apply_redirects.spec.tshttps://github.com/angular/angular/pull/43578/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/64c65793076c03beab0395e107743d69db0b0372..c3d062893d5fbf081dd96c74db05d583b1cb3593
64c6579https://github.com/angular/angular/commit/64c65793076c03beab0395e107743d69db0b0372
c3d0628https://github.com/angular/angular/commit/c3d062893d5fbf081dd96c74db05d583b1cb3593
Compare https://github.com/angular/angular/compare/64c65793076c03beab0395e107743d69db0b0372..c3d062893d5fbf081dd96c74db05d583b1cb3593
September 24, 2021 21:47https://github.com/angular/angular/pull/43578#event-5358508014
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
IgorMinarhttps://github.com/IgorMinar
September 24, 2021 21:47https://github.com/angular/angular/pull/43578#event-5358508464
https://github.com/atscott
test(router): refactor tests to not use deprecated loadChildrenhttps://github.com/angular/angular/pull/43578/commits/99e12eea67fa2d5c9bd44120dda255867c335a88
99e12eehttps://github.com/angular/angular/pull/43578/commits/99e12eea67fa2d5c9bd44120dda255867c335a88
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/c3d062893d5fbf081dd96c74db05d583b1cb3593..99e12eea67fa2d5c9bd44120dda255867c335a88
c3d0628https://github.com/angular/angular/commit/c3d062893d5fbf081dd96c74db05d583b1cb3593
99e12eehttps://github.com/angular/angular/commit/99e12eea67fa2d5c9bd44120dda255867c335a88
Compare https://github.com/angular/angular/compare/c3d062893d5fbf081dd96c74db05d583b1cb3593..99e12eea67fa2d5c9bd44120dda255867c335a88
September 24, 2021 22:01https://github.com/angular/angular/pull/43578#event-5358547352
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Sep 24, 2021https://github.com/angular/angular/pull/43578#event-5358547573
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Sep 24, 2021https://github.com/angular/angular/pull/43578#event-5358547645
https://github.com/atscott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43578
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 27, 2021https://github.com/angular/angular/pull/43578#event-5367089559
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 27, 2021https://github.com/angular/angular/pull/43578#event-5367092509
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Sep 27, 2021https://github.com/angular/angular/pull/43578#event-5367121636
https://github.com/JoostK
JoostKhttps://github.com/JoostK
September 27, 2021 17:11https://github.com/angular/angular/pull/43578#event-5367122110
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Sep 27, 2021 https://github.com/angular/angular/pull/43578#pullrequestreview-764576263
View reviewed changes https://github.com/angular/angular/pull/43578/files/99e12eea67fa2d5c9bd44120dda255867c335a88
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/43578/files/99e12eea67fa2d5c9bd44120dda255867c335a88#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
Please reload this pagehttps://github.com/angular/angular/pull/43578
packages/router/test/router_preloader.spec.tshttps://github.com/angular/angular/pull/43578/files/99e12eea67fa2d5c9bd44120dda255867c335a88#diff-c7ff7195767c10ac50aa3d604c0f8f9df597be1a3df91eaac1573bc7a082eaa9
Please reload this pagehttps://github.com/angular/angular/pull/43578
packages/router/test/router_preloader.spec.tshttps://github.com/angular/angular/pull/43578/files/99e12eea67fa2d5c9bd44120dda255867c335a88#diff-c7ff7195767c10ac50aa3d604c0f8f9df597be1a3df91eaac1573bc7a082eaa9
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Sep 27, 2021https://github.com/angular/angular/pull/43578#event-5367803204
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Sep 27, 2021https://github.com/angular/angular/pull/43578#issuecomment-928198127
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/atscott
atscotthttps://github.com/atscott
IgorMinarhttps://github.com/IgorMinar
September 27, 2021 19:20https://github.com/angular/angular/pull/43578#event-5367803614
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
IgorMinarhttps://github.com/IgorMinar
September 27, 2021 19:20https://github.com/angular/angular/pull/43578#event-5367804189
https://github.com/atscott
fixup! test(router): refactor tests to not use deprecated loadChildrenhttps://github.com/angular/angular/pull/43578/commits/82c9f0396e92cb8a3b7249f2665164dfea625ae4
82c9f03https://github.com/angular/angular/pull/43578/commits/82c9f0396e92cb8a3b7249f2665164dfea625ae4
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/2b8a32b388a2dd5480843e136d75742009c3e340..82c9f0396e92cb8a3b7249f2665164dfea625ae4
2b8a32bhttps://github.com/angular/angular/commit/2b8a32b388a2dd5480843e136d75742009c3e340
82c9f03https://github.com/angular/angular/commit/82c9f0396e92cb8a3b7249f2665164dfea625ae4
Compare https://github.com/angular/angular/compare/2b8a32b388a2dd5480843e136d75742009c3e340..82c9f0396e92cb8a3b7249f2665164dfea625ae4
September 27, 2021 19:55https://github.com/angular/angular/pull/43578#event-5367970770
https://github.com/atscott
atscotthttps://github.com/atscott
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Sep 29, 2021https://github.com/angular/angular/pull/43578#event-5382317944
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 29, 2021https://github.com/angular/angular/pull/43578#issuecomment-930373296
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Sep 29, 2021 https://github.com/angular/angular/pull/43578#pullrequestreview-767035426
View reviewed changes https://github.com/angular/angular/pull/43578/files/82c9f0396e92cb8a3b7249f2665164dfea625ae4
alxhubhttps://github.com/alxhub
https://github.com/angular/angular/pull/43578#pullrequestreview-767035426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/alxhub
alxhubhttps://github.com/alxhub
IgorMinarhttps://github.com/IgorMinar
September 29, 2021 18:13https://github.com/angular/angular/pull/43578#event-5382683159
alxhubhttps://github.com/alxhub
Sep 29, 2021 https://github.com/angular/angular/pull/43578#ref-commit-ca0f057
https://github.com/atscott
https://github.com/alxhub
test(router): refactor tests to not use deprecated loadChildren (https://github.com/angular/angular/commit/ca0f0574916d90520778a59b75d483f1a9c70add
#43578https://github.com/angular/angular/pull/43578
)https://github.com/angular/angular/commit/ca0f0574916d90520778a59b75d483f1a9c70add
ca0f057https://github.com/angular/angular/commit/ca0f0574916d90520778a59b75d483f1a9c70add
#43578https://github.com/angular/angular/pull/43578
https://github.com/alxhub
alxhubhttps://github.com/alxhub
09d325ahttps://github.com/angular/angular/commit/09d325a9e6891ae3831166a16688b9648033ffd0
Sep 29, 2021https://github.com/angular/angular/pull/43578#event-5382689634
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 30, 2021https://github.com/angular/angular/pull/43578#issuecomment-955393904
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 30, 2021https://github.com/angular/angular/pull/43578#event-5544073498
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43578
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/43578/files/99e12eea67fa2d5c9bd44120dda255867c335a88
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/43578/files/82c9f0396e92cb8a3b7249f2665164dfea625ae4
https://github.com/dario-piotrowicz
dario-piotrowicz https://github.com/dario-piotrowicz
https://github.com/angular/angular/pull/43578/files/64c65793076c03beab0395e107743d69db0b0372
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/JoostK
JoostK https://github.com/JoostK
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/43578
https://github.com/atscott
https://github.com/JoostK
https://github.com/alxhub
https://github.com/dario-piotrowicz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.