| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f242b454-56fb-3681-2d0d-bcedb2029442 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7B0:2AAD2E:FA24A1:14E9FA6:6B0111B7 |
| html-safe-nonce | 25e46d97ef057984b19c93ca9616f4370d2c5f24d5158e1ed7e40c045cf145ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0IwOjJBQUQyRTpGQTI0QTE6MTRFOUZBNjo2QjAxMTFCNyIsInZpc2l0b3JfaWQiOiI3NzU5NTk4MzMyMTkyNDAzNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 32e85171671f3fd5dee4b3b5518655bb6d0db77a0b538dfc57341b577b5cbe9d |
| hovercard-subject-tag | pull_request:742514611 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/43575/files |
| twitter:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| og:image:alt | This commit removes the ability to configure lazy routes using a string
for loadChildren, together with the NgModule loader implementation
based on SystemJS from @angular/core.
BREAKING CHANGE:
It ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/43575/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/43575/files |
| Reload | https://github.com/angular/angular/pull/43575/files |
| Reload | https://github.com/angular/angular/pull/43575/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:remove-loadchildren-string | https://github.com/JoostK/angular/tree/remove-loadchildren-string |
|
Conversation
5
| https://github.com/angular/angular/pull/43575 |
|
Commits
2
| https://github.com/angular/angular/pull/43575/commits |
|
Checks
0
| https://github.com/angular/angular/pull/43575/checks |
|
Files changed
| https://github.com/angular/angular/pull/43575/files |
| Please reload this page | https://github.com/angular/angular/pull/43575/files |
|
refactor(router): remove runtime support for loadChildren string syntax
| https://github.com/angular/angular/pull/43575/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/43575/files |
|
0c581fc
refactor(router): remove runtime support for `loadChildren` string sy…
JoostK Sep 24, 2021
| https://github.com/angular/angular/pull/43575/commits/0c581fc1dd42445cb2e15b2b031abbc15f4dc46f |
|
dfd2cb0
fixup! refactor(router): remove runtime support for `loadChildren` st…
JoostK Sep 29, 2021
| https://github.com/angular/angular/pull/43575/commits/dfd2cb0931bb40ff9c338987c758db1355b85640 |
|
Clear filters
| https://github.com/angular/angular/pull/43575/files |
| Please reload this page | https://github.com/angular/angular/pull/43575/files |
| Please reload this page | https://github.com/angular/angular/pull/43575/files |
|
deprecations.md
| https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
|
core.md
| https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521 |
|
router.md
| https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8 |
|
linker.ts
| https://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33 |
|
ng_module_factory_loader.ts
| https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582 |
|
system_js_ng_module_factory_loader.ts
| https://github.com/angular/angular/pull/43575/files#diff-b357b4fb06b4335a305c541afddfe3bb03c320fc66d6ec1386dc5fce5a29555e |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
system_ng_module_factory_loader_spec.ts
| https://github.com/angular/angular/pull/43575/files#diff-4f0904a92342fe7d3ef20eee73e6920c82c580382b3d3a7f9d724aa0c77a843b |
|
router_module.ts
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
integration.spec.ts
| https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
| aio/content/guide/deprecations.md | https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/aio/content/guide/deprecations.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
|
| https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
|
| https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
|
| https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144 |
| goldens/public-api/core/core.md | https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/goldens/public-api/core/core.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521 |
|
| https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521 |
| goldens/public-api/router/router.md | https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/goldens/public-api/router/router.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8 |
|
| https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8 |
| packages/core/src/linker.ts | https://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/src/linker.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33 |
| packages/core/src/linker/ng_module_factory_loader.ts | https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/src/linker/ng_module_factory_loader.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582 |
|
| https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582 |
| packages/core/src/linker/system_js_ng_module_factory_loader.ts | https://github.com/angular/angular/pull/43575/files#diff-b357b4fb06b4335a305c541afddfe3bb03c320fc66d6ec1386dc5fce5a29555e |
|
View file
| https://github.com/angular/angular/blob/4555d8a31625564d457b93113ce8c71a24bdd472/packages/core/src/linker/system_js_ng_module_factory_loader.ts |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/angular/angular/pull/43575/files |
| packages/core/test/bundling/router/bundle.golden_symbols.json | https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/test/bundling/router/bundle.golden_symbols.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
| packages/core/test/linker/system_ng_module_factory_loader_spec.ts | https://github.com/angular/angular/pull/43575/files#diff-4f0904a92342fe7d3ef20eee73e6920c82c580382b3d3a7f9d724aa0c77a843b |
|
View file
| https://github.com/angular/angular/blob/4555d8a31625564d457b93113ce8c71a24bdd472/packages/core/test/linker/system_ng_module_factory_loader_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/angular/angular/pull/43575/files |
| packages/router/src/router_module.ts | https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/router/src/router_module.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
|
| https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
| packages/router/test/integration.spec.ts | https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
|
View file
| https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/router/test/integration.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43575/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
|
| https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |