René's URL Explorer Experiment


Title: refactor(router): remove runtime support for `loadChildren` string syntax by JoostK · Pull Request #43575 · angular/angular · GitHub

Open Graph Title: refactor(router): remove runtime support for `loadChildren` string syntax by JoostK · Pull Request #43575 · angular/angular

X Title: refactor(router): remove runtime support for `loadChildren` string syntax by JoostK · Pull Request #43575 · angular/angular

Description: This commit removes the ability to configure lazy routes using a string for loadChildren, together with the NgModule loader implementation based on SystemJS from @angular/core. BREAKING CHANGE: It is no longer possible to use Route.loadChildren using a string value, as the runtime support for loading the corresponding NgModule has been removed from @angular/core.

Open Graph Description: This commit removes the ability to configure lazy routes using a string for loadChildren, together with the NgModule loader implementation based on SystemJS from @angular/core. BREAKING CHANGE: It ...

X Description: This commit removes the ability to configure lazy routes using a string for loadChildren, together with the NgModule loader implementation based on SystemJS from @angular/core. BREAKING CHANGE: It ...

Opengraph URL: https://github.com/angular/angular/pull/43575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f242b454-56fb-3681-2d0d-bcedb2029442
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7B0:2AAD2E:FA24A1:14E9FA6:6B0111B7
html-safe-nonce25e46d97ef057984b19c93ca9616f4370d2c5f24d5158e1ed7e40c045cf145ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0IwOjJBQUQyRTpGQTI0QTE6MTRFOUZBNjo2QjAxMTFCNyIsInZpc2l0b3JfaWQiOiI3NzU5NTk4MzMyMTkyNDAzNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac32e85171671f3fd5dee4b3b5518655bb6d0db77a0b538dfc57341b577b5cbe9d
hovercard-subject-tagpull_request:742514611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43575/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altThis commit removes the ability to configure lazy routes using a string for loadChildren, together with the NgModule loader implementation based on SystemJS from @angular/core. BREAKING CHANGE: It ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/43575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43575/files
Reloadhttps://github.com/angular/angular/pull/43575/files
Reloadhttps://github.com/angular/angular/pull/43575/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:remove-loadchildren-stringhttps://github.com/JoostK/angular/tree/remove-loadchildren-string
Conversation 5 https://github.com/angular/angular/pull/43575
Commits 2 https://github.com/angular/angular/pull/43575/commits
Checks 0 https://github.com/angular/angular/pull/43575/checks
Files changed https://github.com/angular/angular/pull/43575/files
Please reload this pagehttps://github.com/angular/angular/pull/43575/files
refactor(router): remove runtime support for loadChildren string syntax https://github.com/angular/angular/pull/43575/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/43575/files
0c581fc refactor(router): remove runtime support for `loadChildren` string sy… JoostK Sep 24, 2021 https://github.com/angular/angular/pull/43575/commits/0c581fc1dd42445cb2e15b2b031abbc15f4dc46f
dfd2cb0 fixup! refactor(router): remove runtime support for `loadChildren` st… JoostK Sep 29, 2021 https://github.com/angular/angular/pull/43575/commits/dfd2cb0931bb40ff9c338987c758db1355b85640
Clear filters https://github.com/angular/angular/pull/43575/files
Please reload this pagehttps://github.com/angular/angular/pull/43575/files
Please reload this pagehttps://github.com/angular/angular/pull/43575/files
deprecations.md https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
core.md https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521
router.md https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8
linker.ts https://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33
ng_module_factory_loader.ts https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582
system_js_ng_module_factory_loader.ts https://github.com/angular/angular/pull/43575/files#diff-b357b4fb06b4335a305c541afddfe3bb03c320fc66d6ec1386dc5fce5a29555e
bundle.golden_symbols.json https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
system_ng_module_factory_loader_spec.ts https://github.com/angular/angular/pull/43575/files#diff-4f0904a92342fe7d3ef20eee73e6920c82c580382b3d3a7f9d724aa0c77a843b
router_module.ts https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
integration.spec.ts https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
aio/content/guide/deprecations.mdhttps://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/aio/content/guide/deprecations.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
https://github.com/angular/angular/pull/43575/files#diff-4ff19c968abd0983250c5a2a7ccf1c261b2a29a012da89844d06fd5b186ef144
goldens/public-api/core/core.mdhttps://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/goldens/public-api/core/core.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521
https://github.com/angular/angular/pull/43575/files#diff-afde1b7c340d69d1fac2e2e507e6041751e7a36b9c3df657a8dc24ab8bbd1521
goldens/public-api/router/router.mdhttps://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/goldens/public-api/router/router.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8
https://github.com/angular/angular/pull/43575/files#diff-dc8d11f92837e46858d45b618dd3f4b151e6f3ef7c7a5b8f5da3a2cfa058afe8
packages/core/src/linker.tshttps://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/src/linker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-0a11d9353d9c6dca1c264237ddd2b51963add61c378b1cb200e1bb212e25ea33
packages/core/src/linker/ng_module_factory_loader.tshttps://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/src/linker/ng_module_factory_loader.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582
https://github.com/angular/angular/pull/43575/files#diff-c759afb4081a43125df0fd7fd724c0717a50a9210a684c85d7210877a5b37582
packages/core/src/linker/system_js_ng_module_factory_loader.tshttps://github.com/angular/angular/pull/43575/files#diff-b357b4fb06b4335a305c541afddfe3bb03c320fc66d6ec1386dc5fce5a29555e
View file https://github.com/angular/angular/blob/4555d8a31625564d457b93113ce8c71a24bdd472/packages/core/src/linker/system_js_ng_module_factory_loader.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/43575/files
packages/core/test/bundling/router/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/core/test/bundling/router/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/43575/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
packages/core/test/linker/system_ng_module_factory_loader_spec.tshttps://github.com/angular/angular/pull/43575/files#diff-4f0904a92342fe7d3ef20eee73e6920c82c580382b3d3a7f9d724aa0c77a843b
View file https://github.com/angular/angular/blob/4555d8a31625564d457b93113ce8c71a24bdd472/packages/core/test/linker/system_ng_module_factory_loader_spec.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/43575/files
packages/router/src/router_module.tshttps://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/router/src/router_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
View file https://github.com/JoostK/angular/blob/dfd2cb0931bb40ff9c338987c758db1355b85640/packages/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/43575/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.