| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:111518b7-1907-1e2c-6f81-b827974afef5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC80:E9D16:5267EC:67F169:6B010E07 |
| html-safe-nonce | f29d2e4fe8e5893a1f15a806590b9db297eb6b00d7e6dff59d4bfecfa272551c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzgwOkU5RDE2OjUyNjdFQzo2N0YxNjk6NkIwMTBFMDciLCJ2aXNpdG9yX2lkIjoiNTQyODE5NDQ5MTg1OTI3NTI3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7ce0a009f46181836dbdb7b1bbd3dedfe91f5624f7aeab3b408d7bc2f770adf3 |
| hovercard-subject-tag | pull_request:742514611 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/43575/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/719351c530067f01759c336451fec286326a3ae2df886482ffb21f14fc6c0823/angular/angular/pull/43575 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/719351c530067f01759c336451fec286326a3ae2df886482ffb21f14fc6c0823/angular/angular/pull/43575 |
| og:image:alt | This commit removes the ability to configure lazy routes using a string
for loadChildren, together with the NgModule loader implementation
based on SystemJS from @angular/core.
BREAKING CHANGE:
It ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoostK |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/43575#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/43575 |
| Reload | https://github.com/angular/angular/pull/43575 |
| Reload | https://github.com/angular/angular/pull/43575 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:remove-loadchildren-string | https://github.com/JoostK/angular/tree/remove-loadchildren-string |
| Conversation | https://github.com/angular/angular/pull/43575 |
| Commits2 (2) | https://github.com/angular/angular/pull/43575/commits |
| Checks | https://github.com/angular/angular/pull/43575/checks |
| Files changed | https://github.com/angular/angular/pull/43575/files |
| refactor(router): remove runtime support for loadChildren string syntax | https://github.com/angular/angular/pull/43575#top |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:remove-loadchildren-string | https://github.com/JoostK/angular/tree/remove-loadchildren-string |
|
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#issue-1006834552 |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#event-5358425860 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#event-5358426095 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#event-5358426104 |
| https://github.com/apps/angular-robot |
| angular-robot | https://github.com/apps/angular-robot |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#event-5358426888 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Sep 24, 2021
| https://github.com/angular/angular/pull/43575#pullrequestreview-763531165 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43575/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/43575#pullrequestreview-763531165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| packages/router/src/router_module.ts | https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
| IgorMinar | https://github.com/IgorMinar |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#discussion_r715951362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| packages/router/src/router_module.ts | https://github.com/angular/angular/pull/43575/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
| IgorMinar | https://github.com/IgorMinar |
| Sep 24, 2021 | https://github.com/angular/angular/pull/43575#discussion_r715951453 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Sep 25, 2021
| https://github.com/angular/angular/pull/43575#ref-pullrequest-1007182734 |
|
refactor(router): remove support for loadChildren string syntax
#43591
| https://github.com/angular/angular/pull/43591 |
| JoostK | https://github.com/JoostK |
| September 29, 2021 08:26 | https://github.com/angular/angular/pull/43575#commits-pushed-0c581fc |
|
| https://github.com/JoostK |
| refactor(router): remove runtime support for loadChildren string sy… | https://github.com/angular/angular/pull/43575/commits/0c581fc1dd42445cb2e15b2b031abbc15f4dc46f |
| 0c581fc | https://github.com/angular/angular/pull/43575/commits/0c581fc1dd42445cb2e15b2b031abbc15f4dc46f |
|
| https://github.com/JoostK |
| fixup! refactor(router): remove runtime support for loadChildren st… | https://github.com/angular/angular/pull/43575/commits/dfd2cb0931bb40ff9c338987c758db1355b85640 |
| dfd2cb0 | https://github.com/angular/angular/pull/43575/commits/dfd2cb0931bb40ff9c338987c758db1355b85640 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/a8dd45fe2a39f34173ec1ee74242fa8761f7a64a..dfd2cb0931bb40ff9c338987c758db1355b85640 |
| a8dd45f | https://github.com/angular/angular/commit/a8dd45fe2a39f34173ec1ee74242fa8761f7a64a |
| dfd2cb0 | https://github.com/angular/angular/commit/dfd2cb0931bb40ff9c338987c758db1355b85640 |
|
Compare
| https://github.com/angular/angular/compare/a8dd45fe2a39f34173ec1ee74242fa8761f7a64a..dfd2cb0931bb40ff9c338987c758db1355b85640 |
| September 29, 2021 06:28 | https://github.com/angular/angular/pull/43575#event-5378337252 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| September 29, 2021 19:55 | https://github.com/angular/angular/pull/43575#event-5383188742 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Sep 29, 2021
| https://github.com/angular/angular/pull/43575#pullrequestreview-767128669 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43575/files/dfd2cb0931bb40ff9c338987c758db1355b85640 |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/43575#pullrequestreview-767128669 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #43591 | https://github.com/angular/angular/pull/43591 |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Sep 30, 2021 | https://github.com/angular/angular/pull/43575#event-5385200732 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 31, 2021 | https://github.com/angular/angular/pull/43575#issuecomment-955741708 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 31, 2021 | https://github.com/angular/angular/pull/43575#event-5545407213 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43575 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/43575/files/dfd2cb0931bb40ff9c338987c758db1355b85640 |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/43575 |
|
| https://github.com/JoostK |
|
| https://github.com/IgorMinar |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |