René's URL Explorer Experiment


Title: fix(upgrade): Do not trigger duplicate navigation events from Angular… by atscott · Pull Request #43441 · angular/angular · GitHub

Open Graph Title: fix(upgrade): Do not trigger duplicate navigation events from Angular… by atscott · Pull Request #43441 · angular/angular

X Title: fix(upgrade): Do not trigger duplicate navigation events from Angular… by atscott · Pull Request #43441 · angular/angular

Description: … Router This code mimics behavior that Google Analytics has been using to prevent duplicate navigations. They set up their own HybridRoutingService location sync to avoid duplicate navigations that came from the Angular router. This would happen because the Angular router would trigger a navigation, which would then get picked up by the $locationShim, which would trigger a $locationChangeStart, which would then be picked up by the setUpLocationSync watcher here, which would again trigger a navigation in the Angular Router. All of this can be prevented by checking if the navigationId exists on the history state object. This property is added by the Angular router during navigations. fixes #21610

Open Graph Description: … Router This code mimics behavior that Google Analytics has been using to prevent duplicate navigations. They set up their own HybridRoutingService location sync to avoid duplicate navigations tha...

X Description: … Router This code mimics behavior that Google Analytics has been using to prevent duplicate navigations. They set up their own HybridRoutingService location sync to avoid duplicate navigations tha...

Opengraph URL: https://github.com/angular/angular/pull/43441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0526e73c-1b9d-e35c-77bc-b8ff595ece14
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB060:7A60E:1D3365A:256CE6E:6B01532E
html-safe-nonce20b66869bc7ac01c01454f8359cd3da7faee370859619d76f9858fa66951087c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDYwOjdBNjBFOjFEMzM2NUE6MjU2Q0U2RTo2QjAxNTMyRSIsInZpc2l0b3JfaWQiOiI0MjQyNTUwMTAzODcwNjI0NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac60ea18a3bcf8a1057f985545610fd4aa79f3382c0d1e88668098cfde3e320854
hovercard-subject-tagpull_request:733191268
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43441/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:alt… Router This code mimics behavior that Google Analytics has been using to prevent duplicate navigations. They set up their own HybridRoutingService location sync to avoid duplicate navigations tha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/43441/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43441%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43441%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43441/files
Reloadhttps://github.com/angular/angular/pull/43441/files
Reloadhttps://github.com/angular/angular/pull/43441/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:duplicateUpgradeNavhttps://github.com/atscott/angular/tree/duplicateUpgradeNav
Conversation 14 https://github.com/angular/angular/pull/43441
Commits 5 https://github.com/angular/angular/pull/43441/commits
Checks 0 https://github.com/angular/angular/pull/43441/checks
Files changed https://github.com/angular/angular/pull/43441/files
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
fix(upgrade): Do not trigger duplicate navigation events from Angular… https://github.com/angular/angular/pull/43441/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/43441/files
9e09ad1 test(upgrade): update router upgrade tests to use fewer mocks atscott Oct 15, 2021 https://github.com/angular/angular/pull/43441/commits/9e09ad1d3556b1366ee6c3b45eafa25a0cf7601e
49128a8 fix(upgrade): Do not trigger duplicate navigation events from Angular… atscott Oct 15, 2021 https://github.com/angular/angular/pull/43441/commits/49128a8b49ad26e5c3eee1f4610c0d4f0a85aa1a
9be7240 fixup! test(upgrade): update router upgrade tests to use fewer mocks atscott Oct 18, 2021 https://github.com/angular/angular/pull/43441/commits/9be7240489b62c1b3017e70f821bcf2fd71002b4
d12ddf3 fixup! fix(upgrade): Do not trigger duplicate navigation events from … atscott Feb 1, 2022 https://github.com/angular/angular/pull/43441/commits/d12ddf3d8b11c0c8f09a0c4f6d7786063092059c
8ec981c fixup! fix(upgrade): Do not trigger duplicate navigation events from … atscott Feb 1, 2022 https://github.com/angular/angular/pull/43441/commits/8ec981c0195cf9268c966f79a7504f1a16323e60
Clear filters https://github.com/angular/angular/pull/43441/files
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
private_export.ts https://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d
upgrade.ts https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
BUILD.bazel https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
upgrade.spec.ts https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
upgrade_location_test_module.ts https://github.com/angular/angular/pull/43441/files#diff-28e5896c725dbe1aa7ba93690c915ec2dce722819b20b1847a87fbea6f4527d9
packages/router/src/private_export.tshttps://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d
View file https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/src/private_export.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43441/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d
packages/router/upgrade/src/upgrade.tshttps://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
View file https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/src/upgrade.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43441/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
packages/router/upgrade/test/BUILD.bazelhttps://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
View file https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43441/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
packages/router/upgrade/test/upgrade.spec.tshttps://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
View file https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/upgrade.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43441/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
packages/router/upgrade/test/upgrade_location_test_module.tshttps://github.com/angular/angular/pull/43441/files#diff-28e5896c725dbe1aa7ba93690c915ec2dce722819b20b1847a87fbea6f4527d9
View file https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/upgrade_location_test_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43441/{{ revealButtonHref }}
gkalpakhttps://github.com/gkalpak
Oct 16, 2021https://github.com/angular/angular/pull/43441/files#r730258927
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
atscotthttps://github.com/atscott
Oct 18, 2021https://github.com/angular/angular/pull/43441/files#r731152227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43441/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.