| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0526e73c-1b9d-e35c-77bc-b8ff595ece14 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B060:7A60E:1D3365A:256CE6E:6B01532E |
| html-safe-nonce | 20b66869bc7ac01c01454f8359cd3da7faee370859619d76f9858fa66951087c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDYwOjdBNjBFOjFEMzM2NUE6MjU2Q0U2RTo2QjAxNTMyRSIsInZpc2l0b3JfaWQiOiI0MjQyNTUwMTAzODcwNjI0NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 60ea18a3bcf8a1057f985545610fd4aa79f3382c0d1e88668098cfde3e320854 |
| hovercard-subject-tag | pull_request:733191268 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/43441/files |
| twitter:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| og:image:alt | … Router
This code mimics behavior that Google Analytics has been using to
prevent duplicate navigations. They set up their own HybridRoutingService
location sync to avoid duplicate navigations tha... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/43441/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43441%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43441%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/43441/files |
| Reload | https://github.com/angular/angular/pull/43441/files |
| Reload | https://github.com/angular/angular/pull/43441/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| atscott | https://github.com/atscott |
| angular:master | https://github.com/angular/angular/tree/master |
| atscott:duplicateUpgradeNav | https://github.com/atscott/angular/tree/duplicateUpgradeNav |
|
Conversation
14
| https://github.com/angular/angular/pull/43441 |
|
Commits
5
| https://github.com/angular/angular/pull/43441/commits |
|
Checks
0
| https://github.com/angular/angular/pull/43441/checks |
|
Files changed
| https://github.com/angular/angular/pull/43441/files |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
|
fix(upgrade): Do not trigger duplicate navigation events from Angular…
| https://github.com/angular/angular/pull/43441/files#top |
|
Show all changes
5 commits
| https://github.com/angular/angular/pull/43441/files |
|
9e09ad1
test(upgrade): update router upgrade tests to use fewer mocks
atscott Oct 15, 2021
| https://github.com/angular/angular/pull/43441/commits/9e09ad1d3556b1366ee6c3b45eafa25a0cf7601e |
|
49128a8
fix(upgrade): Do not trigger duplicate navigation events from Angular…
atscott Oct 15, 2021
| https://github.com/angular/angular/pull/43441/commits/49128a8b49ad26e5c3eee1f4610c0d4f0a85aa1a |
|
9be7240
fixup! test(upgrade): update router upgrade tests to use fewer mocks
atscott Oct 18, 2021
| https://github.com/angular/angular/pull/43441/commits/9be7240489b62c1b3017e70f821bcf2fd71002b4 |
|
d12ddf3
fixup! fix(upgrade): Do not trigger duplicate navigation events from …
atscott Feb 1, 2022
| https://github.com/angular/angular/pull/43441/commits/d12ddf3d8b11c0c8f09a0c4f6d7786063092059c |
|
8ec981c
fixup! fix(upgrade): Do not trigger duplicate navigation events from …
atscott Feb 1, 2022
| https://github.com/angular/angular/pull/43441/commits/8ec981c0195cf9268c966f79a7504f1a16323e60 |
|
Clear filters
| https://github.com/angular/angular/pull/43441/files |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
|
private_export.ts
| https://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d |
|
upgrade.ts
| https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
|
BUILD.bazel
| https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405 |
|
upgrade.spec.ts
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
upgrade_location_test_module.ts
| https://github.com/angular/angular/pull/43441/files#diff-28e5896c725dbe1aa7ba93690c915ec2dce722819b20b1847a87fbea6f4527d9 |
| packages/router/src/private_export.ts | https://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d |
|
View file
| https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/src/private_export.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43441/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43441/files#diff-ef42e6dae9a7953af6c74fa0a31ef42b89b047d2cccc6e99f67d74649cde6c1d |
| packages/router/upgrade/src/upgrade.ts | https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
|
View file
| https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/src/upgrade.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43441/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
|
| https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
|
| https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
|
| https://github.com/angular/angular/pull/43441/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
| packages/router/upgrade/test/BUILD.bazel | https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405 |
|
View file
| https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/BUILD.bazel |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43441/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405 |
|
| https://github.com/angular/angular/pull/43441/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405 |
| packages/router/upgrade/test/upgrade.spec.ts | https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
View file
| https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/upgrade.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43441/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
|
| https://github.com/angular/angular/pull/43441/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
| packages/router/upgrade/test/upgrade_location_test_module.ts | https://github.com/angular/angular/pull/43441/files#diff-28e5896c725dbe1aa7ba93690c915ec2dce722819b20b1847a87fbea6f4527d9 |
|
View file
| https://github.com/atscott/angular/blob/8ec981c0195cf9268c966f79a7504f1a16323e60/packages/router/upgrade/test/upgrade_location_test_module.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/43441/{{ revealButtonHref }} |
| gkalpak | https://github.com/gkalpak |
| Oct 16, 2021 | https://github.com/angular/angular/pull/43441/files#r730258927 |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
| atscott | https://github.com/atscott |
| Oct 18, 2021 | https://github.com/angular/angular/pull/43441/files#r731152227 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43441/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |