René's URL Explorer Experiment


Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular · GitHub

Open Graph Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular

X Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular

Description: With the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrectly mocked test behavior. This change updates the logic in the Router to only trigger navigations on popstate events. Since our SpyLocation now triggers the popstate event correctly on simulateHashChange, back, forward, and simulatePopState, we are able to rely on this being true for all of these navigations in tests when using SpyLocation (the default for RouterTestingModule). In addition, this behavior relies on documented browser behavior: The popstate event happens due to browser transitions as a result of user triggered "back" button or otherwise. https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent In addition, this change chooses popstate over hashchange because it is the event that is already being used for navigations since the documented behavior of browsers is that popstate happens before hashchange. fixes #41782 reviewer note: this is marked as major because #41730 was merged as a breaking change to the major branch. green global presubmit train

Open Graph Description: With the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...

X Description: With the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...

Opengraph URL: https://github.com/angular/angular/pull/43328

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fbbcc0a1-1bc6-610d-f298-d689cd35b3de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD186:6365:DB59E3:1257D86:6B0104A5
html-safe-nonce6bac81bd7d5005920b0f865365028847bc050272e620c75894de866304547a61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTg2OjYzNjU6REI1OUUzOjEyNTdEODY6NkIwMTA0QTUiLCJ2aXNpdG9yX2lkIjoiNDc0NzgwOTgyNDY0MzgxMDQ2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca2831697fccc6e0c6b28e5596211026c1ff4585a0a1a7f6f6a24d1eaef54ad4f
hovercard-subject-tagpull_request:726270362
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43328/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altWith the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/43328/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43328/files
Reloadhttps://github.com/angular/angular/pull/43328/files
Reloadhttps://github.com/angular/angular/pull/43328/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:simplifyRouterLocationListenerhttps://github.com/atscott/angular/tree/simplifyRouterLocationListener
Conversation 3 https://github.com/angular/angular/pull/43328
Commits 1 https://github.com/angular/angular/pull/43328/commits
Checks 0 https://github.com/angular/angular/pull/43328/checks
Files changed https://github.com/angular/angular/pull/43328/files
Please reload this pagehttps://github.com/angular/angular/pull/43328/files
fix(router): Only trigger router navigation on popstate events from Location subscription https://github.com/angular/angular/pull/43328/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/43328/files
8707675 fix(router): Only trigger router navigation on `popstate` events from… atscott Sep 2, 2021 https://github.com/angular/angular/pull/43328/commits/870767502f6583b018a8b7eb24880f84891d9e23
Clear filters https://github.com/angular/angular/pull/43328/files
Please reload this pagehttps://github.com/angular/angular/pull/43328/files
Please reload this pagehttps://github.com/angular/angular/pull/43328/files
packages/router/src/router.tshttps://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
View file https://github.com/atscott/angular/blob/870767502f6583b018a8b7eb24880f84891d9e23/packages/router/src/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/43328/{{ revealButtonHref }}
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/43328/files
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/43328/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.