René's URL Explorer Experiment


Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular · GitHub

Open Graph Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular

X Title: fix(router): Only trigger router navigation on `popstate` events from `Location` subscription by atscott · Pull Request #43328 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: With the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...

X Description: With the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...

Opengraph URL: https://github.com/angular/angular/pull/43328

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c4eb2b24-bd4a-333a-c77a-812f9497f8bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A3A:16EED3:BBBC30:EFE97B:6B00FC0C
html-safe-noncedcb07100c36bfef84d1bf9494c6b0a4c7f9e69e81b0f8a53390ebad046366bcb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTNBOjE2RUVEMzpCQkJDMzA6RUZFOTdCOjZCMDBGQzBDIiwidmlzaXRvcl9pZCI6IjIzOTk0NjIwNTI4MTQ1MTAyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4a337ff973422568ed156a3ef40fbf3327be739d5bd70ac825072cb8841fef1
hovercard-subject-tagpull_request:726270362
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/43328/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/23a2fe0be1487eb2f3820c6370ab52c0c4188f3ef928bd735564a896d737c079/angular/angular/pull/43328
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/23a2fe0be1487eb2f3820c6370ab52c0c4188f3ef928bd735564a896d737c079/angular/angular/pull/43328
og:image:altWith the merging of #41730, our tests now more closely emulate real browser behavior. This means that we can make changes to the Router which depend on actual browser behavior rather than incorrect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/43328#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43328
Reloadhttps://github.com/angular/angular/pull/43328
Reloadhttps://github.com/angular/angular/pull/43328
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:simplifyRouterLocationListenerhttps://github.com/atscott/angular/tree/simplifyRouterLocationListener
Conversationhttps://github.com/angular/angular/pull/43328
Commits1 (1)https://github.com/angular/angular/pull/43328/commits
Checkshttps://github.com/angular/angular/pull/43328/checks
Files changedhttps://github.com/angular/angular/pull/43328/files
fix(router): Only trigger router navigation on popstate events from Location subscriptionhttps://github.com/angular/angular/pull/43328#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:simplifyRouterLocationListenerhttps://github.com/atscott/angular/tree/simplifyRouterLocationListener
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 2, 2021https://github.com/angular/angular/pull/43328#issue-987144786
Please reload this pagehttps://github.com/angular/angular/pull/43328
#41730https://github.com/angular/angular/pull/41730
https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_senthttps://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent
#41782https://github.com/angular/angular/issues/41782
#41730https://github.com/angular/angular/pull/41730
green global presubmit trainhttps://test.corp.google.com/ui#id=OCL:394505756:BASE:394695187:1630685225825:c3f9e07e
Please reload this pagehttps://github.com/angular/angular/pull/43328
https://github.com/atscott
fix(router): Only trigger router navigation on popstate events from…https://github.com/angular/angular/pull/43328/commits/870767502f6583b018a8b7eb24880f84891d9e23
8707675https://github.com/angular/angular/pull/43328/commits/870767502f6583b018a8b7eb24880f84891d9e23
angular#41730https://github.com/angular/angular/pull/41730
https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_senthttps://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent
angular#41782https://github.com/angular/angular/issues/41782
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Sep 2, 2021https://github.com/angular/angular/pull/43328#event-5249917990
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Sep 2, 2021https://github.com/angular/angular/pull/43328#event-5249918325
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 2, 2021https://github.com/angular/angular/pull/43328#event-5249918348
https://github.com/atscott
atscotthttps://github.com/atscott
September 3, 2021 16:46https://github.com/angular/angular/pull/43328#event-5254566053
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
September 3, 2021 20:56https://github.com/angular/angular/pull/43328#event-5255460870
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 8, 2021 https://github.com/angular/angular/pull/43328#pullrequestreview-748546839
View reviewed changes https://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/43328#pullrequestreview-748546839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/43328
packages/router/src/router.tshttps://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/43328
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Sep 8, 2021https://github.com/angular/angular/pull/43328#event-5272842992
https://github.com/atscott
atscotthttps://github.com/atscott
9e039cahttps://github.com/angular/angular/commit/9e039ca68bfae5328f3fc1f16fabd7673c466a25
Sep 8, 2021https://github.com/angular/angular/pull/43328#event-5273601594
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 9, 2021https://github.com/angular/angular/pull/43328#issuecomment-939320293
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/43328
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 9, 2021https://github.com/angular/angular/pull/43328#event-5438280401
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23
Please reload this pagehttps://github.com/angular/angular/pull/43328
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Backlog https://github.com/angular/angular/milestone/82
Changing the URI in the browser directly will fire guards and resolvers of the route TWICE https://github.com/angular/angular/issues/41782
Please reload this pagehttps://github.com/angular/angular/pull/43328
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.