| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c4eb2b24-bd4a-333a-c77a-812f9497f8bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A3A:16EED3:BBBC30:EFE97B:6B00FC0C |
| html-safe-nonce | dcb07100c36bfef84d1bf9494c6b0a4c7f9e69e81b0f8a53390ebad046366bcb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTNBOjE2RUVEMzpCQkJDMzA6RUZFOTdCOjZCMDBGQzBDIiwidmlzaXRvcl9pZCI6IjIzOTk0NjIwNTI4MTQ1MTAyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b4a337ff973422568ed156a3ef40fbf3327be739d5bd70ac825072cb8841fef1 |
| hovercard-subject-tag | pull_request:726270362 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/43328/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/23a2fe0be1487eb2f3820c6370ab52c0c4188f3ef928bd735564a896d737c079/angular/angular/pull/43328 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/23a2fe0be1487eb2f3820c6370ab52c0c4188f3ef928bd735564a896d737c079/angular/angular/pull/43328 |
| og:image:alt | With the merging of #41730, our tests now more closely emulate real
browser behavior. This means that we can make changes to the Router which depend
on actual browser behavior rather than incorrect... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | atscott |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/43328#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/43328 |
| Reload | https://github.com/angular/angular/pull/43328 |
| Reload | https://github.com/angular/angular/pull/43328 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| atscott | https://github.com/atscott |
| angular:master | https://github.com/angular/angular/tree/master |
| atscott:simplifyRouterLocationListener | https://github.com/atscott/angular/tree/simplifyRouterLocationListener |
| Conversation | https://github.com/angular/angular/pull/43328 |
| Commits1 (1) | https://github.com/angular/angular/pull/43328/commits |
| Checks | https://github.com/angular/angular/pull/43328/checks |
| Files changed | https://github.com/angular/angular/pull/43328/files |
| fix(router): Only trigger router navigation on popstate events from Location subscription | https://github.com/angular/angular/pull/43328#top |
| atscott | https://github.com/atscott |
| angular:master | https://github.com/angular/angular/tree/master |
| atscott:simplifyRouterLocationListener | https://github.com/atscott/angular/tree/simplifyRouterLocationListener |
|
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Sep 2, 2021 | https://github.com/angular/angular/pull/43328#issue-987144786 |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
| #41730 | https://github.com/angular/angular/pull/41730 |
| https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent | https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent |
| #41782 | https://github.com/angular/angular/issues/41782 |
| #41730 | https://github.com/angular/angular/pull/41730 |
| green global presubmit train | https://test.corp.google.com/ui#id=OCL:394505756:BASE:394695187:1630685225825:c3f9e07e |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
|
| https://github.com/atscott |
| fix(router): Only trigger router navigation on popstate events from… | https://github.com/angular/angular/pull/43328/commits/870767502f6583b018a8b7eb24880f84891d9e23 |
| 8707675 | https://github.com/angular/angular/pull/43328/commits/870767502f6583b018a8b7eb24880f84891d9e23 |
| angular#41730 | https://github.com/angular/angular/pull/41730 |
| https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent | https://developer.mozilla.org/en-US/docs/Web/API/Window/popstate_event#when_popstate_is_sent |
| angular#41782 | https://github.com/angular/angular/issues/41782 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Sep 2, 2021 | https://github.com/angular/angular/pull/43328#event-5249917990 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Sep 2, 2021 | https://github.com/angular/angular/pull/43328#event-5249918325 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Sep 2, 2021 | https://github.com/angular/angular/pull/43328#event-5249918348 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| September 3, 2021 16:46 | https://github.com/angular/angular/pull/43328#event-5254566053 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| AndrewKushnir | https://github.com/AndrewKushnir |
| September 3, 2021 20:56 | https://github.com/angular/angular/pull/43328#event-5255460870 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Sep 8, 2021
| https://github.com/angular/angular/pull/43328#pullrequestreview-748546839 |
|
View reviewed changes
| https://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23 |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/43328#pullrequestreview-748546839 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Sep 8, 2021 | https://github.com/angular/angular/pull/43328#event-5272842992 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| 9e039ca | https://github.com/angular/angular/commit/9e039ca68bfae5328f3fc1f16fabd7673c466a25 |
| Sep 8, 2021 | https://github.com/angular/angular/pull/43328#event-5273601594 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 9, 2021 | https://github.com/angular/angular/pull/43328#issuecomment-939320293 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Oct 9, 2021 | https://github.com/angular/angular/pull/43328#event-5438280401 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43328 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/43328/files/870767502f6583b018a8b7eb24880f84891d9e23 |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
|
Changing the URI in the browser directly will fire guards and resolvers of the route TWICE
| https://github.com/angular/angular/issues/41782 |
| Please reload this page | https://github.com/angular/angular/pull/43328 |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |