René's URL Explorer Experiment


Title: revert: refactor(compiler): support interpolation and encoded entities when lexing markup by atscott · Pull Request #43033 · angular/angular · GitHub

Open Graph Title: revert: refactor(compiler): support interpolation and encoded entities when lexing markup by atscott · Pull Request #43033 · angular/angular

X Title: revert: refactor(compiler): support interpolation and encoded entities when lexing markup by atscott · Pull Request #43033 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Reverts #42062 due to it causing new messages for &ngsp; and &. This triggers the need for re-trasnlation and could result in untranslated messages in production.

X Description: Reverts #42062 due to it causing new messages for &ngsp; and &. This triggers the need for re-trasnlation and could result in untranslated messages in production.

Opengraph URL: https://github.com/angular/angular/pull/43033

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:d79918d4-4728-6e8a-b700-ed6205b12b4d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE764:14EB6E:B24B2:EB5B8:6B0181C7
html-safe-nonce03e19c28a41215d4891d0989ef07669702db46fecbfdd703ee4aeb13247e7718
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzY0OjE0RUI2RTpCMjRCMjpFQjVCODo2QjAxODFDNyIsInZpc2l0b3JfaWQiOiI0ODk0OTY0MDQ1Njc5MDAyMDU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8d1821848f53760f736096bfa92560f3fda860598a6b0890eaa8973284d18762
hovercard-subject-tagpull_request:702651245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/43033/commits
twitter:imagehttps://opengraph.githubassets.com/b6524cc8f96ad81bbf9cf8566cc1677dab459e54089cb470836c2da2a7d7bbff/angular/angular/pull/43033
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b6524cc8f96ad81bbf9cf8566cc1677dab459e54089cb470836c2da2a7d7bbff/angular/angular/pull/43033
og:image:altReverts #42062 due to it causing new messages for &ngsp; and &. This triggers the need for re-trasnlation and could result in untranslated messages in production.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/43033/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43033%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F43033%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/43033/commits
Reloadhttps://github.com/angular/angular/pull/43033/commits
Reloadhttps://github.com/angular/angular/pull/43033/commits
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:revertextractionissuehttps://github.com/atscott/angular/tree/revertextractionissue
Conversationhttps://github.com/angular/angular/pull/43033
Commits14 (14)https://github.com/angular/angular/pull/43033/commits
Checkshttps://github.com/angular/angular/pull/43033/checks
Files changedhttps://github.com/angular/angular/pull/43033/files
revert: refactor(compiler): support interpolation and encoded entities when lexing markuphttps://github.com/angular/angular/pull/43033/commits#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:revertextractionissuehttps://github.com/atscott/angular/tree/revertextractionissue
Revert "test(compiler): add a test for parsing multiline expressions in attributes (#42062)"https://github.com/angular/angular/pull/43033/commits/f3a88b81d1bd648b076b067cef29bed1e9e426e8
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
f3a88b8https://github.com/angular/angular/pull/43033/commits/f3a88b81d1bd648b076b067cef29bed1e9e426e8
https://github.com/angular/angular/tree/f3a88b81d1bd648b076b067cef29bed1e9e426e8
Revert "refactor(compiler): use `===` rather than `==` in the ml_parser (#42062)"https://github.com/angular/angular/pull/43033/commits/fa7c44aa21695955e4c3d3bebbc5a6707d08af9f
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
fa7c44ahttps://github.com/angular/angular/pull/43033/commits/fa7c44aa21695955e4c3d3bebbc5a6707d08af9f
https://github.com/angular/angular/tree/fa7c44aa21695955e4c3d3bebbc5a6707d08af9f
Revert "test(compiler): check that the parser supports prematurely terminated interpolations (#42062)"https://github.com/angular/angular/pull/43033/commits/d4a9b856f410c70fb5520786017506af51ce9c9e
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
d4a9b85https://github.com/angular/angular/pull/43033/commits/d4a9b856f410c70fb5520786017506af51ce9c9e
https://github.com/angular/angular/tree/d4a9b856f410c70fb5520786017506af51ce9c9e
Revert "refactor(compiler): define interfaces for each lexer token (#42062)"https://github.com/angular/angular/pull/43033/commits/37ff7f399a33cc14b2d89ad8e0698c5c3ddb04df
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
37ff7f3https://github.com/angular/angular/pull/43033/commits/37ff7f399a33cc14b2d89ad8e0698c5c3ddb04df
https://github.com/angular/angular/tree/37ff7f399a33cc14b2d89ad8e0698c5c3ddb04df
Revert "fix(compiler): include leading whitespace in source-spans of i18n messages (#42062)"https://github.com/angular/angular/pull/43033/commits/9d039e1db5894e4ee3caed79871ab3bea39631d9
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
9d039e1https://github.com/angular/angular/pull/43033/commits/9d039e1db5894e4ee3caed79871ab3bea39631d9
https://github.com/angular/angular/tree/9d039e1db5894e4ee3caed79871ab3bea39631d9
Revert "test(compiler): check `fullStart` source-span (#42062)"https://github.com/angular/angular/pull/43033/commits/7260758efc2feb1af078ebc5f1c244b1bf49ff60
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
7260758https://github.com/angular/angular/pull/43033/commits/7260758efc2feb1af078ebc5f1c244b1bf49ff60
https://github.com/angular/angular/tree/7260758efc2feb1af078ebc5f1c244b1bf49ff60
Revert "refactor(compiler): expose token parts in Text nodes (#42062)"https://github.com/angular/angular/pull/43033/commits/0257faf6c977f4bd889eae32a533ec9015e9ce78
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
0257fafhttps://github.com/angular/angular/pull/43033/commits/0257faf6c977f4bd889eae32a533ec9015e9ce78
https://github.com/angular/angular/tree/0257faf6c977f4bd889eae32a533ec9015e9ce78
Revert "refactor(compiler): support encoded entity tokens when lexing markup (#42062)"https://github.com/angular/angular/pull/43033/commits/b65e0f5527674f6df02bc4e282a0f7ca133ce9ca
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
b65e0f5https://github.com/angular/angular/pull/43033/commits/b65e0f5527674f6df02bc4e282a0f7ca133ce9ca
https://github.com/angular/angular/tree/b65e0f5527674f6df02bc4e282a0f7ca133ce9ca
Revert "refactor(compiler): support interpolation tokens when lexing attribute values (#42062)"https://github.com/angular/angular/pull/43033/commits/a743870bd262588e0158414b0e3ceea0a61eaef3
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
a743870https://github.com/angular/angular/pull/43033/commits/a743870bd262588e0158414b0e3ceea0a61eaef3
https://github.com/angular/angular/tree/a743870bd262588e0158414b0e3ceea0a61eaef3
Revert "refactor(compiler): share `isQuote()` via `chars.ts` (#42062)"https://github.com/angular/angular/pull/43033/commits/91ab82eeb4fc2570d8ff35798b8b6846bf904e9f
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
91ab82ehttps://github.com/angular/angular/pull/43033/commits/91ab82eeb4fc2570d8ff35798b8b6846bf904e9f
https://github.com/angular/angular/tree/91ab82eeb4fc2570d8ff35798b8b6846bf904e9f
Revert "refactor(compiler): support interpolation tokens when lexing markup (#42062)"https://github.com/angular/angular/pull/43033/commits/a72ae0fadb79306a996a232fe0519ad2dc4cb9ae
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
a72ae0fhttps://github.com/angular/angular/pull/43033/commits/a72ae0fadb79306a996a232fe0519ad2dc4cb9ae
https://github.com/angular/angular/tree/a72ae0fadb79306a996a232fe0519ad2dc4cb9ae
Revert "refactor(compiler): remove cyclic dependencies (#42062)"https://github.com/angular/angular/pull/43033/commits/b1382a89b21faf248111a5589bd39f9ac43a2231
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
b1382a8https://github.com/angular/angular/pull/43033/commits/b1382a89b21faf248111a5589bd39f9ac43a2231
https://github.com/angular/angular/tree/b1382a89b21faf248111a5589bd39f9ac43a2231
Revert "test(compiler-cli): clarify source-map expectations in compliance tests (#42062)"https://github.com/angular/angular/pull/43033/commits/538a2e07596dc27b09cd23857aa7217e832bc8c9
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
538a2e0https://github.com/angular/angular/pull/43033/commits/538a2e07596dc27b09cd23857aa7217e832bc8c9
https://github.com/angular/angular/tree/538a2e07596dc27b09cd23857aa7217e832bc8c9
Revert "refactor(ngcc): remove unused import (#42062)"https://github.com/angular/angular/pull/43033/commits/dfb875a6b20049fd421c2113827caceee87b4247
https://github.com/atscott
atscotthttps://github.com/angular/angular/commits?author=atscott
dfb875ahttps://github.com/angular/angular/pull/43033/commits/dfb875a6b20049fd421c2113827caceee87b4247
https://github.com/angular/angular/tree/dfb875a6b20049fd421c2113827caceee87b4247
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.