René's URL Explorer Experiment


Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular · GitHub

Open Graph Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular

X Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular

Description: The lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no ICU expression so it is safe to have unmatched { characters, but outside this is an error. Previously, if an interpolation was started, by an opening marker (e.g. {{) in the text, but the text came to an end before the closing marker (e.g. }}) then the lexer was not clearing its internal state that tracked that it was inside an interpolation. So if when a new text token was being consumed, the lexer, incorrectly thought it was already within an interpolation. This resulted in invalid ICU expression errors not being reported. There are instances of this error being hidden inside G3, and so these will need to be fixed in order to land this change.

Open Graph Description: The lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...

X Description: The lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...

Opengraph URL: https://github.com/angular/angular/pull/42605

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:312aac1f-a24d-d402-57eb-5c6cf4621075
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF08:EA06E:2734AEB:31D9A65:6B017D77
html-safe-noncef78c4374c1cadffcd1a055dde6e6f2dad0e44d1c8c80f37839a6d8703074d44d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjA4OkVBMDZFOjI3MzRBRUI6MzFEOUE2NTo2QjAxN0Q3NyIsInZpc2l0b3JfaWQiOiI2MjE3NDI4MTM4NzU0OTMyMDg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf257a2216396fc5d2e3a075dd84e9390244338a78fade92b42a8ecac549c37c3
hovercard-subject-tagpull_request:673859789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/42605/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altThe lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/42605/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F42605%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F42605%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/42605/files
Reloadhttps://github.com/angular/angular/pull/42605/files
Reloadhttps://github.com/angular/angular/pull/42605/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:compiler-fix-lexer-interpolation-bughttps://github.com/petebacondarwin/angular/tree/compiler-fix-lexer-interpolation-bug
Conversation 10 https://github.com/angular/angular/pull/42605
Commits 2 https://github.com/angular/angular/pull/42605/commits
Checks 0 https://github.com/angular/angular/pull/42605/checks
Files changed https://github.com/angular/angular/pull/42605/files
Please reload this pagehttps://github.com/angular/angular/pull/42605/files
fix(compiler): do not allow unterminated interpolation to leak into later tokens https://github.com/angular/angular/pull/42605/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/42605/files
7a05500 fix(compiler): do not allow unterminated interpolation to leak into l… petebacondarwin Jun 19, 2021 https://github.com/angular/angular/pull/42605/commits/7a0550084b69e12e8b80524e362016c90bd619dd
1ad8070 fix(compiler): should not break a text token on a non-valid start tag petebacondarwin Jun 21, 2021 https://github.com/angular/angular/pull/42605/commits/1ad8070b2f8e22324d1fd5be741607e88e85c015
Clear filters https://github.com/angular/angular/pull/42605/files
Please reload this pagehttps://github.com/angular/angular/pull/42605/files
Please reload this pagehttps://github.com/angular/angular/pull/42605/files
lexer.ts https://github.com/angular/angular/pull/42605/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
lexer_spec.ts https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
packages/compiler/src/ml_parser/lexer.tshttps://github.com/angular/angular/pull/42605/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
View file https://github.com/petebacondarwin/angular/blob/1ad8070b2f8e22324d1fd5be741607e88e85c015/packages/compiler/src/ml_parser/lexer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/42605/{{ revealButtonHref }}
https://github.com/angular/angular/pull/42605/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/42605/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/42605/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
packages/compiler/test/ml_parser/lexer_spec.tshttps://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
View file https://github.com/petebacondarwin/angular/blob/1ad8070b2f8e22324d1fd5be741607e88e85c015/packages/compiler/test/ml_parser/lexer_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/42605/{{ revealButtonHref }}
https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
https://github.com/angular/angular/pull/42605/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.