René's URL Explorer Experiment


Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular · GitHub

Open Graph Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular

X Title: fix(compiler): do not allow unterminated interpolation to leak into later tokens by petebacondarwin · Pull Request #42605 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...

X Description: The lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...

Opengraph URL: https://github.com/angular/angular/pull/42605

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:14df92f7-9042-5f94-024f-650c02b5682f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id966A:B53AF:1F802F7:29E20A4:6B0178C1
html-safe-nonce016421a8dd4789f0e5da16793dadf9fd1182d8294660f40f58eaf9347418f2cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjZBOkI1M0FGOjFGODAyRjc6MjlFMjBBNDo2QjAxNzhDMSIsInZpc2l0b3JfaWQiOiIzOTQxNTI5ODA0NzM3NzA2MTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd5418d3c0e1d4527983b4eb4982d9933af5988f1a1c7e13abe599204984755e5
hovercard-subject-tagpull_request:673859789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/42605/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c801b59c3a3ae49ac425c8034ec7830f7ba8708d9efabed022e5ff4f2f7de72/angular/angular/pull/42605
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c801b59c3a3ae49ac425c8034ec7830f7ba8708d9efabed022e5ff4f2f7de72/angular/angular/pull/42605
og:image:altThe lexer tracks whether it is reading characters from inside an interpolation when consuming a text token, so that it can identify invalid ICU expressions. Inside an interpolation there will be no...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/42605#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F42605
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F42605
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/42605
Reloadhttps://github.com/angular/angular/pull/42605
Reloadhttps://github.com/angular/angular/pull/42605
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:compiler-fix-lexer-interpolation-bughttps://github.com/petebacondarwin/angular/tree/compiler-fix-lexer-interpolation-bug
Conversationhttps://github.com/angular/angular/pull/42605
Commits2 (2)https://github.com/angular/angular/pull/42605/commits
Checkshttps://github.com/angular/angular/pull/42605/checks
Files changedhttps://github.com/angular/angular/pull/42605/files
fix(compiler): do not allow unterminated interpolation to leak into later tokenshttps://github.com/angular/angular/pull/42605#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:compiler-fix-lexer-interpolation-bughttps://github.com/petebacondarwin/angular/tree/compiler-fix-lexer-interpolation-bug
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 19, 2021https://github.com/angular/angular/pull/42605#issue-925366823
Please reload this pagehttps://github.com/angular/angular/pull/42605
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
compiler: parser https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22compiler%3A%20parser%22
Jun 19, 2021https://github.com/angular/angular/pull/42605#event-4912357180
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
AndrewKushnirhttps://github.com/AndrewKushnir
June 19, 2021 10:36https://github.com/angular/angular/pull/42605#event-4912357186
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jun 19, 2021https://github.com/angular/angular/pull/42605#event-4912357198
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jun 19, 2021https://github.com/angular/angular/pull/42605#event-4912357238
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 19, 2021https://github.com/angular/angular/pull/42605#event-4912357400
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 20, 2021 https://github.com/angular/angular/pull/42605#ref-pullrequest-890080236
refactor(compiler): support interpolation and encoded entities when lexing markup #42062 https://github.com/angular/angular/pull/42062
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 21, 2021https://github.com/angular/angular/pull/42605#issuecomment-864738178
Ivy Presubmithttps://test.corp.google.com/ui#id=OCL:380503757:BASE:380503855:1624253025654:6c28a828
Global Presubmithttps://test.corp.google.com/ui#id=OCL:380503757:BASE:380503824:1624253008563:3a37c73e
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/98c21faa49679769a3603c814641deb72bf13061..4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b
98c21fahttps://github.com/angular/angular/commit/98c21faa49679769a3603c814641deb72bf13061
4cee71bhttps://github.com/angular/angular/commit/4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b
Compare https://github.com/angular/angular/compare/98c21faa49679769a3603c814641deb72bf13061..4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b
June 21, 2021 20:42https://github.com/angular/angular/pull/42605#event-4919026970
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 21, 2021https://github.com/angular/angular/pull/42605#issuecomment-865331818
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 21, 2021https://github.com/angular/angular/pull/42605#issuecomment-865338319
Presubmit #2https://test.corp.google.com/ui#id=OCL:380503757:BASE:380657713:1624308959601:c950cc6c
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2021 https://github.com/angular/angular/pull/42605#pullrequestreview-688983026
View reviewed changes https://github.com/angular/angular/pull/42605/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/42605#pullrequestreview-688983026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jun 22, 2021https://github.com/angular/angular/pull/42605#event-4919849340
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2021https://github.com/angular/angular/pull/42605#issuecomment-865470238
Global Presubmit #2https://test.corp.google.com/OCL:380503757:BASE:380714247:1624328443959:cc42ccb2
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2021https://github.com/angular/angular/pull/42605#issuecomment-865555776
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jun 22, 2021https://github.com/angular/angular/pull/42605#event-4920333481
petebacondarwinhttps://github.com/petebacondarwin
June 22, 2021 08:06https://github.com/angular/angular/pull/42605#commits-pushed-7a05500
https://github.com/petebacondarwin
fix(compiler): do not allow unterminated interpolation to leak into l…https://github.com/angular/angular/pull/42605/commits/7a0550084b69e12e8b80524e362016c90bd619dd
7a05500https://github.com/angular/angular/pull/42605/commits/7a0550084b69e12e8b80524e362016c90bd619dd
https://github.com/petebacondarwin
fix(compiler): should not break a text token on a non-valid start taghttps://github.com/angular/angular/pull/42605/commits/1ad8070b2f8e22324d1fd5be741607e88e85c015
1ad8070https://github.com/angular/angular/pull/42605/commits/1ad8070b2f8e22324d1fd5be741607e88e85c015
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b..1ad8070b2f8e22324d1fd5be741607e88e85c015
4cee71bhttps://github.com/angular/angular/commit/4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b
1ad8070https://github.com/angular/angular/commit/1ad8070b2f8e22324d1fd5be741607e88e85c015
Compare https://github.com/angular/angular/compare/4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b..1ad8070b2f8e22324d1fd5be741607e88e85c015
June 22, 2021 07:14https://github.com/angular/angular/pull/42605#event-4920807268
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 22, 2021https://github.com/angular/angular/pull/42605#issuecomment-865663910
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Jun 22, 2021https://github.com/angular/angular/pull/42605#event-4920830255
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Jun 22, 2021https://github.com/angular/angular/pull/42605#issuecomment-866133503
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Jun 22, 2021https://github.com/angular/angular/pull/42605#event-4923934252
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2021https://github.com/angular/angular/pull/42605#issuecomment-866145712
@dylhunnhttps://github.com/dylhunn
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
c873440https://github.com/angular/angular/commit/c873440ad285279edafff65645a73f5da8e5bafe
Jun 22, 2021https://github.com/angular/angular/pull/42605#event-4923976256
dylhunnhttps://github.com/dylhunn
Jun 22, 2021 https://github.com/angular/angular/pull/42605#ref-commit-9de65db
https://github.com/petebacondarwin
https://github.com/dylhunn
fix(compiler): should not break a text token on a non-valid start tag (https://github.com/angular/angular/commit/9de65dbdceac3077881fbc49717f33d0f379e21d
…https://github.com/angular/angular/pull/42605
9de65dbhttps://github.com/angular/angular/commit/9de65dbdceac3077881fbc49717f33d0f379e21d
…#42605https://github.com/angular/angular/pull/42605
#42605https://github.com/angular/angular/pull/42605
dylhunnhttps://github.com/dylhunn
Jun 22, 2021 https://github.com/angular/angular/pull/42605#ref-commit-e350e87
https://github.com/petebacondarwin
https://github.com/dylhunn
fix(compiler): do not allow unterminated interpolation to leak into l…https://github.com/angular/angular/commit/e350e87bd2e4f884724dd69691795afe3043cafb
e350e87https://github.com/angular/angular/commit/e350e87bd2e4f884724dd69691795afe3043cafb
#42605https://github.com/angular/angular/pull/42605
#42605https://github.com/angular/angular/pull/42605
dylhunnhttps://github.com/dylhunn
Jun 22, 2021 https://github.com/angular/angular/pull/42605#ref-commit-2dc7b45
https://github.com/petebacondarwin
https://github.com/dylhunn
fix(compiler): should not break a text token on a non-valid start tag (https://github.com/angular/angular/commit/2dc7b452751b90a16d86ec4e5000c9c6c08b685e
…https://github.com/angular/angular/pull/42605
2dc7b45https://github.com/angular/angular/commit/2dc7b452751b90a16d86ec4e5000c9c6c08b685e
…#42605https://github.com/angular/angular/pull/42605
#42605https://github.com/angular/angular/pull/42605
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 22, 2021 https://github.com/angular/angular/pull/42605#ref-issue-120890642
Handling of "<" in html #5679 https://github.com/angular/angular/issues/5679
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2021https://github.com/angular/angular/pull/42605#issuecomment-885742286
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 23, 2021https://github.com/angular/angular/pull/42605#event-5061866054
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F42605
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/42605/files/4cee71b82303ddbb204b0ec904fc3ebbe01ecf4b
Please reload this pagehttps://github.com/angular/angular/pull/42605
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
compiler: parser https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22compiler%3A%20parser%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/42605
https://github.com/petebacondarwin
https://github.com/AndrewKushnir
https://github.com/dylhunn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.