Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular · GitHub
Open Graph Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular
X Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular
Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChange The changes to the router tests reflect the goals of the test. Generally when Location.go is used to trigger navigations, it is only relevant for HashLocationStrategy and verifying that the Router picks up changes from manual URL changes. To do this, we convert those calls to simulateHashChange instead. Manual URL bar changes to the path when not using the HashLocationStrategy would otherwise trigger a full page refresh so they aren't relevant to these test scenarios which assert correct behavior during the lifetime of the router. Reference for no popstate on pushState/replaceState Note that just calling history.pushState() or history.replaceState() won't trigger a popstate event. The popstate event will be triggered by doing a browser action such as a click on the back or forward button (or calling history.back() or history.forward() in JavaScript). Reference for popstate before hashChange When the transition occurs, either due to the user triggering the browser's "Back" button or otherwise, the popstate event is near the end of the process to transition to the new location ... 12. If the value of state changed, the popstate event is sent to the document. 13. Any persisted user state is restored, if the browser chooses to do so. 14. If the original and new entry's shared the same document, but had different fragments in their URLs, send the hashchange event to the window. BREAKING CHANGE: The behavior of the SpyLocation used by the RouterTestingModule has changed to match the behavior of browsers. It no longer emits a 'popstate' event when Location.go is called. In addition, simulateHashChange now triggers both a hashchange and a popstate event. Tests which use location.go and expect the changes to be picked up by the Router should likely change to simulateHashChange instead. Each test is different in what it attempts to assert so there is no single change that works for all tests. Each test using the SpyLocation to simulate browser URL changes should be evaluated on a case-by-case basis. fixes #27059 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information
Open Graph Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang...
X Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang...
Opengraph URL: https://github.com/angular/angular/pull/41730
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b7efcb07-b584-35cb-0ce9-4c36fd547507 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C82:23CF06:12EF893:1842985:6B0111E1 |
| html-safe-nonce | ebded3f91bc8a33c5fe0f3d3414b16b36b1840393b789a418827c04798ee9e8a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzgyOjIzQ0YwNjoxMkVGODkzOjE4NDI5ODU6NkIwMTExRTEiLCJ2aXNpdG9yX2lkIjoiODk2OTk0OTA2NTMwNzU1ODM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b2f1ecce0fe5d6538752a77810fd58a96f4783acf6788f7af45e69028c97a70d |
| hovercard-subject-tag | pull_request:619493628 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/41730/files |
| twitter:image | https://avatars.githubusercontent.com/u/16021173?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/16021173?s=400&v=4 |
| og:image:alt | Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width