René's URL Explorer Experiment


Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular · GitHub

Open Graph Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular

X Title: fix(common): synchronise location mock behavior with the navigators by aahmedayed · Pull Request #41730 · angular/angular

Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChange The changes to the router tests reflect the goals of the test. Generally when Location.go is used to trigger navigations, it is only relevant for HashLocationStrategy and verifying that the Router picks up changes from manual URL changes. To do this, we convert those calls to simulateHashChange instead. Manual URL bar changes to the path when not using the HashLocationStrategy would otherwise trigger a full page refresh so they aren't relevant to these test scenarios which assert correct behavior during the lifetime of the router. Reference for no popstate on pushState/replaceState Note that just calling history.pushState() or history.replaceState() won't trigger a popstate event. The popstate event will be triggered by doing a browser action such as a click on the back or forward button (or calling history.back() or history.forward() in JavaScript). Reference for popstate before hashChange When the transition occurs, either due to the user triggering the browser's "Back" button or otherwise, the popstate event is near the end of the process to transition to the new location ... 12. If the value of state changed, the popstate event is sent to the document. 13. Any persisted user state is restored, if the browser chooses to do so. 14. If the original and new entry's shared the same document, but had different fragments in their URLs, send the hashchange event to the window. BREAKING CHANGE: The behavior of the SpyLocation used by the RouterTestingModule has changed to match the behavior of browsers. It no longer emits a 'popstate' event when Location.go is called. In addition, simulateHashChange now triggers both a hashchange and a popstate event. Tests which use location.go and expect the changes to be picked up by the Router should likely change to simulateHashChange instead. Each test is different in what it attempts to assert so there is no single change that works for all tests. Each test using the SpyLocation to simulate browser URL changes should be evaluated on a case-by-case basis. fixes #27059 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang...

X Description: Do not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang...

Opengraph URL: https://github.com/angular/angular/pull/41730

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7efcb07-b584-35cb-0ce9-4c36fd547507
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C82:23CF06:12EF893:1842985:6B0111E1
html-safe-nonceebded3f91bc8a33c5fe0f3d3414b16b36b1840393b789a418827c04798ee9e8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzgyOjIzQ0YwNjoxMkVGODkzOjE4NDI5ODU6NkIwMTExRTEiLCJ2aXNpdG9yX2lkIjoiODk2OTk0OTA2NTMwNzU1ODM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb2f1ecce0fe5d6538752a77810fd58a96f4783acf6788f7af45e69028c97a70d
hovercard-subject-tagpull_request:619493628
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/41730/files
twitter:imagehttps://avatars.githubusercontent.com/u/16021173?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16021173?s=400&v=4
og:image:altDo not emit url pop on Location.go Emit a popstate event before each hashchange to have the same behavior of the browser. Track the url change in the internal history when calling simulateHashChang...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/41730/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41730%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41730%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/41730/files
Reloadhttps://github.com/angular/angular/pull/41730/files
Reloadhttps://github.com/angular/angular/pull/41730/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
aahmedayedhttps://github.com/aahmedayed
angular:masterhttps://github.com/angular/angular/tree/master
aahmedayed:change-the-behavior-of-location-mockhttps://github.com/aahmedayed/angular/tree/change-the-behavior-of-location-mock
Conversation 25 https://github.com/angular/angular/pull/41730
Commits 1 https://github.com/angular/angular/pull/41730/commits
Checks 0 https://github.com/angular/angular/pull/41730/checks
Files changed https://github.com/angular/angular/pull/41730/files
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
fix(common): synchronise location mock behavior with the navigators https://github.com/angular/angular/pull/41730/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/41730/files
3057985 fix(common): synchronise location mock behavior with the navigators aahmedayed Nov 16, 2020 https://github.com/angular/angular/pull/41730/commits/3057985e47693f7a9f9a740f299dccbcbe5b7900
Clear filters https://github.com/angular/angular/pull/41730/files
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
location_mock.ts https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
computed_state_restoration.spec.ts https://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
integration.spec.ts https://github.com/angular/angular/pull/41730/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
packages/common/testing/src/location_mock.tshttps://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
View file https://github.com/aahmedayed/angular/blob/3057985e47693f7a9f9a740f299dccbcbe5b7900/packages/common/testing/src/location_mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41730/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
https://github.com/angular/angular/pull/41730/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
packages/router/test/computed_state_restoration.spec.tshttps://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
View file https://github.com/aahmedayed/angular/blob/3057985e47693f7a9f9a740f299dccbcbe5b7900/packages/router/test/computed_state_restoration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41730/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
https://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
https://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
https://github.com/angular/angular/pull/41730/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
Please reload this pagehttps://github.com/angular/angular/pull/41730/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.