René's URL Explorer Experiment


Title: fix(forms): toggle disabled attribute when replacing control by ebiermann · Pull Request #41609 · angular/angular · GitHub

Open Graph Title: fix(forms): toggle disabled attribute when replacing control by ebiermann · Pull Request #41609 · angular/angular

X Title: fix(forms): toggle disabled attribute when replacing control by ebiermann · Pull Request #41609 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) PR Type Bugfix What is the current behavior? When having a [formControl] directive with a disabled control and replacing it with an enabled one, the disabled flag of the corresponding DOM element is not removed. Technically ngOnChanges will only ever set the disabled state of its DOM element to true if the control is disabled instead of also removing the disabled flag if the control is enabled. Issue Number: N/A What is the new behavior? When setting an enabled control as input of [formControl] the disabled attribute of its DOM element will be removed. Does this PR introduce a breaking change? No

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) PR...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) PR...

Opengraph URL: https://github.com/angular/angular/pull/41609

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ae7878b0-8480-ba82-088f-5a12074c7497
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8A6:237673:19A8C44:2244A73:6B0154BC
html-safe-nonce009ee30290c76df00e36770ab0529a1d5453b660c7a1ba1af5692c0777c74f5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEE2OjIzNzY3MzoxOUE4QzQ0OjIyNDRBNzM6NkIwMTU0QkMiLCJ2aXNpdG9yX2lkIjoiNjMxOTcwNjIzMDc4OTA2Nzk2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac605f7e9ff9d33ebce7c2863b88e9014c49216326da5df20cfe41516b28fdd6d4
hovercard-subject-tagpull_request:614944709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/41609/files
twitter:imagehttps://avatars.githubusercontent.com/u/842786?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/842786?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) PR...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/41609/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41609%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41609%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/41609/files
Reloadhttps://github.com/angular/angular/pull/41609/files
Reloadhttps://github.com/angular/angular/pull/41609/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ebiermannhttps://github.com/ebiermann
angular:masterhttps://github.com/angular/angular/tree/master
ebiermann:form-control-enablehttps://github.com/ebiermann/angular/tree/form-control-enable
Conversation 2 https://github.com/angular/angular/pull/41609
Commits 1 https://github.com/angular/angular/pull/41609/commits
Checks 0 https://github.com/angular/angular/pull/41609/checks
Files changed https://github.com/angular/angular/pull/41609/files
Please reload this pagehttps://github.com/angular/angular/pull/41609/files
fix(forms): toggle disabled attribute when replacing control https://github.com/angular/angular/pull/41609/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/41609/files
f098118 fix(forms): toggle disabled attribute when replacing control Apr 14, 2021 https://github.com/angular/angular/pull/41609/commits/f098118883f4dd09d4c5ef106facd8b8e6bbe0ab
Clear filters https://github.com/angular/angular/pull/41609/files
Please reload this pagehttps://github.com/angular/angular/pull/41609/files
Please reload this pagehttps://github.com/angular/angular/pull/41609/files
form_control_directive.ts https://github.com/angular/angular/pull/41609/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
reactive_integration_spec.ts https://github.com/angular/angular/pull/41609/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
packages/forms/src/directives/reactive_directives/form_control_directive.tshttps://github.com/angular/angular/pull/41609/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
View file https://github.com/ebiermann/angular/blob/f098118883f4dd09d4c5ef106facd8b8e6bbe0ab/packages/forms/src/directives/reactive_directives/form_control_directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41609/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41609/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
https://github.com/angular/angular/pull/41609/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
packages/forms/test/reactive_integration_spec.tshttps://github.com/angular/angular/pull/41609/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
View file https://github.com/ebiermann/angular/blob/f098118883f4dd09d4c5ef106facd8b8e6bbe0ab/packages/forms/test/reactive_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41609/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41609/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com/angular/angular/pull/41609/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com/angular/angular/pull/41609/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.