René's URL Explorer Experiment


Title: fix(zone.js): should continue to executue listeners when throw error by JiaLiPassion · Pull Request #41562 · angular/angular · GitHub

Open Graph Title: fix(zone.js): should continue to executue listeners when throw error by JiaLiPassion · Pull Request #41562 · angular/angular

X Title: fix(zone.js): should continue to executue listeners when throw error by JiaLiPassion · Pull Request #41562 · angular/angular

Description: Close #41522 zone.js patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: export class AppComponent implements AfterViewInit { @ViewChild('btn') btn: ElementRef; title = 'event-error'; constructor(private ngZone: NgZone) {} ngAfterViewInit() { this.ngZone.runOutsideAngular(() => { this.btn.nativeElement.addEventListener('click', () => { throw new Error('test1'); }); this.btn.nativeElement.addEventListener('click', () => { console.log('add eventlistener click'); }); }); } } Until now no Angular users report this issue becuase in the ngZone, all error will be caught and will not rethrow, so the event listeners afterward will still continue to execute, but if the event handlers are outside of ngZone, the error will break the execution. This commit catch all errors, and after all event listeners finished invocation, rethrow the errors in seperate microTasks, the reason I am using microTask here is to handle multiple errors case.

Open Graph Description: Close #41522 zone.js patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: export class AppCompo...

X Description: Close #41522 zone.js patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: export class AppCompo...

Opengraph URL: https://github.com/angular/angular/pull/41562

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:01be81f7-1fcb-b053-1020-507bf1d2176d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC026:14ECB:CAE36B:1032508:6B010007
html-safe-nonce56e7c8135e58752ab7afa5eb5ba17b341a54483a33cc285300638ece194d6749
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDI2OjE0RUNCOkNBRTM2QjoxMDMyNTA4OjZCMDEwMDA3IiwidmlzaXRvcl9pZCI6IjMzMDI0NTY4MDg3Mzk3NjYyODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace39c948593eed3ec0ec14c706b591c6a0c964a0fe4f51a4c897431cef04a9d90
hovercard-subject-tagpull_request:613018950
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/41562/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #41522 zone.js patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: export class AppCompo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/41562/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41562%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F41562%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/41562/files
Reloadhttps://github.com/angular/angular/pull/41562/files
Reloadhttps://github.com/angular/angular/pull/41562/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:issue-41522https://github.com/JiaLiPassion/angular/tree/issue-41522
Conversation 14 https://github.com/angular/angular/pull/41562
Commits 2 https://github.com/angular/angular/pull/41562/commits
Checks 0 https://github.com/angular/angular/pull/41562/checks
Files changed https://github.com/angular/angular/pull/41562/files
Please reload this pagehttps://github.com/angular/angular/pull/41562/files
fix(zone.js): should continue to executue listeners when throw error https://github.com/angular/angular/pull/41562/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/41562/files
a153cfa fix(zone.js): should continue to executue listeners when throw error JiaLiPassion Apr 11, 2021 https://github.com/angular/angular/pull/41562/commits/a153cfaca9b831e1c68de7b4c33fec531cfdcb4a
daaef92 test(zone.js): should invoke XHR task even onload handler throw error. JiaLiPassion Apr 11, 2021 https://github.com/angular/angular/pull/41562/commits/daaef92fdf3311afd99fa296225c39c788b13b09
Clear filters https://github.com/angular/angular/pull/41562/files
Please reload this pagehttps://github.com/angular/angular/pull/41562/files
Please reload this pagehttps://github.com/angular/angular/pull/41562/files
browser.ts https://github.com/angular/angular/pull/41562/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
event-target-legacy.ts https://github.com/angular/angular/pull/41562/files#diff-4797a0ebd6368e9d81cc174fe79dae0494a6dfcb035fa1aca18fa3caccfd4144
event-target.ts https://github.com/angular/angular/pull/41562/files#diff-027accb09a0ca78ae2908b72b22540228f2495df4a6a4f70796f85299c0e06a1
shadydom.ts https://github.com/angular/angular/pull/41562/files#diff-c24ffdf6f804dc98fdc45277969c28bb38aa9b5d9824cfadb67710ab5219f6b9
webapis-rtc-peer-connection.ts https://github.com/angular/angular/pull/41562/files#diff-dbd14e71e3cc3663f6419dc8f4abdee1dad16bcad93143ff1d2b55c9504da825
websocket.ts https://github.com/angular/angular/pull/41562/files#diff-4a596f1cd0c5e4021da8c9282c5378fd99aeca822f337f955677743e1032f2b2
events.ts https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
socket-io.ts https://github.com/angular/angular/pull/41562/files#diff-eeb226a71d2829e7c24cb3524116de7585aa473f9fe41629b5d009c1efa6e4eb
events.ts https://github.com/angular/angular/pull/41562/files#diff-cf6050664e69918893adb4e5e034c09f216b2e3134c0cb05f9483fcc4d736e41
zone.ts https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
XMLHttpRequest.spec.ts https://github.com/angular/angular/pull/41562/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
browser.spec.ts https://github.com/angular/angular/pull/41562/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
packages/zone.js/lib/browser/browser.tshttps://github.com/angular/angular/pull/41562/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/browser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
https://github.com/angular/angular/pull/41562/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
packages/zone.js/lib/browser/event-target-legacy.tshttps://github.com/angular/angular/pull/41562/files#diff-4797a0ebd6368e9d81cc174fe79dae0494a6dfcb035fa1aca18fa3caccfd4144
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/event-target-legacy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-4797a0ebd6368e9d81cc174fe79dae0494a6dfcb035fa1aca18fa3caccfd4144
https://github.com/angular/angular/pull/41562/files#diff-4797a0ebd6368e9d81cc174fe79dae0494a6dfcb035fa1aca18fa3caccfd4144
packages/zone.js/lib/browser/event-target.tshttps://github.com/angular/angular/pull/41562/files#diff-027accb09a0ca78ae2908b72b22540228f2495df4a6a4f70796f85299c0e06a1
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/event-target.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-027accb09a0ca78ae2908b72b22540228f2495df4a6a4f70796f85299c0e06a1
https://github.com/angular/angular/pull/41562/files#diff-027accb09a0ca78ae2908b72b22540228f2495df4a6a4f70796f85299c0e06a1
packages/zone.js/lib/browser/shadydom.tshttps://github.com/angular/angular/pull/41562/files#diff-c24ffdf6f804dc98fdc45277969c28bb38aa9b5d9824cfadb67710ab5219f6b9
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/shadydom.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-c24ffdf6f804dc98fdc45277969c28bb38aa9b5d9824cfadb67710ab5219f6b9
packages/zone.js/lib/browser/webapis-rtc-peer-connection.tshttps://github.com/angular/angular/pull/41562/files#diff-dbd14e71e3cc3663f6419dc8f4abdee1dad16bcad93143ff1d2b55c9504da825
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/webapis-rtc-peer-connection.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-dbd14e71e3cc3663f6419dc8f4abdee1dad16bcad93143ff1d2b55c9504da825
packages/zone.js/lib/browser/websocket.tshttps://github.com/angular/angular/pull/41562/files#diff-4a596f1cd0c5e4021da8c9282c5378fd99aeca822f337f955677743e1032f2b2
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/browser/websocket.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-4a596f1cd0c5e4021da8c9282c5378fd99aeca822f337f955677743e1032f2b2
https://github.com/angular/angular/pull/41562/files#diff-4a596f1cd0c5e4021da8c9282c5378fd99aeca822f337f955677743e1032f2b2
packages/zone.js/lib/common/events.tshttps://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/common/events.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/41562/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
packages/zone.js/lib/extra/socket-io.tshttps://github.com/angular/angular/pull/41562/files#diff-eeb226a71d2829e7c24cb3524116de7585aa473f9fe41629b5d009c1efa6e4eb
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/extra/socket-io.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-eeb226a71d2829e7c24cb3524116de7585aa473f9fe41629b5d009c1efa6e4eb
https://github.com/angular/angular/pull/41562/files#diff-eeb226a71d2829e7c24cb3524116de7585aa473f9fe41629b5d009c1efa6e4eb
packages/zone.js/lib/node/events.tshttps://github.com/angular/angular/pull/41562/files#diff-cf6050664e69918893adb4e5e034c09f216b2e3134c0cb05f9483fcc4d736e41
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/node/events.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-cf6050664e69918893adb4e5e034c09f216b2e3134c0cb05f9483fcc4d736e41
https://github.com/angular/angular/pull/41562/files#diff-cf6050664e69918893adb4e5e034c09f216b2e3134c0cb05f9483fcc4d736e41
https://github.com/angular/angular/pull/41562/files#diff-cf6050664e69918893adb4e5e034c09f216b2e3134c0cb05f9483fcc4d736e41
packages/zone.js/lib/zone.tshttps://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/lib/zone.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/41562/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
packages/zone.js/test/browser/XMLHttpRequest.spec.tshttps://github.com/angular/angular/pull/41562/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
View file https://github.com/JiaLiPassion/angular/blob/daaef92fdf3311afd99fa296225c39c788b13b09/packages/zone.js/test/browser/XMLHttpRequest.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/41562/{{ revealButtonHref }}
https://github.com/angular/angular/pull/41562/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
https://github.com/angular/angular/pull/41562/files#diff-b89610548f1c2a4886396f806bf18814763756e8de6acf14a1cbdc664ac72d26
Please reload this pagehttps://github.com/angular/angular/pull/41562/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.