René's URL Explorer Experiment


Title: fix(forms): incorrectly keeping track of ngModel with ngFor inside a form by crisbeto · Pull Request #40459 · angular/angular · GitHub

Open Graph Title: fix(forms): incorrectly keeping track of ngModel with ngFor inside a form by crisbeto · Pull Request #40459 · angular/angular

X Title: fix(forms): incorrectly keeping track of ngModel with ngFor inside a form by crisbeto · Pull Request #40459 · angular/angular

Description: When an NgModel is created within a form, it receives an NgControl based on its name, but the control doesn't get swapped out if the name changes. This can lead to problems if the NgModel is part of an ngFor, because the name can change based on its position in the list and a new control can be defined with the same name, leading us to having multiple directives pointing to the same control. For example, if we start off with a list like : [0, 1, 2]; -> [NgModel(0), NgModel(1), NgModel(2)] Then we remove the second item: [0, 2]; -> [NgModel(0), NgModel(2)] And finally, if we decide to add an item to the end of the list, we'll already have a control for index 2, causing the list to look like: [0, 2, 3]; -> [NgModel(0), NgModel(2), NgModel(2)] These changes fix the issue by removing the old control when the name of the directive changes. Fixes #38465. Fixes #37920.

Open Graph Description: When an NgModel is created within a form, it receives an NgControl based on its name, but the control doesn't get swapped out if the name changes. This can lead to problems if the NgModel is pa...

X Description: When an NgModel is created within a form, it receives an NgControl based on its name, but the control doesn't get swapped out if the name changes. This can lead to problems if the NgModel i...

Opengraph URL: https://github.com/angular/angular/pull/40459

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:33b653eb-b03f-51ea-7448-a49d93c86ea1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE792:3A347:1B9AB31:247CB53:6B015375
html-safe-noncef7e814fe173580a6cd36a6b7cf51775a0f2ce3e2360356f23857f0330af4e48a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzkyOjNBMzQ3OjFCOUFCMzE6MjQ3Q0I1Mzo2QjAxNTM3NSIsInZpc2l0b3JfaWQiOiI2NzkxNjE0NDA5NTIyMzY5Mzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ed7ac21af0eebdc225b3be6bdb83d1c1f8d3f82f29c017fa48e47403e4eacdc
hovercard-subject-tagpull_request:556160299
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/40459/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altWhen an NgModel is created within a form, it receives an NgControl based on its name, but the control doesn't get swapped out if the name changes. This can lead to problems if the NgModel is pa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/40459/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F40459%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F40459%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/40459/files
Reloadhttps://github.com/angular/angular/pull/40459/files
Reloadhttps://github.com/angular/angular/pull/40459/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:38465/forms-ng-model-ng-forhttps://github.com/crisbeto/angular/tree/38465/forms-ng-model-ng-for
Conversation 27 https://github.com/angular/angular/pull/40459
Commits 1 https://github.com/angular/angular/pull/40459/commits
Checks 0 https://github.com/angular/angular/pull/40459/checks
Files changed https://github.com/angular/angular/pull/40459/files
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
fix(forms): incorrectly keeping track of ngModel with ngFor inside a form https://github.com/angular/angular/pull/40459/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/40459/files
59887c2 fix(forms): incorrectly keeping track of ngModel with ngFor inside a … crisbeto Jan 17, 2021 https://github.com/angular/angular/pull/40459/commits/59887c27f4b4bb12d76d22201c57c4a8964ee0a4
Clear filters https://github.com/angular/angular/pull/40459/files
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
ng_form.ts https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
ng_model.ts https://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
shared.ts https://github.com/angular/angular/pull/40459/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
template_integration_spec.ts https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
packages/forms/src/directives/ng_form.tshttps://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
View file https://github.com/crisbeto/angular/blob/59887c27f4b4bb12d76d22201c57c4a8964ee0a4/packages/forms/src/directives/ng_form.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/40459/{{ revealButtonHref }}
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/40459/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
packages/forms/src/directives/ng_model.tshttps://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
View file https://github.com/crisbeto/angular/blob/59887c27f4b4bb12d76d22201c57c4a8964ee0a4/packages/forms/src/directives/ng_model.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/40459/{{ revealButtonHref }}
https://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
https://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
https://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
https://github.com/angular/angular/pull/40459/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
packages/forms/src/directives/shared.tshttps://github.com/angular/angular/pull/40459/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
View file https://github.com/crisbeto/angular/blob/59887c27f4b4bb12d76d22201c57c4a8964ee0a4/packages/forms/src/directives/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/40459/{{ revealButtonHref }}
https://github.com/angular/angular/pull/40459/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
https://github.com/angular/angular/pull/40459/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
packages/forms/test/template_integration_spec.tshttps://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
View file https://github.com/crisbeto/angular/blob/59887c27f4b4bb12d76d22201c57c4a8964ee0a4/packages/forms/test/template_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/40459/{{ revealButtonHref }}
https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 17, 2021https://github.com/angular/angular/pull/40459/files#r559236004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/40459/files
https://github.com/angular/angular/pull/40459/files#diff-4b887b5f626d29992fe550288b897497471a33360cefe6a231b3367770de22b5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.