| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cca672b6-9259-1bf5-617b-ebd1fb9db95e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9BE:3E5283:2F45:398B:696AFA08 |
| html-safe-nonce | ff5537d527bea02fa63cea5d2a04830590e5d17c4c7e0b00246a11fbee665755 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUJFOjNFNTI4MzoyRjQ1OjM5OEI6Njk2QUZBMDgiLCJ2aXNpdG9yX2lkIjoiMTI2MjkxMTEzMjIwMzUyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a2c0cef787bf0f4bb947e9c1bc926584ceea0767474e21d8365efe22382f44e4 |
| hovercard-subject-tag | pull_request:532864694 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39983/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2ddb349a7e2840102b5190bc5f4f9cd843065f0c0ab5f637958d784b7560edd5/angular/angular/pull/39983 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2ddb349a7e2840102b5190bc5f4f9cd843065f0c0ab5f637958d784b7560edd5/angular/angular/pull/39983 |
| og:image:alt | Accidently closed #28264 re-opening it here.
Forward getPosition to animation_group_player.
PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows ou... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhevery |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/39983#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39983 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39983 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39983 |
| Reload | https://github.com/angular/angular/pull/39983 |
| Reload | https://github.com/angular/angular/pull/39983 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
99.7k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
1k
| https://github.com/angular/angular/issues |
|
Pull requests
104
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
2
| https://github.com/angular/angular/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/angular/angular/security |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/angular/angular/pull/39983#issue-comment-box |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| mhevery:pr/28264 | https://github.com/mhevery/angular/tree/pr/28264 |
|
fix(animations): implement getPosition in browser animation builder
| https://github.com/angular/angular/pull/39983#top |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| mhevery:pr/28264 | https://github.com/mhevery/angular/tree/pr/28264 |
|
Conversation
11
| https://github.com/angular/angular/pull/39983 |
|
Commits
1
| https://github.com/angular/angular/pull/39983/commits |
|
Checks
0
| https://github.com/angular/angular/pull/39983/checks |
|
Files changed
| https://github.com/angular/angular/pull/39983/files |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
|
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#issue-757497536 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| #28264 | https://github.com/angular/angular/pull/28264 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-739095691 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39983 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#event-4075001364 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| jelbourn | https://github.com/jelbourn |
| December 5, 2020 00:57 | https://github.com/angular/angular/pull/39983#event-4075001447 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Dec 5, 2020
| https://github.com/angular/angular/pull/39983#ref-pullrequest-401111843 |
|
fix(animations): implement getPosition in browser animation builder
#28264
| https://github.com/angular/angular/pull/28264 |
| https://github.com/cgatian |
| cgatian | https://github.com/cgatian |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-739102150 |
| @literalpie | https://github.com/literalpie |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/literalpie |
| literalpie | https://github.com/literalpie |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-739112609 |
| @googlebot | https://github.com/googlebot |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Dec 5, 2020 | https://github.com/angular/angular/pull/39983#event-4075118229 |
|
| https://github.com/literalpie |
|
| https://github.com/mhevery |
| fix(animations): implement getPosition in browser animation builder | https://github.com/angular/angular/pull/39983/commits/392ec47f9605bbeb6c0da66fe7715264dd79a9f3 |
| 392ec47 | https://github.com/angular/angular/pull/39983/commits/392ec47f9605bbeb6c0da66fe7715264dd79a9f3 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/f4108601cd3fc2c4507a4874bf57c537350fe3c9..392ec47f9605bbeb6c0da66fe7715264dd79a9f3 |
| f410860 | https://github.com/angular/angular/commit/f4108601cd3fc2c4507a4874bf57c537350fe3c9 |
| 392ec47 | https://github.com/angular/angular/commit/392ec47f9605bbeb6c0da66fe7715264dd79a9f3 |
|
Compare
| https://github.com/angular/angular/compare/f4108601cd3fc2c4507a4874bf57c537350fe3c9..392ec47f9605bbeb6c0da66fe7715264dd79a9f3 |
| December 7, 2020 19:28 | https://github.com/angular/angular/pull/39983#event-4081305906 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 7, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-740130943 |
| presubmit | http://test/OCL:346138975:BASE:346139022:1607369344066:7c6c0ee6 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/literalpie |
| literalpie | https://github.com/literalpie |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-740872346 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39983#event-4087106151 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39983#event-4087106221 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-741166025 |
| #28264 | https://github.com/angular/angular/pull/28264 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| ca08625 | https://github.com/angular/angular/commit/ca08625227dd6c7c704df514a68bdeb5f59f1943 |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#event-4087358483 |
| mhevery | https://github.com/mhevery |
|
Dec 9, 2020
| https://github.com/angular/angular/pull/39983#ref-commit-5a765f0 |
|
| https://github.com/literalpie |
|
| https://github.com/mhevery |
| fix(animations): implement getPosition in browser animation builder ( | https://github.com/angular/angular/commit/5a765f0be9caf881a7d0e9330ac2763cdac25dff |
| #… | https://github.com/angular/angular/pull/39983 |
| 5a765f0 | https://github.com/angular/angular/commit/5a765f0be9caf881a7d0e9330ac2763cdac25dff |
| …39983 | https://github.com/angular/angular/pull/39983 |
| #39983 | https://github.com/angular/angular/pull/39983 |
| https://github.com/literalpie |
| literalpie | https://github.com/literalpie |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-742011854 |
| @mhevery | https://github.com/mhevery |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-742013542 |
| @literalpie | https://github.com/literalpie |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/literalpie |
| literalpie | https://github.com/literalpie |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-742018707 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#issuecomment-742022744 |
| has already been released in 11.0.4 | https://github.com/angular/angular/blob/master/CHANGELOG.md#1104-2020-12-09 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Dec 9, 2020
| https://github.com/angular/angular/pull/39983#ref-issue-253097975 |
|
AnimationPlayer.getPosition always returns zero
#18891
| https://github.com/angular/angular/issues/18891 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#event-4091903947 |
|
AnimationPlayer.getPosition always returns zero
#18891
| https://github.com/angular/angular/issues/18891 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Dec 9, 2020
| https://github.com/angular/angular/pull/39983#ref-issue-321438208 |
|
AnimationGroupPlayer getPosition() always zero
#23785
| https://github.com/angular/angular/issues/23785 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Dec 9, 2020 | https://github.com/angular/angular/pull/39983#event-4091905404 |
|
AnimationGroupPlayer getPosition() always zero
#23785
| https://github.com/angular/angular/issues/23785 |
| zarend | https://github.com/zarend |
|
Dec 10, 2020
| https://github.com/angular/angular/pull/39983#ref-commit-7f8eba3 |
|
| https://github.com/literalpie |
|
| https://github.com/zarend |
| fix(animations): implement getPosition in browser animation builder ( | https://github.com/zarend/angular/commit/7f8eba3845249c9837cec19d6876e287c08ab9b2 |
| a… | https://github.com/angular/angular/pull/39983 |
| 7f8eba3 | https://github.com/zarend/angular/commit/7f8eba3845249c9837cec19d6876e287c08ab9b2 |
| …ngular#39983 | https://github.com/angular/angular/pull/39983 |
| angular#39983 | https://github.com/angular/angular/pull/39983 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 9, 2021 | https://github.com/angular/angular/pull/39983#issuecomment-757335008 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 9, 2021 | https://github.com/angular/angular/pull/39983#event-4187252093 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39983 |
|
| https://github.com/jelbourn |
|
jelbourn
| https://github.com/jelbourn |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
AnimationGroupPlayer getPosition() always zero
| https://github.com/angular/angular/issues/23785 |
|
AnimationPlayer.getPosition always returns zero
| https://github.com/angular/angular/issues/18891 |
| Please reload this page | https://github.com/angular/angular/pull/39983 |
|
| https://github.com/mhevery |
|
| https://github.com/cgatian |
|
| https://github.com/literalpie |
|
| https://github.com/petebacondarwin |
|
| https://github.com/JoostK |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |