| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cc1f6f91-f7d7-2975-19d2-1d6d2b5eeb0d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5EE:267D86:8AC8C:B5855:696B5B6C |
| html-safe-nonce | 169f2f7b536c74583140aea546f07009d302da4d0afed96f4a62b9f7ae28bdef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUVFOjI2N0Q4Njo4QUM4QzpCNTg1NTo2OTZCNUI2QyIsInZpc2l0b3JfaWQiOiIxMDc2NTAwMjY0MjE5NTMyMTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b14dd175317581e821d5a9eb1eb8a48a48387a350d962f515fbf08bc837948a2 |
| hovercard-subject-tag | pull_request:529901319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39898/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1bb6f84fb1e373164ee5eec52476723fb55857731f5fc91f23ae0c2dff710f0c/angular/angular/pull/39898 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1bb6f84fb1e373164ee5eec52476723fb55857731f5fc91f23ae0c2dff710f0c/angular/angular/pull/39898 |
| og:image:alt | There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.
I've submitted an upstream PR
microsoft/TypeScript#41737 to ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kyliau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/39898#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39898 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39898 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39898 |
| Reload | https://github.com/angular/angular/pull/39898 |
| Reload | https://github.com/angular/angular/pull/39898 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
99.7k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
1k
| https://github.com/angular/angular/issues |
|
Pull requests
105
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
2
| https://github.com/angular/angular/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/angular/angular/security |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/angular/angular/pull/39898#issue-comment-box |
| kyliau | https://github.com/kyliau |
| angular:master | https://github.com/angular/angular/tree/master |
| kyliau:external-template | https://github.com/kyliau/angular/tree/external-template |
|
fix(language-service): do not return external template that does not exist
| https://github.com/angular/angular/pull/39898#top |
| kyliau | https://github.com/kyliau |
| angular:master | https://github.com/angular/angular/tree/master |
| kyliau:external-template | https://github.com/kyliau/angular/tree/external-template |
|
Conversation
2
| https://github.com/angular/angular/pull/39898 |
|
Commits
1
| https://github.com/angular/angular/pull/39898/commits |
|
Checks
0
| https://github.com/angular/angular/pull/39898/checks |
|
Files changed
| https://github.com/angular/angular/pull/39898/files |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
|
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39898#issue-753914938 |
| microsoft/TypeScript#41737 | https://github.com/microsoft/TypeScript/pull/41737 |
| angular/vscode-ng-language-service#1001 | https://github.com/angular/vscode-ng-language-service/issues/1001 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
area: language-service
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39898#event-4054607341 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
| atscott | https://github.com/atscott |
| ayazhafiz | https://github.com/ayazhafiz |
| December 1, 2020 00:56 | https://github.com/angular/angular/pull/39898#event-4054607354 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39898#event-4054607432 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39898#event-4054607623 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
|
Dec 1, 2020
| https://github.com/angular/angular/pull/39898#pullrequestreview-542050797 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39898/files |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39898#issuecomment-736655014 |
| angular/vscode-ng-language-service#1001 (comment) | https://github.com/angular/vscode-ng-language-service/issues/1001#issuecomment-736652129 |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
|
| https://github.com/kyliau |
| fix(language-service): do not return external template that does not … | https://github.com/angular/angular/pull/39898/commits/2e45f9fa9b0e5a9cbfce3a399030644de7a3b578 |
| 2e45f9f | https://github.com/angular/angular/pull/39898/commits/2e45f9fa9b0e5a9cbfce3a399030644de7a3b578 |
| microsoft/TypeScript#41737 | https://github.com/microsoft/TypeScript/pull/41737 |
| angular/vscode-ng-language-service#1001 | https://github.com/angular/vscode-ng-language-service/issues/1001 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
| force-pushed | https://github.com/angular/angular/compare/313211ebd7c2caec7991f6bc906df1d4b0320234..2e45f9fa9b0e5a9cbfce3a399030644de7a3b578 |
| 313211e | https://github.com/angular/angular/commit/313211ebd7c2caec7991f6bc906df1d4b0320234 |
| 2e45f9f | https://github.com/angular/angular/commit/2e45f9fa9b0e5a9cbfce3a399030644de7a3b578 |
|
Compare
| https://github.com/angular/angular/compare/313211ebd7c2caec7991f6bc906df1d4b0320234..2e45f9fa9b0e5a9cbfce3a399030644de7a3b578 |
| December 2, 2020 22:55 | https://github.com/angular/angular/pull/39898#event-4064736528 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
| atscott | https://github.com/atscott |
| December 2, 2020 22:55 | https://github.com/angular/angular/pull/39898#event-4064736535 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39898#event-4064737070 |
| mhevery | https://github.com/mhevery |
|
Dec 3, 2020
| https://github.com/angular/angular/pull/39898#ref-commit-6b6fcd7 |
|
| https://github.com/kyliau |
|
| https://github.com/mhevery |
| fix(language-service): do not return external template that does not … | https://github.com/angular/angular/commit/6b6fcd70a00f7164b75baa9f046ba88de1472188 |
| 6b6fcd7 | https://github.com/angular/angular/commit/6b6fcd70a00f7164b75baa9f046ba88de1472188 |
| #39898 | https://github.com/angular/angular/pull/39898 |
| microsoft/TypeScript#41737 | https://github.com/microsoft/TypeScript/pull/41737 |
| angular/vscode-ng-language-service#1001 | https://github.com/angular/vscode-ng-language-service/issues/1001 |
| #39898 | https://github.com/angular/angular/pull/39898 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 2b84882 | https://github.com/angular/angular/commit/2b84882ab01b8b9769515ded75880f1af9fce736 |
| Dec 3, 2020 | https://github.com/angular/angular/pull/39898#event-4068042991 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 3, 2021 | https://github.com/angular/angular/pull/39898#issuecomment-753644613 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 3, 2021 | https://github.com/angular/angular/pull/39898#event-4162620628 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39898 |
|
| https://github.com/ayazhafiz |
|
ayazhafiz
| https://github.com/ayazhafiz |
|
| https://github.com/angular/angular/pull/39898/files/313211ebd7c2caec7991f6bc906df1d4b0320234 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: language-service
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Crash on startup
| https://github.com/angular/vscode-ng-language-service/issues/1001 |
| Please reload this page | https://github.com/angular/angular/pull/39898 |
|
| https://github.com/kyliau |
|
| https://github.com/ayazhafiz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |