| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b8ae5e84-2a4f-2a8b-827f-5de025a880d1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9FAE:14FC13:2A6B7A1:37DDA11:696B30F6 |
| html-safe-nonce | 592e7c1033a1c3fa10a1b70bfca2efc4efe20c6a7715ae17b62189de5308c4b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkFFOjE0RkMxMzoyQTZCN0ExOjM3RERBMTE6Njk2QjMwRjYiLCJ2aXNpdG9yX2lkIjoiODQ5MzY0NjY0NTM3NzU3NzIwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 051f0ef3baef6139a35f3785c67bdd5673f22a062ced7d9406c72a38d78a6290 |
| hovercard-subject-tag | pull_request:529026399 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39876/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bb0454fa5105b100ca0eb3cfe56c7ddc020d5559de79cb839150cf2ecd333592/angular/angular/pull/39876 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb0454fa5105b100ca0eb3cfe56c7ddc020d5559de79cb839150cf2ecd333592/angular/angular/pull/39876 |
| og:image:alt | PR Checklist
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | arturovt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/39876#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39876 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39876 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39876 |
| Reload | https://github.com/angular/angular/pull/39876 |
| Reload | https://github.com/angular/angular/pull/39876 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
99.7k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
1k
| https://github.com/angular/angular/issues |
|
Pull requests
105
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
2
| https://github.com/angular/angular/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/angular/angular/security |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/angular/angular/pull/39876#issue-comment-box |
| arturovt | https://github.com/arturovt |
| angular:master | https://github.com/angular/angular/tree/master |
|
fix(core): remove application from the testability registry when the root view is removed
| https://github.com/angular/angular/pull/39876#top |
| arturovt | https://github.com/arturovt |
| angular:master | https://github.com/angular/angular/tree/master |
|
Conversation
20
| https://github.com/angular/angular/pull/39876 |
|
Commits
2
| https://github.com/angular/angular/pull/39876/commits |
|
Checks
0
| https://github.com/angular/angular/pull/39876/checks |
|
Files changed
| https://github.com/angular/angular/pull/39876/files |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
|
| https://github.com/arturovt |
| arturovt | https://github.com/arturovt |
| Nov 29, 2020 | https://github.com/angular/angular/pull/39876#issue-752795872 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #22106 | https://github.com/angular/angular/issues/22106 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 29, 2020 | https://github.com/angular/angular/pull/39876#event-4048553944 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| mhevery | https://github.com/mhevery |
| November 29, 2020 00:07 | https://github.com/angular/angular/pull/39876#event-4048553996 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Nov 30, 2020
| https://github.com/angular/angular/pull/39876#pullrequestreview-541201412 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39876/files |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| alxhub | https://github.com/alxhub |
| atscott | https://github.com/atscott |
| jelbourn | https://github.com/jelbourn |
| November 30, 2020 18:57 | https://github.com/angular/angular/pull/39876#event-4053474369 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Nov 30, 2020 | https://github.com/angular/angular/pull/39876#event-4053474900 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Nov 30, 2020 | https://github.com/angular/angular/pull/39876#event-4053481526 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Nov 30, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-735978031 |
| presubmit | http://test/OCL:344846692:BASE:344846718:1606762758423:c23ef41d |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Nov 30, 2020
| https://github.com/angular/angular/pull/39876#pullrequestreview-541209855 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39876/files |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/39876#pullrequestreview-541209855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @arturovt | https://github.com/arturovt |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| packages/core/src/application_ref.ts | https://github.com/angular/angular/pull/39876/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39876/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Nov 30, 2020 | https://github.com/angular/angular/pull/39876#discussion_r532859374 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| packages/core/src/application_ref.ts | https://github.com/angular/angular/pull/39876/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| packages/core/src/application_ref.ts | https://github.com/angular/angular/pull/39876/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| IgorMinar | https://github.com/IgorMinar |
| November 30, 2020 20:02 | https://github.com/angular/angular/pull/39876#event-4053720351 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Nov 30, 2020 | https://github.com/angular/angular/pull/39876#event-4053720998 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#event-4054530008 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#event-4054530053 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-736147005 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-736149330 |
| presubmit | http://test/OCL:344846692:BASE:344917162:1606784379067:44b6627b |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-736197791 |
| @mhevery | https://github.com/mhevery |
| @arturovt | https://github.com/arturovt |
| ComponentRef onDestroyed() callback does not get called #39365 | https://github.com/angular/angular/issues/39365 |
| ComponentRef onDestroyed() callback does not get called #39365 | https://github.com/angular/angular/issues/39365 |
| #39365 | https://github.com/angular/angular/issues/39365 |
| @arturovt | https://github.com/arturovt |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#event-4055573300 |
| https://github.com/arturovt |
| arturovt | https://github.com/arturovt |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-736284320 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| arturovt | https://github.com/arturovt |
| December 1, 2020 11:50 | https://github.com/angular/angular/pull/39876#commits-pushed-5d60525 |
|
| https://github.com/arturovt |
|
| https://github.com/mhevery |
| fix(core): remove application from the testability registry when the … | https://github.com/angular/angular/pull/39876/commits/5d6052567374c98404be8c582224a359539b82a3 |
| 5d60525 | https://github.com/angular/angular/pull/39876/commits/5d6052567374c98404be8c582224a359539b82a3 |
| #22106 | https://github.com/angular/angular/issues/22106 |
|
| https://github.com/AndrewKushnir |
| test(core): verify onDestroy callbacks are invoked when ComponentRe… | https://github.com/angular/angular/pull/39876/commits/66e8d75af731ab026c0801b491fc6c7872f56b85 |
| 66e8d75 | https://github.com/angular/angular/pull/39876/commits/66e8d75af731ab026c0801b491fc6c7872f56b85 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#event-4059692836 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Dec 1, 2020 | https://github.com/angular/angular/pull/39876#issuecomment-736887110 |
| Presubmit | http://test/OCL:345112839:BASE:345112864:1606865366971:9e944e20 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Dec 1, 2020
| https://github.com/angular/angular/pull/39876#ref-issue-726552269 |
|
ComponentRef onDestroyed() callback does not get called
#39365
| https://github.com/angular/angular/issues/39365 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Dec 2, 2020
| https://github.com/angular/angular/pull/39876#pullrequestreview-543036606 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39876/files/66e8d75af731ab026c0801b491fc6c7872f56b85 |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/39876#pullrequestreview-543036606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2020
| https://github.com/angular/angular/pull/39876#pullrequestreview-543113128 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39876/files/66e8d75af731ab026c0801b491fc6c7872f56b85 |
| mhevery | https://github.com/mhevery |
| https://github.com/angular/angular/pull/39876#pullrequestreview-543113128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| IgorMinar | https://github.com/IgorMinar |
| December 2, 2020 18:17 | https://github.com/angular/angular/pull/39876#event-4063752793 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| alxhub | https://github.com/alxhub |
| atscott | https://github.com/atscott |
| jelbourn | https://github.com/jelbourn |
| December 2, 2020 18:17 | https://github.com/angular/angular/pull/39876#event-4063752795 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39876#event-4063753996 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39876#event-4063808841 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39876#event-4064346140 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| df27027 | https://github.com/angular/angular/commit/df27027ecb0ac96d503eb97a02f606023f62f60a |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39876#event-4064348237 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-a55e01b |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/mhevery |
| test(core): verify onDestroy callbacks are invoked when ComponentRe… | https://github.com/angular/angular/commit/a55e01b89cb641cc23d20dd677ea7b833c1d6a42 |
| a55e01b | https://github.com/angular/angular/commit/a55e01b89cb641cc23d20dd677ea7b833c1d6a42 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
target: minor
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22 |
| Dec 2, 2020 | https://github.com/angular/angular/pull/39876#event-4064348546 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-37bb320 |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/mhevery |
| test(core): verify onDestroy callbacks are invoked when ComponentRe… | https://github.com/angular/angular/commit/37bb320b7e6dabd05329ba7b1ce588887d92a585 |
| 37bb320 | https://github.com/angular/angular/commit/37bb320b7e6dabd05329ba7b1ce588887d92a585 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| https://github.com/arturovt |
| arturovt | https://github.com/arturovt |
| December 2, 2020 21:12 | https://github.com/angular/angular/pull/39876#event-4064404963 |
| mhevery | https://github.com/mhevery |
|
Dec 3, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-3680ad1 |
|
| https://github.com/arturovt |
|
| https://github.com/mhevery |
| fix(core): remove application from the testability registry when the … | https://github.com/angular/angular/commit/3680ad147b6d16d313e09cfba6e0953cb03cfb27 |
| 3680ad1 | https://github.com/angular/angular/commit/3680ad147b6d16d313e09cfba6e0953cb03cfb27 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| #22106 | https://github.com/angular/angular/issues/22106 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Dec 4, 2020
| https://github.com/angular/angular/pull/39876#ref-pullrequest-297394025 |
|
fix(core): fix memory leak on application reference destroy
#22238
| https://github.com/angular/angular/pull/22238 |
| https://github.com/magnusbakken |
| magnusbakken | https://github.com/magnusbakken |
|
Dec 14, 2020
| https://github.com/angular/angular/pull/39876#ref-issue-766307610 |
|
onDestroy on ComponentRef isn't called in production mode
#40105
| https://github.com/angular/angular/issues/40105 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Dec 14, 2020
| https://github.com/angular/angular/pull/39876#ref-pullrequest-766979014 |
|
fix(core): Call onDestroy in production mode as well
#40120
| https://github.com/angular/angular/pull/40120 |
| mhevery | https://github.com/mhevery |
|
Dec 15, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-948008d |
|
| https://github.com/mhevery |
| fix(core): Call onDestroy in production mode as well | https://github.com/mhevery/angular/commit/948008d529efaf3e4014518b2bd343fb3495ae94 |
| 948008d | https://github.com/mhevery/angular/commit/948008d529efaf3e4014518b2bd343fb3495ae94 |
| angular#39876 | https://github.com/angular/angular/pull/39876 |
| angular#40105 | https://github.com/angular/angular/issues/40105 |
| josephperrott | https://github.com/josephperrott |
|
Dec 22, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-fc1cd07 |
|
| https://github.com/mhevery |
|
| https://github.com/josephperrott |
| fix(core): Call | https://github.com/angular/angular/commit/fc1cd07eb002662c21177f28ef59714f3b2876ed |
| onDestroy | https://github.com/angular/angular/commit/fc1cd07eb002662c21177f28ef59714f3b2876ed |
| in production mode as well ( | https://github.com/angular/angular/commit/fc1cd07eb002662c21177f28ef59714f3b2876ed |
| #40120 | https://github.com/angular/angular/pull/40120 |
| ) | https://github.com/angular/angular/commit/fc1cd07eb002662c21177f28ef59714f3b2876ed |
| fc1cd07 | https://github.com/angular/angular/commit/fc1cd07eb002662c21177f28ef59714f3b2876ed |
| #39876 | https://github.com/angular/angular/pull/39876 |
| #40105 | https://github.com/angular/angular/issues/40105 |
| #40120 | https://github.com/angular/angular/pull/40120 |
| josephperrott | https://github.com/josephperrott |
|
Dec 22, 2020
| https://github.com/angular/angular/pull/39876#ref-commit-632fe60 |
|
| https://github.com/mhevery |
|
| https://github.com/josephperrott |
| fix(core): Call | https://github.com/angular/angular/commit/632fe6011d4ff3b660d49f1ed801ca1838e3bcd5 |
| onDestroy | https://github.com/angular/angular/commit/632fe6011d4ff3b660d49f1ed801ca1838e3bcd5 |
| in production mode as well ( | https://github.com/angular/angular/commit/632fe6011d4ff3b660d49f1ed801ca1838e3bcd5 |
| #40120 | https://github.com/angular/angular/pull/40120 |
| ) | https://github.com/angular/angular/commit/632fe6011d4ff3b660d49f1ed801ca1838e3bcd5 |
| 632fe60 | https://github.com/angular/angular/commit/632fe6011d4ff3b660d49f1ed801ca1838e3bcd5 |
| #39876 | https://github.com/angular/angular/pull/39876 |
| #40105 | https://github.com/angular/angular/issues/40105 |
| #40120 | https://github.com/angular/angular/pull/40120 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 2, 2021 | https://github.com/angular/angular/pull/39876#issuecomment-753497463 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 2, 2021 | https://github.com/angular/angular/pull/39876#event-4161825037 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
| Jan 2, 2021 | https://github.com/angular/angular/pull/39876#event-4161825165 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 2, 2021 | https://github.com/angular/angular/pull/39876#event-4161825192 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39876 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/39876/files/66e8d75af731ab026c0801b491fc6c7872f56b85 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/39876/files/66e8d75af731ab026c0801b491fc6c7872f56b85 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Please reload this page | https://github.com/angular/angular/pull/39876 |
|
| https://github.com/arturovt |
|
| https://github.com/mhevery |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/jessicajaniuk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |