René's URL Explorer Experiment


Title: feat(language-service): watch extended configs for option changes by ayazhafiz · Pull Request #39741 · angular/angular · GitHub

Open Graph Title: feat(language-service): watch extended configs for option changes by ayazhafiz · Pull Request #39741 · angular/angular

X Title: feat(language-service): watch extended configs for option changes by ayazhafiz · Pull Request #39741 · angular/angular

Description: Currently the language service watches only the root config file of a configured project for changes. Of course, for correctness, we should watch for changes in any relevant config file. This commit attaches file watchers to the project root config file, and all known extended config files as determined by readConfiguration. On a change to any config file, refresh the compiler options known by the Angular LS, and attach file watchers for any newly-extended config files.

Open Graph Description: Currently the language service watches only the root config file of a configured project for changes. Of course, for correctness, we should watch for changes in any relevant config file. This commi...

X Description: Currently the language service watches only the root config file of a configured project for changes. Of course, for correctness, we should watch for changes in any relevant config file. This commi...

Opengraph URL: https://github.com/angular/angular/pull/39741

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f29e96fa-f503-13a1-4845-a51293e78b3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB76:33444D:809E7D:AD144E:6B00E06D
html-safe-nonce791aede7d1f21fb22322ac137b0cc4aa7fde654c41213f74de2e55251435a2fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjc2OjMzNDQ0RDo4MDlFN0Q6QUQxNDRFOjZCMDBFMDZEIiwidmlzaXRvcl9pZCI6Ijg3MjEyMzM5ODYwMDY4NjgwNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac11f966f754bebc516da6cbaa87e0ccb4aacebbad82dffad5308b9430bcc6230a
hovercard-subject-tagpull_request:523336388
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/39741/files
twitter:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
og:image:altCurrently the language service watches only the root config file of a configured project for changes. Of course, for correctness, we should watch for changes in any relevant config file. This commi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/39741/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39741%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39741%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39741/files
Reloadhttps://github.com/angular/angular/pull/39741/files
Reloadhttps://github.com/angular/angular/pull/39741/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ayazhafizhttps://github.com/ayazhafiz
angular:masterhttps://github.com/angular/angular/tree/master
ayazhafiz:e/tsconfig-watch2https://github.com/ayazhafiz/angular/tree/e/tsconfig-watch2
Conversation 24 https://github.com/angular/angular/pull/39741
Commits 3 https://github.com/angular/angular/pull/39741/commits
Checks 0 https://github.com/angular/angular/pull/39741/checks
Files changed https://github.com/angular/angular/pull/39741/files
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
feat(language-service): watch extended configs for option changes https://github.com/angular/angular/pull/39741/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/39741/files
3a062db feat(language-service): watch extended configs for option changes ayazhafiz Nov 18, 2020 https://github.com/angular/angular/pull/39741/commits/3a062db41f75ffac5cc5397a736c6048c0e3c333
9280256 fixup! feat(language-service): watch extended configs for option changes ayazhafiz Nov 18, 2020 https://github.com/angular/angular/pull/39741/commits/92802569b4c119aa2cbb110083b1601094e442e8
90442c4 fixup! feat(language-service): watch extended configs for option changes ayazhafiz Nov 19, 2020 https://github.com/angular/angular/pull/39741/commits/90442c40e1369867540a9e4bf4eb3c06f8f1377e
Clear filters https://github.com/angular/angular/pull/39741/files
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
main.ts https://github.com/angular/angular/pull/39741/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
perform_compile.ts https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
perform_watch_spec.ts https://github.com/angular/angular/pull/39741/files#diff-6c1b7350c3e88aae336f9984707dadfd4e17452f680153fa717d8f34d740d45e
language_service.ts https://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
adapters_spec.ts https://github.com/angular/angular/pull/39741/files#diff-75d62629a2df7c9dcf5e9f7a2455225c53cb722897effe06ba2bbb8702ad55b0
language_service_spec.ts https://github.com/angular/angular/pull/39741/files#diff-86b180f0b538bb58f0ce587d73a131de204754325e347ced9cacd4088c57dafc
mock_host.ts https://github.com/angular/angular/pull/39741/files#diff-6349b34bb0c13e10e3683c8eb680fcc269c270e4e2647e697552b902b1f1511c
packages/compiler-cli/src/main.tshttps://github.com/angular/angular/pull/39741/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
View file https://github.com/ayazhafiz/angular/blob/90442c40e1369867540a9e4bf4eb3c06f8f1377e/packages/compiler-cli/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39741/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39741/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
https://github.com/angular/angular/pull/39741/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
https://github.com/angular/angular/pull/39741/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
packages/compiler-cli/src/perform_compile.tshttps://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
View file https://github.com/ayazhafiz/angular/blob/90442c40e1369867540a9e4bf4eb3c06f8f1377e/packages/compiler-cli/src/perform_compile.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39741/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/39741/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
packages/compiler-cli/test/perform_watch_spec.tshttps://github.com/angular/angular/pull/39741/files#diff-6c1b7350c3e88aae336f9984707dadfd4e17452f680153fa717d8f34d740d45e
View file https://github.com/ayazhafiz/angular/blob/90442c40e1369867540a9e4bf4eb3c06f8f1377e/packages/compiler-cli/test/perform_watch_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39741/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39741/files#diff-6c1b7350c3e88aae336f9984707dadfd4e17452f680153fa717d8f34d740d45e
https://github.com/angular/angular/pull/39741/files#diff-6c1b7350c3e88aae336f9984707dadfd4e17452f680153fa717d8f34d740d45e
packages/language-service/ivy/language_service.tshttps://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
View file https://github.com/ayazhafiz/angular/blob/90442c40e1369867540a9e4bf4eb3c06f8f1377e/packages/language-service/ivy/language_service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39741/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
https://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
https://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
JoostKhttps://github.com/JoostK
Nov 18, 2020https://github.com/angular/angular/pull/39741/files#r526438990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
ayazhafizhttps://github.com/ayazhafiz
Nov 18, 2020https://github.com/angular/angular/pull/39741/files#r526466782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
https://github.com/angular/angular/pull/39741/files#diff-d0e0cb05fc486acc996f4d632b30704b84dc8bd49c00cddaf8a1f08f04b7dc2a
packages/language-service/ivy/test/legacy/adapters_spec.tshttps://github.com/angular/angular/pull/39741/files#diff-75d62629a2df7c9dcf5e9f7a2455225c53cb722897effe06ba2bbb8702ad55b0
View file https://github.com/ayazhafiz/angular/blob/90442c40e1369867540a9e4bf4eb3c06f8f1377e/packages/language-service/ivy/test/legacy/adapters_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39741/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/39741/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.