René's URL Explorer Experiment


Title: refactor(core): remove isObservable TODO by petebacondarwin · Pull Request #39669 · angular/angular · GitHub

Open Graph Title: refactor(core): remove isObservable TODO by petebacondarwin · Pull Request #39669 · angular/angular

X Title: refactor(core): remove isObservable TODO by petebacondarwin · Pull Request #39669 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit removes the TODO comment that proposed that we use the built-in RxJS isObservable() function. This is not a viable approach since the built-in function requires that the obj contains ad...

X Description: This commit removes the TODO comment that proposed that we use the built-in RxJS isObservable() function. This is not a viable approach since the built-in function requires that the obj contains ad...

Opengraph URL: https://github.com/angular/angular/pull/39669

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fce03030-b9ce-7e54-34ba-ee47675a98ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD0E:E9D16:10528F5:14ABC32:6B014CB2
html-safe-nonceba08b581869b9fde99451135c246c9a8d68f3cf55a28e31d5862f20e63f14754
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDBFOkU5RDE2OjEwNTI4RjU6MTRBQkMzMjo2QjAxNENCMiIsInZpc2l0b3JfaWQiOiI4NDg0NDkyNzA4NTkxNzgzMDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58bc46f20a061018de12aca41a5d29b38d848d1cebe7873fa5a8cb5ccc133ac6
hovercard-subject-tagpull_request:520424221
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4fc92e57b418f8b1eb9036afd2c6e58c3586dbbfced7988163d0302601684e3a/angular/angular/pull/39669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4fc92e57b418f8b1eb9036afd2c6e58c3586dbbfced7988163d0302601684e3a/angular/angular/pull/39669
og:image:altThis commit removes the TODO comment that proposed that we use the built-in RxJS isObservable() function. This is not a viable approach since the built-in function requires that the obj contains ad...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/39669#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39669
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39669
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39669
Reloadhttps://github.com/angular/angular/pull/39669
Reloadhttps://github.com/angular/angular/pull/39669
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:core-remove-is-observable-todohttps://github.com/petebacondarwin/angular/tree/core-remove-is-observable-todo
Conversationhttps://github.com/angular/angular/pull/39669
Commits1 (1)https://github.com/angular/angular/pull/39669/commits
Checkshttps://github.com/angular/angular/pull/39669/checks
Files changedhttps://github.com/angular/angular/pull/39669/files
refactor(core): remove isObservable TODOhttps://github.com/angular/angular/pull/39669#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:core-remove-is-observable-todohttps://github.com/petebacondarwin/angular/tree/core-remove-is-observable-todo
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 13, 2020https://github.com/angular/angular/pull/39669#issue-742249010
#39643https://github.com/angular/angular/pull/39643
Please reload this pagehttps://github.com/angular/angular/pull/39669
https://github.com/petebacondarwin
refactor(core): remove isObservable TODOhttps://github.com/angular/angular/pull/39669/commits/570850034664d053d486a30bf3468661de4a7631
5708500https://github.com/angular/angular/pull/39669/commits/570850034664d053d486a30bf3468661de4a7631
angular#39643https://github.com/angular/angular/pull/39643
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Nov 13, 2020https://github.com/angular/angular/pull/39669#event-3992292477
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 13, 2020https://github.com/angular/angular/pull/39669#event-3992292712
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 13, 2020https://github.com/angular/angular/pull/39669#event-3992292779
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
November 13, 2020 08:09https://github.com/angular/angular/pull/39669#event-3992292981
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 13, 2020 https://github.com/angular/angular/pull/39669#ref-pullrequest-740105998
feat(common): allow any Subscribable in async pipe #39627 https://github.com/angular/angular/pull/39627
https://github.com/alfaproject
alfaprojecthttps://github.com/alfaproject
Nov 13, 2020 https://github.com/angular/angular/pull/39669#pullrequestreview-529883072
View reviewed changes https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
packages/core/src/util/lang.tshttps://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
alfaprojecthttps://github.com/alfaproject
Nov 13, 2020https://github.com/angular/angular/pull/39669#discussion_r522811418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/39669
petebacondarwinhttps://github.com/petebacondarwin
Nov 13, 2020https://github.com/angular/angular/pull/39669#discussion_r522813920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/39669
atscotthttps://github.com/atscott
Nov 13, 2020https://github.com/angular/angular/pull/39669#discussion_r523114458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#39627https://github.com/angular/angular/pull/39627
Please reload this pagehttps://github.com/angular/angular/pull/39669
https://github.com/gbumanzordev
gbumanzordevhttps://github.com/gbumanzordev
Nov 13, 2020 https://github.com/angular/angular/pull/39669#pullrequestreview-530200248
View reviewed changes https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
https://github.com/atscott
atscotthttps://github.com/atscott
Nov 13, 2020 https://github.com/angular/angular/pull/39669#pullrequestreview-530269581
View reviewed changes https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Nov 16, 2020https://github.com/angular/angular/pull/39669#event-4001472321
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
November 16, 2020 17:26https://github.com/angular/angular/pull/39669#event-4001479068
https://github.com/atscott
atscotthttps://github.com/atscott
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 16, 2020https://github.com/angular/angular/pull/39669#event-4001480586
atscotthttps://github.com/atscott
Nov 16, 2020 https://github.com/angular/angular/pull/39669#ref-commit-b363d96
https://github.com/petebacondarwin
https://github.com/atscott
refactor(core): remove isObservable TODO (https://github.com/angular/angular/commit/b363d96724ba98261744db7ec4fa58a95bf205fe
#39669https://github.com/angular/angular/pull/39669
)https://github.com/angular/angular/commit/b363d96724ba98261744db7ec4fa58a95bf205fe
b363d96https://github.com/angular/angular/commit/b363d96724ba98261744db7ec4fa58a95bf205fe
#39643https://github.com/angular/angular/pull/39643
#39669https://github.com/angular/angular/pull/39669
https://github.com/atscott
atscotthttps://github.com/atscott
7bcfc0dhttps://github.com/angular/angular/commit/7bcfc0db09aa6db485dca1a1c3d67b0580f25f0d
Nov 16, 2020https://github.com/angular/angular/pull/39669#event-4001485993
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
November 19, 2020 10:14https://github.com/angular/angular/pull/39669#event-4015027093
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 20, 2020https://github.com/angular/angular/pull/39669#issuecomment-748630485
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/39669
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 20, 2020https://github.com/angular/angular/pull/39669#event-4133468325
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39669
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
https://github.com/alfaproject
alfaproject https://github.com/alfaproject
https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
https://github.com/gbumanzordev
gbumanzordev https://github.com/gbumanzordev
https://github.com/angular/angular/pull/39669/files/570850034664d053d486a30bf3468661de4a7631
Please reload this pagehttps://github.com/angular/angular/pull/39669
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/39669
https://github.com/petebacondarwin
https://github.com/alfaproject
https://github.com/atscott
https://github.com/gbumanzordev
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.