René's URL Explorer Experiment


Title: feat(common): allow any Subscribable in async pipe by divdavem · Pull Request #39627 · angular/angular · GitHub

Open Graph Title: feat(common): allow any Subscribable in async pipe by divdavem · Pull Request #39627 · angular/angular

X Title: feat(common): allow any Subscribable in async pipe by divdavem · Pull Request #39627 · angular/angular

Description: As only methods from the Subscribable interface are currently used in the implementation of the async pipe, it makes sense to make it explicit so that it works successfully (regarding type-checking) with any other implementation instead of only Observable. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? The following component does not compile successfully: import { Component, Input } from '@angular/core'; import { Subscribable } from 'rxjs'; @Component({ selector: 'hello', template: `Hello {{ nameSubscribable | async }}` }) export class HelloComponent { @Input() nameSubscribable: Subscribable; // Note that it works fine when replacing the above line with: // @Input() nameSubscribable: any; } Here is the compilation error: No overload matches this call. The last overload gave the following error. Argument of type 'Subscribable' is not assignable to parameter of type 'Promise'. Type 'Subscribable' is missing the following properties from type 'Promise': then, catch, [Symbol.toStringTag], finally (cf https://stackblitz.com/edit/angular-ivy-fypzxs?file=src/app/hello.component.ts ) What is the new behavior? The compilation of the previous component is successful. Does this PR introduce a breaking change? Yes No Other information The important part of this PR is about changing the input type from Observable to Subscribable in async pipe. For consistency, I have renamed some local variables to contain subscribable instead of observable. In packages/core/src/util/lang.ts, I have added the isSubscribable function that does the same thing as isObservable but, in case the TODO mentioned in isObservable is implemented those two methods would be different.

Open Graph Description: As only methods from the Subscribable interface are currently used in the implementation of the async pipe, it makes sense to make it explicit so that it works successfully (regarding type-checking...

X Description: As only methods from the Subscribable interface are currently used in the implementation of the async pipe, it makes sense to make it explicit so that it works successfully (regarding type-checking...

Opengraph URL: https://github.com/angular/angular/pull/39627

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab4644f2-cd96-9255-fbdd-f0f57cda5954
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC8A:237673:18D18C6:21270F9:6B014F10
html-safe-nonce1c795df279a7cfb80b6a1bef34e11d6bd35586efc0a56698b47004d355406247
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzhBOjIzNzY3MzoxOEQxOEM2OjIxMjcwRjk6NkIwMTRGMTAiLCJ2aXNpdG9yX2lkIjoiMTEyNTU5MjU2MDc3ODE3MDEyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8000ef96ecb788dfd90a225f2a25d80301b309617f4d11a6886f7529b2c53067
hovercard-subject-tagpull_request:518650914
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/39627/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152706?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152706?s=400&v=4
og:image:altAs only methods from the Subscribable interface are currently used in the implementation of the async pipe, it makes sense to make it explicit so that it works successfully (regarding type-checking...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/39627/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39627%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39627%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39627/files
Reloadhttps://github.com/angular/angular/pull/39627/files
Reloadhttps://github.com/angular/angular/pull/39627/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
divdavemhttps://github.com/divdavem
angular:masterhttps://github.com/angular/angular/tree/master
divdavem:asyncPipeTypehttps://github.com/divdavem/angular/tree/asyncPipeType
Conversation 25 https://github.com/angular/angular/pull/39627
Commits 1 https://github.com/angular/angular/pull/39627/commits
Checks 0 https://github.com/angular/angular/pull/39627/checks
Files changed https://github.com/angular/angular/pull/39627/files
Please reload this pagehttps://github.com/angular/angular/pull/39627/files
feat(common): allow any Subscribable in async pipe https://github.com/angular/angular/pull/39627/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/39627/files
8da7b7e feat(common): allow any Subscribable in async pipe divdavem Nov 10, 2020 https://github.com/angular/angular/pull/39627/commits/8da7b7e71d166954efce828241443b05e6605630
Clear filters https://github.com/angular/angular/pull/39627/files
Please reload this pagehttps://github.com/angular/angular/pull/39627/files
Please reload this pagehttps://github.com/angular/angular/pull/39627/files
common.d.ts https://github.com/angular/angular/pull/39627/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
async_pipe.ts https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
BUILD.bazel https://github.com/angular/angular/pull/39627/files#diff-84ad6ddeaa97cfa6bd48cc6e1253514945ccf3a6f27817625a0e26b22a517d36
async_pipe_spec.ts https://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
core_private_export.ts https://github.com/angular/angular/pull/39627/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
lang.ts https://github.com/angular/angular/pull/39627/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
goldens/public-api/common/common.d.tshttps://github.com/angular/angular/pull/39627/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/goldens/public-api/common/common.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/39627/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
packages/common/src/pipes/async_pipe.tshttps://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/packages/common/src/pipes/async_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/39627/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
packages/common/test/BUILD.bazelhttps://github.com/angular/angular/pull/39627/files#diff-84ad6ddeaa97cfa6bd48cc6e1253514945ccf3a6f27817625a0e26b22a517d36
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/packages/common/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-84ad6ddeaa97cfa6bd48cc6e1253514945ccf3a6f27817625a0e26b22a517d36
https://github.com/angular/angular/pull/39627/files#diff-84ad6ddeaa97cfa6bd48cc6e1253514945ccf3a6f27817625a0e26b22a517d36
packages/common/test/pipes/async_pipe_spec.tshttps://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/packages/common/test/pipes/async_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
Please reload this pagehttps://github.com/angular/angular/pull/39627/files
https://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/39627/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
packages/core/src/core_private_export.tshttps://github.com/angular/angular/pull/39627/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/packages/core/src/core_private_export.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
packages/core/src/util/lang.tshttps://github.com/angular/angular/pull/39627/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
View file https://github.com/divdavem/angular/blob/8da7b7e71d166954efce828241443b05e6605630/packages/core/src/util/lang.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39627/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39627/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
https://github.com/angular/angular/pull/39627/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
https://github.com/angular/angular/pull/39627/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
Please reload this pagehttps://github.com/angular/angular/pull/39627/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.