René's URL Explorer Experiment


Title: 10.2.x fix elements cd on push by gkalpak · Pull Request #39598 · angular/angular · GitHub

Open Graph Title: 10.2.x fix elements cd on push by gkalpak · Pull Request #39598 · angular/angular

X Title: 10.2.x fix elements cd on push by gkalpak · Pull Request #39598 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This is a backport of #39452 to the 10.2.x branch. As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements vie...

X Description: This is a backport of #39452 to the 10.2.x branch. As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements vie...

Opengraph URL: https://github.com/angular/angular/pull/39598

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ad8b1de3-3133-7f85-4eef-c66ef6e4532d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AEE:1201C:D04682:1168F63:6B00FBDB
html-safe-nonce9098dc18ce78df16e141bc3cfa4e6154e19914f248aa53cf9139d9fd80a91325
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUVFOjEyMDFDOkQwNDY4MjoxMTY4RjYzOjZCMDBGQkRCIiwidmlzaXRvcl9pZCI6Ijg4ODQ0NjY0MDg1MjQ2NzYwNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac18b605dfcb5fb4f866f78ef12e776f9034b3012bd70a552c03c85d05cc98a2c7
hovercard-subject-tagpull_request:517144609
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39598/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d755f5f98dbc7050a815a1be8f9031e089dec37c773592623c7b6f616b1dd926/angular/angular/pull/39598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d755f5f98dbc7050a815a1be8f9031e089dec37c773592623c7b6f616b1dd926/angular/angular/pull/39598
og:image:altThis is a backport of #39452 to the 10.2.x branch. As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements vie...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/39598#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39598
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39598
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39598
Reloadhttps://github.com/angular/angular/pull/39598
Reloadhttps://github.com/angular/angular/pull/39598
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:10.2.xhttps://github.com/angular/angular/tree/10.2.x
gkalpak:10.2.x-fix-elements-cd-OnPushhttps://github.com/gkalpak/angular/tree/10.2.x-fix-elements-cd-OnPush
Conversationhttps://github.com/angular/angular/pull/39598
Commits5 (5)https://github.com/angular/angular/pull/39598/commits
Checkshttps://github.com/angular/angular/pull/39598/checks
Files changedhttps://github.com/angular/angular/pull/39598/files
10.2.x fix elements cd on pushhttps://github.com/angular/angular/pull/39598#top
gkalpakhttps://github.com/gkalpak
angular:10.2.xhttps://github.com/angular/angular/tree/10.2.x
gkalpak:10.2.x-fix-elements-cd-OnPushhttps://github.com/gkalpak/angular/tree/10.2.x-fix-elements-cd-OnPush
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 7, 2020https://github.com/angular/angular/pull/39598#issue-738252042
Please reload this pagehttps://github.com/angular/angular/pull/39598
#39452https://github.com/angular/angular/pull/39452
angular/packages/upgrade/src/common/src/downgrade_component_adapter.tshttps://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146
3236ae0https://github.com/angular/angular/commit/3236ae0ee118d0734c90fa9f3767435396213470
#38948https://github.com/angular/angular/issues/38948
Please reload this pagehttps://github.com/angular/angular/pull/39598
gkalpakhttps://github.com/gkalpak
November 7, 2020 16:18https://github.com/angular/angular/pull/39598#commits-pushed-54c3d86
https://github.com/gkalpak
test(elements): fix typo in test description (even if when --> `eve…https://github.com/angular/angular/pull/39598/commits/54c3d8620a40098f644dbf2865fb382193ca5e9b
54c3d86https://github.com/angular/angular/pull/39598/commits/54c3d8620a40098f644dbf2865fb382193ca5e9b
angular#39452https://github.com/angular/angular/pull/39452
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/gkalpak
test(elements): simplify creation of `FakeComponentFactory#componentR…https://github.com/angular/angular/pull/39598/commits/f3148b64efebe3407015a0615402c2fbca4a7407
f3148b6https://github.com/angular/angular/pull/39598/commits/f3148b64efebe3407015a0615402c2fbca4a7407
angular#39452https://github.com/angular/angular/pull/39452
https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObjhttps://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/gkalpak
test(elements): fix ComponentNgElementStrategy test for components …https://github.com/angular/angular/pull/39598/commits/e797be92b8be9a8e3a892e67055aaf84de0e95bd
e797be9https://github.com/angular/angular/pull/39598/commits/e797be92b8be9a8e3a892e67055aaf84de0e95bd
angular#39452https://github.com/angular/angular/pull/39452
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/gkalpak
test(elements): add integration tests for Angular Elements using `Sha…https://github.com/angular/angular/pull/39598/commits/d99314588602d5649b94a8257d7cd9ebb07f6054
d993145https://github.com/angular/angular/pull/39598/commits/d99314588602d5649b94a8257d7cd9ebb07f6054
angular#39452https://github.com/angular/angular/pull/39452
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 7, 2020https://github.com/angular/angular/pull/39598#event-3969937868
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Nov 7, 2020https://github.com/angular/angular/pull/39598#event-3969938326
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 7, 2020https://github.com/angular/angular/pull/39598#event-3969938346
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Nov 7, 2020https://github.com/angular/angular/pull/39598#issuecomment-723454268
https://pr39598-52e6ffe.ngbuilds.io/https://pr39598-52e6ffe.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
November 7, 2020 15:13https://github.com/angular/angular/pull/39598#event-3969972508
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
IgorMinarhttps://github.com/IgorMinar
November 7, 2020 15:13https://github.com/angular/angular/pull/39598#event-3969972597
https://github.com/gkalpak
fix(elements): update the view of an OnPush component when inputs c…https://github.com/angular/angular/pull/39598/commits/6c8ff361440b20564e1782c242b068e7f5ee0666
6c8ff36https://github.com/angular/angular/pull/39598/commits/6c8ff361440b20564e1782c242b068e7f5ee0666
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146
angular#38948https://github.com/angular/angular/issues/38948
angular#39452https://github.com/angular/angular/pull/39452
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/52e6ffe93193eb67e59d85d18c0ea3dd2946786f..6c8ff361440b20564e1782c242b068e7f5ee0666
52e6ffehttps://github.com/angular/angular/commit/52e6ffe93193eb67e59d85d18c0ea3dd2946786f
6c8ff36https://github.com/angular/angular/commit/6c8ff361440b20564e1782c242b068e7f5ee0666
Compare https://github.com/angular/angular/compare/52e6ffe93193eb67e59d85d18c0ea3dd2946786f..6c8ff361440b20564e1782c242b068e7f5ee0666
November 7, 2020 15:17https://github.com/angular/angular/pull/39598#event-3969975627
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Nov 7, 2020https://github.com/angular/angular/pull/39598#issuecomment-723459455
6c8ff36https://github.com/angular/angular/commit/6c8ff361440b20564e1782c242b068e7f5ee0666
https://pr39598-6c8ff36.ngbuilds.io/https://pr39598-6c8ff36.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 7, 2020 https://github.com/angular/angular/pull/39598#pullrequestreview-525663242
View reviewed changes https://github.com/angular/angular/pull/39598/files/6c8ff361440b20564e1782c242b068e7f5ee0666
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/39598/files/6c8ff361440b20564e1782c242b068e7f5ee0666#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
gkalpakhttps://github.com/gkalpak
Nov 7, 2020https://github.com/angular/angular/pull/39598#discussion_r519192302
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
447636https://circleci.com/gh/angular/angular/852592
447914https://circleci.com/gh/angular/angular/852745
Please reload this pagehttps://github.com/angular/angular/pull/39598
sck-ogrrhttps://github.com/sck-ogrr
Nov 15, 2020https://github.com/angular/angular/pull/39598#discussion_r523811849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 7, 2020 https://github.com/angular/angular/pull/39598#pullrequestreview-525663245
View reviewed changes https://github.com/angular/angular/pull/39598/files/6c8ff361440b20564e1782c242b068e7f5ee0666
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/39598/files/6c8ff361440b20564e1782c242b068e7f5ee0666#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
gkalpakhttps://github.com/gkalpak
Nov 7, 2020https://github.com/angular/angular/pull/39598#discussion_r519192312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
431703https://circleci.com/gh/angular/angular/852589
431981https://circleci.com/gh/angular/angular/852748
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 15, 2020https://github.com/angular/angular/pull/39598#issuecomment-727616562
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 15, 2020https://github.com/angular/angular/pull/39598#event-3997684840
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
November 15, 2020 18:43https://github.com/angular/angular/pull/39598#event-3997684904
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 16, 2020https://github.com/angular/angular/pull/39598#issuecomment-746592916
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 16, 2020https://github.com/angular/angular/pull/39598#event-4120661055
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39598
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/sck-ogrr
sck-ogrr https://github.com/sck-ogrr
https://github.com/angular/angular/pull/39598/files/6c8ff361440b20564e1782c242b068e7f5ee0666
Please reload this pagehttps://github.com/angular/angular/pull/39598
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/39598
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/sck-ogrr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.