René's URL Explorer Experiment


Title: fix(core): Access injected parent values using SkipSelf by jessicajaniuk · Pull Request #39464 · angular/angular · GitHub

Open Graph Title: fix(core): Access injected parent values using SkipSelf by jessicajaniuk · Pull Request #39464 · angular/angular

X Title: fix(core): Access injected parent values using SkipSelf by jessicajaniuk · Pull Request #39464 · angular/angular

Description: In ViewEngine, SelfSkip would navigate up the tree to get tokens from the parent node, skipping the child. This restores that functionality in Ivy. In ViewEngine, if a special token (e.g. ElementRef) was not found in the NodeInjector tree, the ModuleInjector was also used to lookup that token. While special tokens like ElementRef make sense only in a context of a NodeInjector, we preserved ViewEngine logic for now to avoid breaking changes. We identified 4 scenarios related to @SkipSelf and special tokens where ViewEngine behavior was incorrect and is likely due to bugs. In Ivy this is implemented to provide a more intuitive API. The list of scenarios can be found below. When Injector is used in combination with @Host and @SkipSelf on the first Component within a module and the injector is defined in the module, ViewEngine will get the injector from the module. In Ivy, it does not do this and throws instead. Test When retrieving a @ViewContainerRef while @SkipSelf and @Host are present, in ViewEngine, it throws an exception. In Ivy it returns the host ViewContainerRef. Test When retrieving a @ViewContainerRef on an embedded view and @SkipSelf is present, in ViewEngine, the ref is null. In Ivy it returns the parent ViewContainerRef. Test When utilizing viewProviders and providers, a child component that is nested within a parent component that has @SkipSelf on a viewProvider value, if that provider is provided by the parent component's viewProviders and providers, ViewEngine will return that parent's viewProviders value, which violates how viewProviders' visibility should work. In Ivy, it retrieves the value from providers, as it should. Test These discrepancies all behave as they should in Ivy and are likely bugs in ViewEngine. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Currently Ivy ignores @SkipSelf entirely, which deviates from ViewEngine and expectations of behavior. Issue Number: 34066, 34819 What is the new behavior? @SkipSelf now properly navigates up the view tree to find the correct injected resource in the parents. Does this PR introduce a breaking change? Yes No Closes #34066, #34819.

Open Graph Description: In ViewEngine, SelfSkip would navigate up the tree to get tokens from the parent node, skipping the child. This restores that functionality in Ivy. In ViewEngine, if a special token (e.g. ElementRe...

X Description: In ViewEngine, SelfSkip would navigate up the tree to get tokens from the parent node, skipping the child. This restores that functionality in Ivy. In ViewEngine, if a special token (e.g. ElementRe...

Opengraph URL: https://github.com/angular/angular/pull/39464

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba820b38-d5cc-c965-0047-82b369f49820
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3D0:EDA7A:19DEC5D:20DA51B:6B01493C
html-safe-nonced78579839bb56f5184372547b13ec73540840e7f54cdb45914d14ae220fdd4bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0QwOkVEQTdBOjE5REVDNUQ6MjBEQTUxQjo2QjAxNDkzQyIsInZpc2l0b3JfaWQiOiIyMjg2MzI1NDQyNjY1MzM1MTAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac01c9abc60dc718a231d78cc4fd2e9d182360900a687e294fa51c94849889187c
hovercard-subject-tagpull_request:511172134
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/39464/files
twitter:imagehttps://avatars.githubusercontent.com/u/72768744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/72768744?s=400&v=4
og:image:altIn ViewEngine, SelfSkip would navigate up the tree to get tokens from the parent node, skipping the child. This restores that functionality in Ivy. In ViewEngine, if a special token (e.g. ElementRe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/39464/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39464%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39464%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39464/files
Reloadhttps://github.com/angular/angular/pull/39464/files
Reloadhttps://github.com/angular/angular/pull/39464/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
jessicajaniukhttps://github.com/jessicajaniuk
angular:masterhttps://github.com/angular/angular/tree/master
jessicajaniuk:skipselfhttps://github.com/jessicajaniuk/angular/tree/skipself
Conversation 165 https://github.com/angular/angular/pull/39464
Commits 5 https://github.com/angular/angular/pull/39464/commits
Checks 0 https://github.com/angular/angular/pull/39464/checks
Files changed https://github.com/angular/angular/pull/39464/files
Please reload this pagehttps://github.com/angular/angular/pull/39464/files
fix(core): Access injected parent values using SkipSelf https://github.com/angular/angular/pull/39464/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/39464/files
aabd1a0 fix(core): Access injected parent values using SelfSkip thePunderWoman Oct 27, 2020 https://github.com/angular/angular/pull/39464/commits/aabd1a0d9f6c748df32e5e51242b3ef6ff3880c4
fa0ce32 fixup! fix(core): Access injected parent values using SelfSkip mhevery Nov 5, 2020 https://github.com/angular/angular/pull/39464/commits/fa0ce3264557b43a73c36d38733d40c1a506ffbb
bbd69a8 fixup! fix(core): Access injected parent values using SelfSkip thePunderWoman Nov 5, 2020 https://github.com/angular/angular/pull/39464/commits/bbd69a800ee9dd5ed99fa303c9d044db334b0d64
0a701bf fixup! fix(core): Access injected parent values using SelfSkip thePunderWoman Nov 5, 2020 https://github.com/angular/angular/pull/39464/commits/0a701bfae4809422c2bdc082fe2d8f3c8e502d07
6a6c475 fixup! fix(core): Access injected parent values using SelfSkip thePunderWoman Nov 5, 2020 https://github.com/angular/angular/pull/39464/commits/6a6c47505f68d42e20756b3b8e972102a918fbce
Clear filters https://github.com/angular/angular/pull/39464/files
Please reload this pagehttps://github.com/angular/angular/pull/39464/files
Please reload this pagehttps://github.com/angular/angular/pull/39464/files
integration-payloads.json https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
di.ts https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
state.ts https://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
di_spec.ts https://github.com/angular/angular/pull/39464/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
bundle.golden_symbols.json https://github.com/angular/angular/pull/39464/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/39464/files#diff-064ba24c47aae98e5c835feff80eb65f7f89ec7493eeea6223165aee99113f3a
bundle.golden_symbols.json https://github.com/angular/angular/pull/39464/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/39464/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
bundle.golden_symbols.json https://github.com/angular/angular/pull/39464/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/jessicajaniuk/angular/blob/6a6c47505f68d42e20756b3b8e972102a918fbce/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39464/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/39464/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
packages/core/src/render3/di.tshttps://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
View file https://github.com/jessicajaniuk/angular/blob/6a6c47505f68d42e20756b3b8e972102a918fbce/packages/core/src/render3/di.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39464/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
Please reload this pagehttps://github.com/angular/angular/pull/39464/files
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/39464/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
packages/core/src/render3/state.tshttps://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
View file https://github.com/jessicajaniuk/angular/blob/6a6c47505f68d42e20756b3b8e972102a918fbce/packages/core/src/render3/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39464/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/39464/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
Please reload this pagehttps://github.com/angular/angular/pull/39464/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.