| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:95936b41-f818-cc67-810d-d19a3edad2ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4BE:3F4253:DC653A:1262B17:6B0104C9 |
| html-safe-nonce | 22fe998efc121cf7b98617917b5cf1ca00ffc3a4171ecf9f3ce332e5f46763b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEJFOjNGNDI1MzpEQzY1M0E6MTI2MkIxNzo2QjAxMDRDOSIsInZpc2l0b3JfaWQiOiI0OTM0ODA4MTM5NDU2MzgyMTUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 12b05897dad6b34a6ba950ce1627bede4272f6d15c7721da51ed5f892d70ad59 |
| hovercard-subject-tag | pull_request:511153446 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/39463/files |
| twitter:image | https://avatars.githubusercontent.com/u/1442575?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1442575?s=400&v=4 |
| og:image:alt | Close #36667, #39524, #39545.
dynamic and bootstrap components has a parent host view as the placeholder.
And also all the hooks are registered to the tView of the host view, not the component view... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/39463/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39463%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39463%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39463/files |
| Reload | https://github.com/angular/angular/pull/39463/files |
| Reload | https://github.com/angular/angular/pull/39463/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JiaLiPassion | https://github.com/JiaLiPassion |
| angular:master | https://github.com/angular/angular/tree/master |
| JiaLiPassion:root-comp-cdr | https://github.com/JiaLiPassion/angular/tree/root-comp-cdr |
|
Conversation
9
| https://github.com/angular/angular/pull/39463 |
|
Commits
5
| https://github.com/angular/angular/pull/39463/commits |
|
Checks
0
| https://github.com/angular/angular/pull/39463/checks |
|
Files changed
| https://github.com/angular/angular/pull/39463/files |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
|
fix(core): dynamic onPush component should trigger change detection correctly
| https://github.com/angular/angular/pull/39463/files#top |
|
Show all changes
5 commits
| https://github.com/angular/angular/pull/39463/files |
|
6003457
fix(core): dynamic onPush component should trigger change detection c…
JiaLiPassion Nov 2, 2020
| https://github.com/angular/angular/pull/39463/commits/6003457a73e1f4372b27556bbfea3a6e8cbdce70 |
|
a6d60ba
test(core): update dynamic onPush component change detection test
JiaLiPassion Nov 3, 2020
| https://github.com/angular/angular/pull/39463/commits/a6d60ba76be03ba6a3618abb00a9746b015d7488 |
|
d5417d8
fix(core): keep onPush not run checkNoChanges behavior
JiaLiPassion Nov 3, 2020
| https://github.com/angular/angular/pull/39463/commits/d5417d8702cd536ac32dda07794bc8f91902d1e1 |
|
8421b26
test(core): update golden symbols
JiaLiPassion Nov 3, 2020
| https://github.com/angular/angular/pull/39463/commits/8421b26b5b3915bdb10c5773789b6e9c3caabdaa |
|
9de4d3d
feat(core): add isOnPushCheckNoChangesEnabled option
JiaLiPassion Nov 4, 2020
| https://github.com/angular/angular/pull/39463/commits/9de4d3d7ecebab47f3846f6d5e090a3782f4e191 |
|
Clear filters
| https://github.com/angular/angular/pull/39463/files |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
|
application_ref.ts
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
component.ts
| https://github.com/angular/angular/pull/39463/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d |
|
shared.ts
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
state.ts
| https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
|
change_detection_spec.ts
| https://github.com/angular/angular/pull/39463/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/39463/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661 |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/39463/files#diff-064ba24c47aae98e5c835feff80eb65f7f89ec7493eeea6223165aee99113f3a |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/39463/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/39463/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/39463/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc |
| packages/core/src/application_ref.ts | https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
View file
| https://github.com/JiaLiPassion/angular/blob/9de4d3d7ecebab47f3846f6d5e090a3782f4e191/packages/core/src/application_ref.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39463/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
| atscott | https://github.com/atscott |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39463/files#r517519154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
| atscott | https://github.com/atscott |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39463/files#r517556516 |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| presubmit | https://test.corp.google.com/ui#id=OCL:340242567:BASE:340666852:1604511736133:24f3550 |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39463/files#r517560204 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
|
| https://github.com/angular/angular/pull/39463/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897 |
| packages/core/src/render3/component.ts | https://github.com/angular/angular/pull/39463/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d |
|
View file
| https://github.com/JiaLiPassion/angular/blob/9de4d3d7ecebab47f3846f6d5e090a3782f4e191/packages/core/src/render3/component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39463/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39463/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d |
|
| https://github.com/angular/angular/pull/39463/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d |
| packages/core/src/render3/instructions/shared.ts | https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
View file
| https://github.com/JiaLiPassion/angular/blob/9de4d3d7ecebab47f3846f6d5e090a3782f4e191/packages/core/src/render3/instructions/shared.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39463/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
|
| https://github.com/angular/angular/pull/39463/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326 |
| packages/core/src/render3/state.ts | https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
|
View file
| https://github.com/JiaLiPassion/angular/blob/9de4d3d7ecebab47f3846f6d5e090a3782f4e191/packages/core/src/render3/state.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39463/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
|
| https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
|
| https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
|
| https://github.com/angular/angular/pull/39463/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf |
| Please reload this page | https://github.com/angular/angular/pull/39463/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |